LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] x86/tsc: Move inline keyword to the beginning of function declarations
@ 2019-05-24 10:32 Mathieu Malaterre
  2019-06-14 15:07 ` [tip:x86/cleanups] " tip-bot for Mathieu Malaterre
  0 siblings, 1 reply; 2+ messages in thread
From: Mathieu Malaterre @ 2019-05-24 10:32 UTC (permalink / raw)
  To: Thomas Gleixner
  Cc: trivial, kernel-janitors, Mathieu Malaterre, Peter Zijlstra,
	Ingo Molnar, Borislav Petkov, H. Peter Anvin, x86, linux-kernel

The inline keyword was not at the beginning of the function declarations.
Fix the following warnings triggered when using W=1:

  arch/x86/kernel/tsc.c:62:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
  arch/x86/kernel/tsc.c:79:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]

Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
 arch/x86/kernel/tsc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 0b29e58f288e..75a41bddbc9d 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -59,7 +59,7 @@ struct cyc2ns {
 
 static DEFINE_PER_CPU_ALIGNED(struct cyc2ns, cyc2ns);
 
-void __always_inline cyc2ns_read_begin(struct cyc2ns_data *data)
+__always_inline void cyc2ns_read_begin(struct cyc2ns_data *data)
 {
 	int seq, idx;
 
@@ -76,7 +76,7 @@ void __always_inline cyc2ns_read_begin(struct cyc2ns_data *data)
 	} while (unlikely(seq != this_cpu_read(cyc2ns.seq.sequence)));
 }
 
-void __always_inline cyc2ns_read_end(void)
+__always_inline void cyc2ns_read_end(void)
 {
 	preempt_enable_notrace();
 }
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:x86/cleanups] x86/tsc: Move inline keyword to the beginning of function declarations
  2019-05-24 10:32 [PATCH] x86/tsc: Move inline keyword to the beginning of function declarations Mathieu Malaterre
@ 2019-06-14 15:07 ` tip-bot for Mathieu Malaterre
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Mathieu Malaterre @ 2019-06-14 15:07 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: mingo, linux-kernel, hpa, tglx, peterz, bp, malat

Commit-ID:  83e837269e87436fda1cbf82214a5494fb6b35b1
Gitweb:     https://git.kernel.org/tip/83e837269e87436fda1cbf82214a5494fb6b35b1
Author:     Mathieu Malaterre <malat@debian.org>
AuthorDate: Fri, 24 May 2019 12:32:51 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 14 Jun 2019 17:02:09 +0200

x86/tsc: Move inline keyword to the beginning of function declarations

The inline keyword was not at the beginning of the function declarations.
Fix the following warnings triggered when using W=1:

  arch/x86/kernel/tsc.c:62:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
  arch/x86/kernel/tsc.c:79:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]

Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: trivial@kernel.org
Cc: kernel-janitors@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Link: https://lkml.kernel.org/r/20190524103252.28575-1-malat@debian.org

---
 arch/x86/kernel/tsc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 0b29e58f288e..75a41bddbc9d 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -59,7 +59,7 @@ struct cyc2ns {
 
 static DEFINE_PER_CPU_ALIGNED(struct cyc2ns, cyc2ns);
 
-void __always_inline cyc2ns_read_begin(struct cyc2ns_data *data)
+__always_inline void cyc2ns_read_begin(struct cyc2ns_data *data)
 {
 	int seq, idx;
 
@@ -76,7 +76,7 @@ void __always_inline cyc2ns_read_begin(struct cyc2ns_data *data)
 	} while (unlikely(seq != this_cpu_read(cyc2ns.seq.sequence)));
 }
 
-void __always_inline cyc2ns_read_end(void)
+__always_inline void cyc2ns_read_end(void)
 {
 	preempt_enable_notrace();
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-14 15:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-24 10:32 [PATCH] x86/tsc: Move inline keyword to the beginning of function declarations Mathieu Malaterre
2019-06-14 15:07 ` [tip:x86/cleanups] " tip-bot for Mathieu Malaterre

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).