From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA82C282E3 for ; Fri, 24 May 2019 13:50:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74864206BA for ; Fri, 24 May 2019 13:50:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P3DLjgak" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403929AbfEXNun (ORCPT ); Fri, 24 May 2019 09:50:43 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:35671 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391124AbfEXNum (ORCPT ); Fri, 24 May 2019 09:50:42 -0400 Received: by mail-qk1-f196.google.com with SMTP id c15so7640585qkl.2; Fri, 24 May 2019 06:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=p8F4WyQZW+GI44XlYkE2TwGfMqACxuEMgKBoIKdGQcU=; b=P3DLjgakvjT7EAxdRbyr6rciA5GOllMVOr5E5Qalw2k7kdxVQRBO5KJoQWjVXPFDbr 2LXSXh/tlmEDqR3dnEYOWJQQSWQv2lcz+5gxg0hBY7wow5DpVBwYTPHNmreVZAKlNG8Q BSBG09n9QlR6TBvyRaeUp+zTs8Amn+Z2mMUFMZgSdR6LSvxLVnNwbmwlMbl0sk80WKo6 6+NBDTPmQ72c6VgiwkRs7a4b9rQGKRWGPTtEQWwQgG6GipX6DyHgNpy6Ng+A7U0cek0M qcGoE0VWSc2W3m+uLHHttAPTwQH0MbqBUyh9oK2wiJhDAd6whVpsz1t8hvnYV+lXV+mX ytdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=p8F4WyQZW+GI44XlYkE2TwGfMqACxuEMgKBoIKdGQcU=; b=LrY5xsBu/rBQW/NZvTaIqdhVMc0+Dh5ulkHr9d4WWCa55xgM9kDzlcS1p0ZYmdwxEk TszH7kl0VLuOcJMJSrKjOtu7lk1ecMDg3hoUcOoKk1jWKLA6OnnFbLZg/JyaW7/0gUb5 7QfreZxA0Nz+yijyyjkLxP5n/GG7K6YQvi6UcWSaxUS8XEbw25lIOKl+lMRcST0vQ7E5 Rf2K+qjauleaOzwuLOyq9nFNXjHDQ5Z883CkoLg4ig8B/Je3bbWtnEQauxl8AtXsFaM7 vxUeAhp18g/NbxZIWTC/NRiMHO5461sEEgjm3M2nKNTQDtwGYBtf9TJetQVrItEB/Mkp jlAQ== X-Gm-Message-State: APjAAAWYH3VR+EnN84oDHPPUMxLkJ3xwO0yWJYmzPuW0TcJNB1yqka1K GRHWgt7YzBY8L0aGt2N9r+o= X-Google-Smtp-Source: APXvYqxIb7KnFdaoUvh+xhdTgH619i0pVWqH9VkoiettkG+ekigRjW25Pf0XMhomyWxIbx+I7n2LbQ== X-Received: by 2002:ac8:2e74:: with SMTP id s49mr85793416qta.23.1558705841124; Fri, 24 May 2019 06:50:41 -0700 (PDT) Received: from smtp.gmail.com ([143.107.45.1]) by smtp.gmail.com with ESMTPSA id u2sm1064043qtq.45.2019.05.24.06.50.37 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 24 May 2019 06:50:40 -0700 (PDT) Date: Fri, 24 May 2019 10:50:35 -0300 From: Marcelo Schmitt To: Alexandru Ardelean Cc: Rodrigo Ribeiro , Lars-Peter Clausen , Michael Hennerich , Stefan Popa , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, LKML , kernel-usp@googlegroups.com, Alexandru Ardelean Subject: Re: [PATCH] staging: iio: adis16240: add of_match_table entry Message-ID: <20190524135034.u2mbtq2jwhp6ent7@smtp.gmail.com> References: <20190524032950.2398-1-rodrigorsdc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexandru, On 05/24, Alexandru Ardelean wrote: > On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro wrote: > > > > This patch adds of_match_table entry in device driver in order to > > enable spi fallback probing. > > > > Signed-off-by: Rodrigo Ribeiro > > Reviewed-by: Marcelo Schmitt > > --- > > drivers/staging/iio/accel/adis16240.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c > > index 8c6d23604eca..b80c8529784b 100644 > > --- a/drivers/staging/iio/accel/adis16240.c > > +++ b/drivers/staging/iio/accel/adis16240.c > > @@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match); > > static struct spi_driver adis16240_driver = { > > .driver = { > > .name = "adis16240", > > + .of_match_table = adis16240_of_match, > > This patch is missing the actual table. Struct with compatible devices table was included separately in a previous patch at commit d9e533b6c0a26c7ef8116b7f3477c164c07bb6fb. Yeah, I also thought it was missing the match table the first time I was this patch. It's really confusing when we have two patches, one depending on another, that are not part of the same patch set. We're trying to avoid things like this the most but that slipped out from our internal review. We're sorry about that. > > > }, > > .probe = adis16240_probe, > > .remove = adis16240_remove, > > -- > > 2.20.1 > >