From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A91FC282E1 for ; Fri, 24 May 2019 20:42:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 556A321871 for ; Fri, 24 May 2019 20:42:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404242AbfEXUmp (ORCPT ); Fri, 24 May 2019 16:42:45 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:52116 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404022AbfEXUmn (ORCPT ); Fri, 24 May 2019 16:42:43 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id E738D80302; Fri, 24 May 2019 22:42:29 +0200 (CEST) Date: Fri, 24 May 2019 22:42:39 +0200 From: Pavel Machek To: Angus Ainslie Cc: angus.ainslie@puri.sm, Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v14 1/3] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit Message-ID: <20190524204239.GA18646@amd> References: <20190524183257.16066-1-angus@akkea.ca> <20190524183257.16066-2-angus@akkea.ca> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FL5UXtIhxfXey3p5" Content-Disposition: inline In-Reply-To: <20190524183257.16066-2-angus@akkea.ca> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --FL5UXtIhxfXey3p5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > + leds { > + compatible =3D "gpio-leds"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_gpio_leds>; > + > + led1 { > + label =3D "LED 1"; > + gpios =3D <&gpio1 13 GPIO_ACTIVE_HIGH>; > + default-state =3D "off"; > + }; > + }; I had comments about these... > + vibrator { > + compatible =3D "gpio-vibrator"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_haptic>; > + enable-gpios =3D <&gpio5 4 GPIO_ACTIVE_LOW>; > + vcc-supply =3D <®_3v3_p>; > + }; Thanks! > + charger@6b { /* bq25896 */ > + compatible =3D "ti,bq25890"; > + reg =3D <0x6b>; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_charger>; > + interrupt-parent =3D <&gpio3>; > + interrupts =3D <25 IRQ_TYPE_EDGE_FALLING>; > + ti,battery-regulation-voltage =3D <4192000>; /* 4.192V */ > + ti,charge-current =3D <1600000>; /* 1.6 A */ > + ti,termination-current =3D <66000>; /* 66mA */ > + ti,precharge-current =3D <1300000>; /* 1.3A */ > + ti,minimum-sys-voltage =3D <2750000>; /* 2.75V */ > + ti,boost-voltage =3D <5000000>; /* 5V */ > + ti,boost-max-current =3D <50000>; /* 50mA */ > + }; And this. Did they get lost somewhere? Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --FL5UXtIhxfXey3p5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlzoVz8ACgkQMOfwapXb+vIdgQCghne8A075NT7kuQmW7jP5hq3r KZUAoKXRSu20WmzRx4utr7RCAfCkzzmY =GIv0 -----END PGP SIGNATURE----- --FL5UXtIhxfXey3p5--