LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: "Joel Fernandes (Google)" <joel@joelfernandes.org> To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" <joel@joelfernandes.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Ingo Molnar <mingo@redhat.com>, Jonathan Corbet <corbet@lwn.net>, Josh Triplett <josh@joshtriplett.org>, kvm-ppc@vger.kernel.org, Lai Jiangshan <jiangshanlai@gmail.com>, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Michael Ellerman <mpe@ellerman.id.au>, Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>, "Paul E. McKenney" <paulmck@linux.ibm.com>, Paul Mackerras <paulus@ozlabs.org>, rcu@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org> Subject: [PATCH RFC 5/5] rcu: Remove rcu_dereference_raw_notrace since no users Date: Fri, 24 May 2019 19:49:33 -0400 [thread overview] Message-ID: <20190524234933.5133-6-joel@joelfernandes.org> (raw) In-Reply-To: <20190524234933.5133-1-joel@joelfernandes.org> The series removes all users of the API and with this patch, the API itself. Also fix documentation. Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> --- Documentation/RCU/Design/Requirements/Requirements.html | 6 +++--- include/linux/rcupdate.h | 9 --------- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/Documentation/RCU/Design/Requirements/Requirements.html b/Documentation/RCU/Design/Requirements/Requirements.html index 5a9238a2883c..9727278893e6 100644 --- a/Documentation/RCU/Design/Requirements/Requirements.html +++ b/Documentation/RCU/Design/Requirements/Requirements.html @@ -2512,9 +2512,9 @@ disabled across the entire RCU read-side critical section. <p> It is possible to use tracing on RCU code, but tracing itself uses RCU. -For this reason, <tt>rcu_dereference_raw_notrace()</tt> -is provided for use by tracing, which avoids the destructive -recursion that could otherwise ensue. +This is the other reason for using, <tt>rcu_dereference_raw()</tt>, +for use by tracing, which avoids the destructive recursion that could +otherwise ensue. This API is also used by virtualization in some architectures, where RCU readers execute in environments in which tracing cannot be used. diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h index 922bb6848813..f917a27fc115 100644 --- a/include/linux/rcupdate.h +++ b/include/linux/rcupdate.h @@ -472,15 +472,6 @@ static inline void rcu_preempt_sleep_check(void) { } __rcu_dereference_check((p), (c) || rcu_read_lock_sched_held(), \ __rcu) -/* - * The tracing infrastructure traces RCU (we want that), but unfortunately - * some of the RCU checks causes tracing to lock up the system. - * - * The no-tracing version of rcu_dereference_raw() must not call - * rcu_read_lock_held(). - */ -#define rcu_dereference_raw_notrace(p) __rcu_dereference_check((p), 1, __rcu) - /** * rcu_dereference_protected() - fetch RCU pointer when updates prevented * @p: The pointer to read, prior to dereferencing -- 2.22.0.rc1.257.g3120a18244-goog
next prev parent reply other threads:[~2019-05-24 23:50 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-24 23:49 [PATCH RFC 0/5] Remove some notrace RCU APIs Joel Fernandes (Google) 2019-05-24 23:49 ` [PATCH RFC 1/5] powerpc: Use regular rcu_dereference_raw API Joel Fernandes (Google) 2019-05-24 23:49 ` [PATCH RFC 2/5] trace: " Joel Fernandes (Google) 2019-05-24 23:49 ` [PATCH RFC 3/5] hashtable: Use the regular hlist_for_each_entry_rcu API Joel Fernandes (Google) 2019-05-24 23:49 ` [PATCH RFC 4/5] rculist: Remove hlist_for_each_entry_rcu_notrace since no users Joel Fernandes (Google) 2019-05-26 16:20 ` Miguel Ojeda 2019-05-24 23:49 ` Joel Fernandes (Google) [this message] 2019-05-25 3:24 ` [PATCH RFC 0/5] Remove some notrace RCU APIs Steven Rostedt 2019-05-25 8:14 ` Joel Fernandes 2019-05-25 11:08 ` Steven Rostedt 2019-05-25 14:19 ` Joel Fernandes 2019-05-25 15:50 ` Paul E. McKenney 2019-05-25 18:14 ` Joel Fernandes 2019-05-25 18:18 ` Joel Fernandes 2019-05-28 12:24 ` Paul E. McKenney 2019-05-28 19:00 ` Joel Fernandes 2019-05-28 20:00 ` Paul E. McKenney
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190524234933.5133-6-joel@joelfernandes.org \ --to=joel@joelfernandes.org \ --cc=benh@kernel.crashing.org \ --cc=corbet@lwn.net \ --cc=jiangshanlai@gmail.com \ --cc=josh@joshtriplett.org \ --cc=kvm-ppc@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mathieu.desnoyers@efficios.com \ --cc=miguel.ojeda.sandonis@gmail.com \ --cc=mingo@redhat.com \ --cc=mpe@ellerman.id.au \ --cc=paulmck@linux.ibm.com \ --cc=paulus@ozlabs.org \ --cc=rcu@vger.kernel.org \ --cc=rostedt@goodmis.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).