LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH -next] f2fs: Make sanity_check_curseg static
@ 2019-05-25 12:48 YueHaibing
2019-05-25 13:56 ` [f2fs-dev] " Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-05-25 12:48 UTC (permalink / raw)
To: jaegeuk, yuchao0; +Cc: linux-kernel, linux-f2fs-devel, YueHaibing
Fix sparse warning:
fs/f2fs/segment.c:4246:5: warning:
symbol 'sanity_check_curseg' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/f2fs/segment.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 1a83115284b9..51f57393ad5b 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -4243,7 +4243,7 @@ static int build_dirty_segmap(struct f2fs_sb_info *sbi)
return init_victim_secmap(sbi);
}
-int sanity_check_curseg(struct f2fs_sb_info *sbi)
+static int sanity_check_curseg(struct f2fs_sb_info *sbi)
{
int i;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [f2fs-dev] [PATCH -next] f2fs: Make sanity_check_curseg static
2019-05-25 12:48 [PATCH -next] f2fs: Make sanity_check_curseg static YueHaibing
@ 2019-05-25 13:56 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2019-05-25 13:56 UTC (permalink / raw)
To: YueHaibing, jaegeuk, yuchao0; +Cc: linux-kernel, linux-f2fs-devel
Haibing,
Thanks for the patch, there is a similar report from 0-day project, but I forget
to fix my v1 patch.
Anyway, I prefer to merge this into original patch which has not upstreamed yet. :)
Thanks,
On 2019-5-25 20:48, YueHaibing wrote:
> Fix sparse warning:
>
> fs/f2fs/segment.c:4246:5: warning:
> symbol 'sanity_check_curseg' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> fs/f2fs/segment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 1a83115284b9..51f57393ad5b 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -4243,7 +4243,7 @@ static int build_dirty_segmap(struct f2fs_sb_info *sbi)
> return init_victim_secmap(sbi);
> }
>
> -int sanity_check_curseg(struct f2fs_sb_info *sbi)
> +static int sanity_check_curseg(struct f2fs_sb_info *sbi)
> {
> int i;
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-25 13:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-25 12:48 [PATCH -next] f2fs: Make sanity_check_curseg static YueHaibing
2019-05-25 13:56 ` [f2fs-dev] " Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).