From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E784BC28CBF for ; Sun, 26 May 2019 14:53:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD93720863 for ; Sun, 26 May 2019 14:53:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558882402; bh=65oYITCZXkSQPpBpB70/9NzgHpXMWdm94uzquU8fZ/k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Zi/IEdwiqObgHs0k4ts2xL7ghnfeXHl7Mw53sMX5Bk3oVdi32pMuGPdiDHqqnvMNb Wac8KV1B2CSoQ7KDgqJSWq6I7G67QayF+s3Xe1Cbx+sOugWCyPbChhqJxWodCE+16m +og2FRvSTKJFRMxQmQt00LSohg3/E3CSVvmjgL1k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727884AbfEZOxW (ORCPT ); Sun, 26 May 2019 10:53:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:52770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727778AbfEZOxV (ORCPT ); Sun, 26 May 2019 10:53:21 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C39E020815; Sun, 26 May 2019 14:53:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558882400; bh=65oYITCZXkSQPpBpB70/9NzgHpXMWdm94uzquU8fZ/k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aCh6xJYA6SIzbiUPSW7Hru5Uoii57tRq9u5tvZ2OAgUw0IyhT+1OYPxOFDqhYPLRY HETxKnSCbqDqOXS0HlTRnh5fqS0OsKL30PWX8oA4C6NH34DYfSF4gZKDiIB4qLdMKJ EfVmJ2TPAxjnyYuG4ncZyesnHtTRDpKO1WiWBEiA= Date: Sun, 26 May 2019 15:53:08 +0100 From: Jonathan Cameron To: "Ardelean, Alexandru" Cc: "marcelo.schmitt1@gmail.com" , "ardeleanalex@gmail.com" , "kernel-usp@googlegroups.com" , "lars@metafoo.de" , "linux-kernel@vger.kernel.org" , "Popa, Stefan Serban" , "knaack.h@gmx.de" , "Hennerich, Michael" , "linux-iio@vger.kernel.org" , "devel@driverdev.osuosl.org" , "rodrigorsdc@gmail.com" , "pmeerw@pmeerw.net" , "gregkh@linuxfoundation.org" Subject: Re: [PATCH] staging: iio: adis16240: add of_match_table entry Message-ID: <20190526155308.5980cb81@archlinux> In-Reply-To: <11a0315e01b80a3a9eb4e81e1b018a2bff7ae559.camel@analog.com> References: <20190524032950.2398-1-rodrigorsdc@gmail.com> <20190524135034.u2mbtq2jwhp6ent7@smtp.gmail.com> <11a0315e01b80a3a9eb4e81e1b018a2bff7ae559.camel@analog.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 May 2019 13:54:49 +0000 "Ardelean, Alexandru" wrote: > On Fri, 2019-05-24 at 10:50 -0300, Marcelo Schmitt wrote: > > [External] > > > > > > Hi Alexandru, > > > > On 05/24, Alexandru Ardelean wrote: > > > On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro wrote: > > > > > > > > This patch adds of_match_table entry in device driver in order to > > > > enable spi fallback probing. > > > > > > > > Signed-off-by: Rodrigo Ribeiro > > > > Reviewed-by: Marcelo Schmitt > > > > --- > > > > drivers/staging/iio/accel/adis16240.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c > > > > index 8c6d23604eca..b80c8529784b 100644 > > > > --- a/drivers/staging/iio/accel/adis16240.c > > > > +++ b/drivers/staging/iio/accel/adis16240.c > > > > @@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match); > > > > static struct spi_driver adis16240_driver = { > > > > .driver = { > > > > .name = "adis16240", > > > > + .of_match_table = adis16240_of_match, > > > > > > This patch is missing the actual table. > > > > Struct with compatible devices table was included separately in a > > previous patch at commit d9e533b6c0a26c7ef8116b7f3477c164c07bb6fb. > > Yeah, I also thought it was missing the match table the first time I was > > this patch. It's really confusing when we have two patches, one > > depending on another, that are not part of the same patch set. We're > > trying to avoid things like this the most but that slipped out from our > > internal review. We're sorry about that. > > No worries. > > It happens to me too. > > Thanks > Alex Oops. I should have caught that one in review as well. Oh well, these things happen. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. I rebased the tree to pick up on all the other stuff in staging/staging-next after the mere window. Thanks, Jonathan > > > > > > > > > > }, > > > > .probe = adis16240_probe, > > > > .remove = adis16240_remove, > > > > -- > > > > 2.20.1 > > > >