LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 00/10] arm64: meson-gx: misc fixes
@ 2019-05-27 13:21 Neil Armstrong
  2019-05-27 13:21 ` [PATCH 01/10] arm64: dts: meson-gxm-khadas-vim2: fix gpio-keys-polled node Neil Armstrong
                   ` (10 more replies)
  0 siblings, 11 replies; 32+ messages in thread
From: Neil Armstrong @ 2019-05-27 13:21 UTC (permalink / raw)
  To: khilman; +Cc: Neil Armstrong, linux-amlogic, linux-arm-kernel, linux-kernel

This patchset :
- Fixes GPIO key DT on Khadas VIM2 board
- Fixes regulator naming on Vega S95 board
- Enable SARADC on Wetek and Vega S95 boards
- Enable/Fix Bluetooth on VIM2, Wetek and Vega S95 boards
- Enable CEC & HDMI on Vega S95 board
- Adds ethernet PHY interrupt on Vega S95 board

Christian Hewitt (4):
  arm64: dts: meson-gxm-khadas-vim2: fix gpio-keys-polled node
  arm64: dts: meson-gxm-khadas-vim2: fix Bluetooth support
  arm64: dts: meson-gxbb-wetek: enable SARADC
  arm64: dts: meson-gxbb-wetek: enable bluetooth

Neil Armstrong (6):
  arm64: dts: meson-gxbb-vega-s95: fix regulators
  arm64: dts: meson-gxbb-vega-s95: add HDMI nodes
  arm64: dts: meson-gxbb-vega-s95: enable CEC
  arm64: dts: meson-gxbb-vega-s95: enable SARADC
  arm64: dts: meson-gxbb-vega-s95: fix WiFi/BT module support
  arm64: dts: meson-gxbb-vega-s95: add ethernet PHY interrupt

 .../boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 93 ++++++++++++++++---
 .../boot/dts/amlogic/meson-gxbb-wetek.dtsi    | 25 +++++
 .../dts/amlogic/meson-gxm-khadas-vim2.dts     | 13 ++-
 3 files changed, 112 insertions(+), 19 deletions(-)

-- 
2.21.0


^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 01/10] arm64: dts: meson-gxm-khadas-vim2: fix gpio-keys-polled node
  2019-05-27 13:21 [PATCH 00/10] arm64: meson-gx: misc fixes Neil Armstrong
@ 2019-05-27 13:21 ` Neil Armstrong
  2019-05-27 18:32   ` Martin Blumenstingl
  2019-06-06 20:00   ` Kevin Hilman
  2019-05-27 13:21 ` [PATCH 02/10] arm64: dts: meson-gxm-khadas-vim2: fix Bluetooth support Neil Armstrong
                   ` (9 subsequent siblings)
  10 siblings, 2 replies; 32+ messages in thread
From: Neil Armstrong @ 2019-05-27 13:21 UTC (permalink / raw)
  To: khilman
  Cc: Christian Hewitt, linux-amlogic, linux-arm-kernel, linux-kernel,
	Neil Armstrong

From: Christian Hewitt <christianshewitt@gmail.com>

Fix DTC warnings:

meson-gxm-khadas-vim2.dtb: Warning (avoid_unnecessary_addr_size):
   /gpio-keys-polled: unnecessary #address-cells/#size-cells
	without "ranges" or child "reg" property

Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2")
Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
index c5f3f90a42ae..25079501f2bb 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
@@ -63,11 +63,9 @@
 
 	gpio-keys-polled {
 		compatible = "gpio-keys-polled";
-		#address-cells = <1>;
-		#size-cells = <0>;
 		poll-interval = <100>;
 
-		button@0 {
+		power-button {
 			label = "power";
 			linux,code = <KEY_POWER>;
 			gpios = <&gpio_ao GPIOAO_2 GPIO_ACTIVE_LOW>;
-- 
2.21.0


^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 02/10] arm64: dts: meson-gxm-khadas-vim2: fix Bluetooth support
  2019-05-27 13:21 [PATCH 00/10] arm64: meson-gx: misc fixes Neil Armstrong
  2019-05-27 13:21 ` [PATCH 01/10] arm64: dts: meson-gxm-khadas-vim2: fix gpio-keys-polled node Neil Armstrong
@ 2019-05-27 13:21 ` Neil Armstrong
  2019-05-27 18:36   ` Martin Blumenstingl
  2019-05-27 13:21 ` [PATCH 03/10] arm64: dts: meson-gxbb-wetek: enable SARADC Neil Armstrong
                   ` (8 subsequent siblings)
  10 siblings, 1 reply; 32+ messages in thread
From: Neil Armstrong @ 2019-05-27 13:21 UTC (permalink / raw)
  To: khilman
  Cc: Christian Hewitt, linux-amlogic, linux-arm-kernel, linux-kernel,
	Neil Armstrong

From: Christian Hewitt <christianshewitt@gmail.com>

- Remove serial1 alias
- Add support for uart_A rts/cts
- Add bluetooth uart_A subnode qith shutdown gpio

Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2")
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
index 25079501f2bb..ff4f0780824d 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
@@ -18,7 +18,6 @@
 
 	aliases {
 		serial0 = &uart_AO;
-		serial1 = &uart_A;
 		serial2 = &uart_AO_B;
 	};
 
@@ -403,8 +402,14 @@
 /* This one is connected to the Bluetooth module */
 &uart_A {
 	status = "okay";
-	pinctrl-0 = <&uart_a_pins>;
+	pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>;
 	pinctrl-names = "default";
+	uart-has-rtscts;
+
+	bluetooth {
+		compatible = "brcm,bcm43438-bt";
+		shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
+	};
 };
 
 /* This is brought out on the Linux_RX (18) and Linux_TX (19) pins: */
-- 
2.21.0


^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 03/10] arm64: dts: meson-gxbb-wetek: enable SARADC
  2019-05-27 13:21 [PATCH 00/10] arm64: meson-gx: misc fixes Neil Armstrong
  2019-05-27 13:21 ` [PATCH 01/10] arm64: dts: meson-gxm-khadas-vim2: fix gpio-keys-polled node Neil Armstrong
  2019-05-27 13:21 ` [PATCH 02/10] arm64: dts: meson-gxm-khadas-vim2: fix Bluetooth support Neil Armstrong
@ 2019-05-27 13:21 ` Neil Armstrong
  2019-05-27 18:15   ` Martin Blumenstingl
  2019-05-27 13:21 ` [PATCH 04/10] arm64: dts: meson-gxbb-wetek: enable bluetooth Neil Armstrong
                   ` (7 subsequent siblings)
  10 siblings, 1 reply; 32+ messages in thread
From: Neil Armstrong @ 2019-05-27 13:21 UTC (permalink / raw)
  To: khilman
  Cc: Christian Hewitt, linux-amlogic, linux-arm-kernel, linux-kernel,
	Neil Armstrong

From: Christian Hewitt <christianshewitt@gmail.com>

Enable SARADC on Wetek Boards.

Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
index b0d74ab619b0..45e306da2154 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
@@ -59,6 +59,13 @@
 		regulator-max-microvolt = <3300000>;
 	};
 
+	vddio_ao18: regulator-vddio_ao18 {
+		compatible = "regulator-fixed";
+		regulator-name = "VDDIO_AO18";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+	};
+
 	vcc_3v3: regulator-vcc_3v3 {
 		compatible = "regulator-fixed";
 		regulator-name = "VCC_3V3";
@@ -172,6 +179,11 @@
 	clock-names = "clkin0";
 };
 
+&saradc {
+	status = "okay";
+	vref-supply = <&vddio_ao18>;
+};
+
 /* Wireless SDIO Module */
 &sd_emmc_a {
 	status = "okay";
-- 
2.21.0


^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 04/10] arm64: dts: meson-gxbb-wetek: enable bluetooth
  2019-05-27 13:21 [PATCH 00/10] arm64: meson-gx: misc fixes Neil Armstrong
                   ` (2 preceding siblings ...)
  2019-05-27 13:21 ` [PATCH 03/10] arm64: dts: meson-gxbb-wetek: enable SARADC Neil Armstrong
@ 2019-05-27 13:21 ` Neil Armstrong
  2019-05-27 18:19   ` Martin Blumenstingl
  2019-05-27 13:21 ` [PATCH 05/10] arm64: dts: meson-gxbb-vega-s95: fix regulators Neil Armstrong
                   ` (6 subsequent siblings)
  10 siblings, 1 reply; 32+ messages in thread
From: Neil Armstrong @ 2019-05-27 13:21 UTC (permalink / raw)
  To: khilman
  Cc: Christian Hewitt, linux-amlogic, linux-arm-kernel, linux-kernel,
	Neil Armstrong

From: Christian Hewitt <christianshewitt@gmail.com>

This enables Bluetooth support for the following models:

AP6335 in the WeTek Hub rev1 - BCM4335C0.hcd
AP6255 in the WeTek Hub rev2 - BCM4345C0.hcd
AP6330 in the WeTek Play 2 - BCM4330B1.hcd

Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
index 45e306da2154..9ef6858779c1 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek.dtsi
@@ -249,6 +249,19 @@
 	vqmmc-supply = <&vddio_boot>;
 };
 
+/* This is connected to the Bluetooth module: */
+&uart_A {
+	status = "okay";
+	pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>;
+	pinctrl-names = "default";
+	uart-has-rtscts;
+
+	bluetooth {
+		compatible = "brcm,bcm43438-bt";
+		shutdown-gpios = <&gpio GPIOX_20 GPIO_ACTIVE_HIGH>;
+	};
+};
+
 /* This UART is brought out to the DB9 connector */
 &uart_AO {
 	status = "okay";
-- 
2.21.0


^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 05/10] arm64: dts: meson-gxbb-vega-s95: fix regulators
  2019-05-27 13:21 [PATCH 00/10] arm64: meson-gx: misc fixes Neil Armstrong
                   ` (3 preceding siblings ...)
  2019-05-27 13:21 ` [PATCH 04/10] arm64: dts: meson-gxbb-wetek: enable bluetooth Neil Armstrong
@ 2019-05-27 13:21 ` Neil Armstrong
  2019-05-27 18:21   ` Martin Blumenstingl
  2019-05-27 13:21 ` [PATCH 06/10] arm64: dts: meson-gxbb-vega-s95: add HDMI nodes Neil Armstrong
                   ` (5 subsequent siblings)
  10 siblings, 1 reply; 32+ messages in thread
From: Neil Armstrong @ 2019-05-27 13:21 UTC (permalink / raw)
  To: khilman
  Cc: Neil Armstrong, linux-amlogic, linux-arm-kernel, linux-kernel,
	christianshewitt

Align the regulator names with other GXBB SoCS for upcoming
SARADC support and SDIO/SDCard fixes.
Also fix how regulators are passed to MMC controllers & USB.

Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 .../boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 34 ++++++++++++-------
 1 file changed, 21 insertions(+), 13 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
index 623bcb6594b1..760730d4e87b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
@@ -28,10 +28,10 @@
 		};
 	};
 
-	usb_vbus: regulator-usb0-vbus {
+	usb_pwr: regulator-usb-pwrs {
 		compatible = "regulator-fixed";
 
-		regulator-name = "USB0_VBUS";
+		regulator-name = "USB_PWR";
 
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
@@ -40,18 +40,25 @@
 		enable-active-high;
 	};
 
-	vcc_3v3: regulator-vcc_3v3 {
+	vddio_boot: regulator-vddio_boot {
 		compatible = "regulator-fixed";
-		regulator-name = "VCC_3V3";
+		regulator-name = "VDDIO_BOOT";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+	};
+
+	vddao_3v3: regulator-vddao_3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "VDDAO_3V3";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 	};
 
-	vcc_1v8: regulator-vcc_1v8 {
+	vcc_3v3: regulator-vcc_3v3 {
 		compatible = "regulator-fixed";
-		regulator-name = "VCC_1V8";
-		regulator-min-microvolt = <1800000>;
-		regulator-max-microvolt = <1800000>;
+		regulator-name = "VCC_3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
 	};
 
 	emmc_pwrseq: emmc-pwrseq {
@@ -133,8 +140,8 @@
 
 	mmc-pwrseq = <&sdio_pwrseq>;
 
-	vmmc-supply = <&vcc_3v3>;
-	vqmmc-supply = <&vcc_1v8>;
+	vmmc-supply = <&vddao_3v3>;
+	vqmmc-supply = <&vddio_boot>;
 
 	brcmf: wifi@1 {
 		reg = <1>;
@@ -156,7 +163,8 @@
 
 	cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
 
-	vmmc-supply = <&vcc_3v3>;
+	vmmc-supply = <&vddao_3v3>;
+	vqmmc-supply = <&vcc_3v3>;
 };
 
 /* eMMC */
@@ -176,7 +184,7 @@
 
 	mmc-pwrseq = <&emmc_pwrseq>;
 	vmmc-supply = <&vcc_3v3>;
-	vmmcq-sumpply = <&vcc_1v8>;
+	vqmmc-supply = <&vddio_boot>;
 };
 
 &uart_AO {
@@ -187,7 +195,7 @@
 
 &usb0_phy {
 	status = "okay";
-	phy-supply = <&usb_vbus>;
+	phy-supply = <&usb_pwr>;
 };
 
 &usb1_phy {
-- 
2.21.0


^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 06/10] arm64: dts: meson-gxbb-vega-s95: add HDMI nodes
  2019-05-27 13:21 [PATCH 00/10] arm64: meson-gx: misc fixes Neil Armstrong
                   ` (4 preceding siblings ...)
  2019-05-27 13:21 ` [PATCH 05/10] arm64: dts: meson-gxbb-vega-s95: fix regulators Neil Armstrong
@ 2019-05-27 13:21 ` Neil Armstrong
  2019-05-27 18:23   ` Martin Blumenstingl
  2019-05-27 13:21 ` [PATCH 07/10] arm64: dts: meson-gxbb-vega-s95: enable CEC Neil Armstrong
                   ` (4 subsequent siblings)
  10 siblings, 1 reply; 32+ messages in thread
From: Neil Armstrong @ 2019-05-27 13:21 UTC (permalink / raw)
  To: khilman
  Cc: Neil Armstrong, linux-amlogic, linux-arm-kernel, linux-kernel,
	christianshewitt

Add HDMI nodes to support graphics on Vega S95

Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 .../boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
index 760730d4e87b..6738b2aac9a0 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
@@ -73,6 +73,17 @@
 		pwms = <&pwm_ef 0 30518 0>; /* PWM_E at 32.768KHz */
 	};
 
+	hdmi-connector {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_connector_in: endpoint {
+				remote-endpoint = <&hdmi_tx_tmds_out>;
+			};
+		};
+	};
+
 	sdio_pwrseq: sdio-pwrseq {
 		compatible = "mmc-pwrseq-simple";
 		reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>,
@@ -108,6 +119,18 @@
 	};
 };
 
+&hdmi_tx {
+	status = "okay";
+	pinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>;
+	pinctrl-names = "default";
+};
+
+&hdmi_tx_tmds_port {
+	hdmi_tx_tmds_out: endpoint {
+		remote-endpoint = <&hdmi_connector_in>;
+	};
+};
+
 &ir {
 	status = "okay";
 	pinctrl-0 = <&remote_input_ao_pins>;
-- 
2.21.0


^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 07/10] arm64: dts: meson-gxbb-vega-s95: enable CEC
  2019-05-27 13:21 [PATCH 00/10] arm64: meson-gx: misc fixes Neil Armstrong
                   ` (5 preceding siblings ...)
  2019-05-27 13:21 ` [PATCH 06/10] arm64: dts: meson-gxbb-vega-s95: add HDMI nodes Neil Armstrong
@ 2019-05-27 13:21 ` Neil Armstrong
  2019-05-27 18:22   ` Martin Blumenstingl
  2019-05-27 13:21 ` [PATCH 08/10] arm64: dts: meson-gxbb-vega-s95: enable SARADC Neil Armstrong
                   ` (3 subsequent siblings)
  10 siblings, 1 reply; 32+ messages in thread
From: Neil Armstrong @ 2019-05-27 13:21 UTC (permalink / raw)
  To: khilman
  Cc: Neil Armstrong, linux-amlogic, linux-arm-kernel, linux-kernel,
	christianshewitt

Add CEC nodes to support CEC communication on Vega S95

Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
index 6738b2aac9a0..be8799653ad7 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
@@ -93,6 +93,13 @@
 	};
 };
 
+&cec_AO {
+	status = "okay";
+	pinctrl-0 = <&ao_cec_pins>;
+	pinctrl-names = "default";
+	hdmi-phandle = <&hdmi_tx>;
+};
+
 &ethmac {
 	status = "okay";
 	pinctrl-0 = <&eth_rgmii_pins>;
-- 
2.21.0


^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 08/10] arm64: dts: meson-gxbb-vega-s95: enable SARADC
  2019-05-27 13:21 [PATCH 00/10] arm64: meson-gx: misc fixes Neil Armstrong
                   ` (6 preceding siblings ...)
  2019-05-27 13:21 ` [PATCH 07/10] arm64: dts: meson-gxbb-vega-s95: enable CEC Neil Armstrong
@ 2019-05-27 13:21 ` Neil Armstrong
  2019-05-27 18:24   ` Martin Blumenstingl
  2019-05-27 13:21 ` [PATCH 09/10] arm64: dts: meson-gxbb-vega-s95: fix WiFi/BT module support Neil Armstrong
                   ` (2 subsequent siblings)
  10 siblings, 1 reply; 32+ messages in thread
From: Neil Armstrong @ 2019-05-27 13:21 UTC (permalink / raw)
  To: khilman
  Cc: Neil Armstrong, linux-amlogic, linux-arm-kernel, linux-kernel,
	christianshewitt

Add SARARC node and associated regulator to support reading the
ADC inputs on the Vega S95

Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
index be8799653ad7..4d2aa4dc59e7 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
@@ -54,6 +54,13 @@
 		regulator-max-microvolt = <3300000>;
 	};
 
+	vddio_ao18: regulator-vddio_ao18 {
+		compatible = "regulator-fixed";
+		regulator-name = "VDDIO_AO18";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+	};
+
 	vcc_3v3: regulator-vcc_3v3 {
 		compatible = "regulator-fixed";
 		regulator-name = "VCC_3V3";
@@ -152,6 +159,11 @@
 	clock-names = "clkin0";
 };
 
+&saradc {
+	status = "okay";
+	vref-supply = <&vddio_ao18>;
+};
+
 /* Wireless SDIO Module */
 &sd_emmc_a {
 	status = "okay";
-- 
2.21.0


^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 09/10] arm64: dts: meson-gxbb-vega-s95: fix WiFi/BT module support
  2019-05-27 13:21 [PATCH 00/10] arm64: meson-gx: misc fixes Neil Armstrong
                   ` (7 preceding siblings ...)
  2019-05-27 13:21 ` [PATCH 08/10] arm64: dts: meson-gxbb-vega-s95: enable SARADC Neil Armstrong
@ 2019-05-27 13:21 ` Neil Armstrong
  2019-05-27 18:27   ` Martin Blumenstingl
  2019-05-27 13:22 ` [PATCH 10/10] arm64: dts: meson-gxbb-vega-s95: add ethernet PHY interrupt Neil Armstrong
  2019-06-03 22:25 ` [PATCH 00/10] arm64: meson-gx: misc fixes Kevin Hilman
  10 siblings, 1 reply; 32+ messages in thread
From: Neil Armstrong @ 2019-05-27 13:21 UTC (permalink / raw)
  To: khilman
  Cc: Neil Armstrong, linux-amlogic, linux-arm-kernel, linux-kernel,
	christianshewitt

Fix the SDIO WiFi support and add proper Bluetooth support on the
Vega S95 board.

Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 .../boot/dts/amlogic/meson-gxbb-vega-s95.dtsi  | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
index 4d2aa4dc59e7..9b52f3dcdd49 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
@@ -93,8 +93,7 @@
 
 	sdio_pwrseq: sdio-pwrseq {
 		compatible = "mmc-pwrseq-simple";
-		reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>,
-				<&gpio GPIOX_20 GPIO_ACTIVE_LOW>;
+		reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>;
 		clocks = <&wifi32k>;
 		clock-names = "ext_clock";
 	};
@@ -167,7 +166,7 @@
 /* Wireless SDIO Module */
 &sd_emmc_a {
 	status = "okay";
-	pinctrl-0 = <&sdio_pins &sdio_irq_pins>;
+	pinctrl-0 = <&sdio_pins>;
 	pinctrl-1 = <&sdio_clk_gate_pins>;
 	pinctrl-names = "default", "clk-gate";
 	#address-cells = <1>;
@@ -229,6 +228,19 @@
 	vqmmc-supply = <&vddio_boot>;
 };
 
+/* This is connected to the Bluetooth module: */
+&uart_A {
+	status = "okay";
+	pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>;
+	pinctrl-names = "default";
+
+	bluetooth {
+		compatible = "brcm,bcm43438-bt";
+		shutdown-gpios = <&gpio GPIOX_20 GPIO_ACTIVE_HIGH>;
+	};
+};
+
+/* This UART is brought out to the DB9 connector */
 &uart_AO {
 	status = "okay";
 	pinctrl-0 = <&uart_ao_a_pins>;
-- 
2.21.0


^ permalink raw reply	[flat|nested] 32+ messages in thread

* [PATCH 10/10] arm64: dts: meson-gxbb-vega-s95: add ethernet PHY interrupt
  2019-05-27 13:21 [PATCH 00/10] arm64: meson-gx: misc fixes Neil Armstrong
                   ` (8 preceding siblings ...)
  2019-05-27 13:21 ` [PATCH 09/10] arm64: dts: meson-gxbb-vega-s95: fix WiFi/BT module support Neil Armstrong
@ 2019-05-27 13:22 ` Neil Armstrong
  2019-05-27 18:25   ` Martin Blumenstingl
  2019-06-03 22:25 ` [PATCH 00/10] arm64: meson-gx: misc fixes Kevin Hilman
  10 siblings, 1 reply; 32+ messages in thread
From: Neil Armstrong @ 2019-05-27 13:22 UTC (permalink / raw)
  To: khilman
  Cc: Neil Armstrong, linux-amlogic, linux-arm-kernel, linux-kernel,
	christianshewitt

Add the external ethernet PHY interrupt on the Vega S95 board.

Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
index 9b52f3dcdd49..18856f28fd60 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
@@ -128,6 +128,9 @@
 		eth_phy0: ethernet-phy@0 {
 			/* Realtek RTL8211F (0x001cc916) */
 			reg = <0>;
+			interrupt-parent = <&gpio_intc>;
+			/* MAC_INTR on GPIOZ_15 */
+			interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
 		};
 	};
 };
-- 
2.21.0


^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 03/10] arm64: dts: meson-gxbb-wetek: enable SARADC
  2019-05-27 13:21 ` [PATCH 03/10] arm64: dts: meson-gxbb-wetek: enable SARADC Neil Armstrong
@ 2019-05-27 18:15   ` Martin Blumenstingl
  2019-05-29 14:17     ` Neil Armstrong
  0 siblings, 1 reply; 32+ messages in thread
From: Martin Blumenstingl @ 2019-05-27 18:15 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: khilman, linux-amlogic, Christian Hewitt, linux-kernel, linux-arm-kernel

On Mon, May 27, 2019 at 3:22 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> From: Christian Hewitt <christianshewitt@gmail.com>
>
> Enable SARADC on Wetek Boards.
as far I as remember there's a story behind this (and it would be nice
to have it documented here):
some of the SCPI firmware revisions don't enable the SAR ADC clock
when reading the SoCs temperature.
if the SAR ADC is disabled in Linux then the common clock framework
will disable the SAR ADC clock.
now, when the SCPI firmware uses the SAR ADC to read the SoC
temperature we only get garbage.

enabling the SAR ADC in Linux "fixes" this issue

> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
with that:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 04/10] arm64: dts: meson-gxbb-wetek: enable bluetooth
  2019-05-27 13:21 ` [PATCH 04/10] arm64: dts: meson-gxbb-wetek: enable bluetooth Neil Armstrong
@ 2019-05-27 18:19   ` Martin Blumenstingl
  0 siblings, 0 replies; 32+ messages in thread
From: Martin Blumenstingl @ 2019-05-27 18:19 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: khilman, linux-amlogic, Christian Hewitt, linux-kernel, linux-arm-kernel

On Mon, May 27, 2019 at 3:23 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> From: Christian Hewitt <christianshewitt@gmail.com>
>
> This enables Bluetooth support for the following models:
>
> AP6335 in the WeTek Hub rev1 - BCM4335C0.hcd
> AP6255 in the WeTek Hub rev2 - BCM4345C0.hcd
> AP6330 in the WeTek Play 2 - BCM4330B1.hcd
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
I don't have any of these boards nor the schematics but the
shutdown-gpio matches with the reference board Bluetooth GPIO and the
rest looks fine, so:
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 05/10] arm64: dts: meson-gxbb-vega-s95: fix regulators
  2019-05-27 13:21 ` [PATCH 05/10] arm64: dts: meson-gxbb-vega-s95: fix regulators Neil Armstrong
@ 2019-05-27 18:21   ` Martin Blumenstingl
  0 siblings, 0 replies; 32+ messages in thread
From: Martin Blumenstingl @ 2019-05-27 18:21 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: khilman, linux-amlogic, christianshewitt, linux-kernel, linux-arm-kernel

On Mon, May 27, 2019 at 3:23 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Align the regulator names with other GXBB SoCS for upcoming
> SARADC support and SDIO/SDCard fixes.
> Also fix how regulators are passed to MMC controllers & USB.
if I understand this last sentence correctly then the usb_pwr
regulator should be moved to &usb1 and passed as vbus-supply there

> Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
apart from that:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 07/10] arm64: dts: meson-gxbb-vega-s95: enable CEC
  2019-05-27 13:21 ` [PATCH 07/10] arm64: dts: meson-gxbb-vega-s95: enable CEC Neil Armstrong
@ 2019-05-27 18:22   ` Martin Blumenstingl
  0 siblings, 0 replies; 32+ messages in thread
From: Martin Blumenstingl @ 2019-05-27 18:22 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: khilman, linux-amlogic, christianshewitt, linux-kernel, linux-arm-kernel

On Mon, May 27, 2019 at 3:23 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Add CEC nodes to support CEC communication on Vega S95
>
> Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
just like on all other boards, so:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 06/10] arm64: dts: meson-gxbb-vega-s95: add HDMI nodes
  2019-05-27 13:21 ` [PATCH 06/10] arm64: dts: meson-gxbb-vega-s95: add HDMI nodes Neil Armstrong
@ 2019-05-27 18:23   ` Martin Blumenstingl
  0 siblings, 0 replies; 32+ messages in thread
From: Martin Blumenstingl @ 2019-05-27 18:23 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: khilman, linux-amlogic, christianshewitt, linux-kernel, linux-arm-kernel

On Mon, May 27, 2019 at 3:23 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Add HDMI nodes to support graphics on Vega S95
>
> Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
just like on all other boards, so:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 08/10] arm64: dts: meson-gxbb-vega-s95: enable SARADC
  2019-05-27 13:21 ` [PATCH 08/10] arm64: dts: meson-gxbb-vega-s95: enable SARADC Neil Armstrong
@ 2019-05-27 18:24   ` Martin Blumenstingl
  2019-05-29 14:17     ` Neil Armstrong
  0 siblings, 1 reply; 32+ messages in thread
From: Martin Blumenstingl @ 2019-05-27 18:24 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: khilman, linux-amlogic, christianshewitt, linux-kernel, linux-arm-kernel

On Mon, May 27, 2019 at 3:23 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Add SARARC node and associated regulator to support reading the
> ADC inputs on the Vega S95
I'm curious: is this the same problem than on the Wetek boards (where
SCPI hwmon reads garbage if SAR ADC is disabled)?

> Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
in any case:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 10/10] arm64: dts: meson-gxbb-vega-s95: add ethernet PHY interrupt
  2019-05-27 13:22 ` [PATCH 10/10] arm64: dts: meson-gxbb-vega-s95: add ethernet PHY interrupt Neil Armstrong
@ 2019-05-27 18:25   ` Martin Blumenstingl
  0 siblings, 0 replies; 32+ messages in thread
From: Martin Blumenstingl @ 2019-05-27 18:25 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: khilman, linux-amlogic, christianshewitt, linux-kernel, linux-arm-kernel

On Mon, May 27, 2019 at 3:24 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Add the external ethernet PHY interrupt on the Vega S95 board.
>
> Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
I don't have this board (anymore, mine died) nor the schematics but it
matches other GXBB boards and looks correct so:
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 09/10] arm64: dts: meson-gxbb-vega-s95: fix WiFi/BT module support
  2019-05-27 13:21 ` [PATCH 09/10] arm64: dts: meson-gxbb-vega-s95: fix WiFi/BT module support Neil Armstrong
@ 2019-05-27 18:27   ` Martin Blumenstingl
  0 siblings, 0 replies; 32+ messages in thread
From: Martin Blumenstingl @ 2019-05-27 18:27 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: khilman, linux-amlogic, christianshewitt, linux-kernel, linux-arm-kernel

On Mon, May 27, 2019 at 3:24 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Fix the SDIO WiFi support and add proper Bluetooth support on the
> Vega S95 board.
>
> Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
I'm the cause of everything that needed fixing here. thank you for
taking care of this, the result looks much better now:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 01/10] arm64: dts: meson-gxm-khadas-vim2: fix gpio-keys-polled node
  2019-05-27 13:21 ` [PATCH 01/10] arm64: dts: meson-gxm-khadas-vim2: fix gpio-keys-polled node Neil Armstrong
@ 2019-05-27 18:32   ` Martin Blumenstingl
  2019-06-06 20:00   ` Kevin Hilman
  1 sibling, 0 replies; 32+ messages in thread
From: Martin Blumenstingl @ 2019-05-27 18:32 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: khilman, linux-amlogic, Christian Hewitt, linux-kernel, linux-arm-kernel

On Mon, May 27, 2019 at 3:22 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> From: Christian Hewitt <christianshewitt@gmail.com>
>
> Fix DTC warnings:
>
> meson-gxm-khadas-vim2.dtb: Warning (avoid_unnecessary_addr_size):
>    /gpio-keys-polled: unnecessary #address-cells/#size-cells
>         without "ranges" or child "reg" property
>
> Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2")
> Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
as well as:
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

> ---
>  arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 +---
there are more boards with the same "problem" out there
we should clean these up at some point as well


Martin

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 02/10] arm64: dts: meson-gxm-khadas-vim2: fix Bluetooth support
  2019-05-27 13:21 ` [PATCH 02/10] arm64: dts: meson-gxm-khadas-vim2: fix Bluetooth support Neil Armstrong
@ 2019-05-27 18:36   ` Martin Blumenstingl
  2019-05-29 10:25     ` Neil Armstrong
  0 siblings, 1 reply; 32+ messages in thread
From: Martin Blumenstingl @ 2019-05-27 18:36 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: khilman, linux-amlogic, Christian Hewitt, linux-kernel, linux-arm-kernel

On Mon, May 27, 2019 at 3:22 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> From: Christian Hewitt <christianshewitt@gmail.com>
>
> - Remove serial1 alias
> - Add support for uart_A rts/cts
> - Add bluetooth uart_A subnode qith shutdown gpio
I tried this on my own Khadas VIM2:
Bluetooth: hci0: command 0x1001 tx timeout
Bluetooth: hci0: BCM: Reading local version info failed (-110)

I'm not sure whether this is specific to my board or what causes this.


Martin

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 02/10] arm64: dts: meson-gxm-khadas-vim2: fix Bluetooth support
  2019-05-27 18:36   ` Martin Blumenstingl
@ 2019-05-29 10:25     ` Neil Armstrong
  2019-05-29 18:08       ` Martin Blumenstingl
  0 siblings, 1 reply; 32+ messages in thread
From: Neil Armstrong @ 2019-05-29 10:25 UTC (permalink / raw)
  To: Martin Blumenstingl
  Cc: khilman, linux-amlogic, Christian Hewitt, linux-kernel, linux-arm-kernel

On 27/05/2019 20:36, Martin Blumenstingl wrote:
> On Mon, May 27, 2019 at 3:22 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> From: Christian Hewitt <christianshewitt@gmail.com>
>>
>> - Remove serial1 alias
>> - Add support for uart_A rts/cts
>> - Add bluetooth uart_A subnode qith shutdown gpio
> I tried this on my own Khadas VIM2:
> Bluetooth: hci0: command 0x1001 tx timeout
> Bluetooth: hci0: BCM: Reading local version info failed (-110)
> 
> I'm not sure whether this is specific to my board or what causes this.

Which kernel version ?

We often see this, growing the delay after probe removes this, it's kind of
random issue that occurs on pre-5.1 kernels.

Neil

> 
> 
> Martin
> 


^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 08/10] arm64: dts: meson-gxbb-vega-s95: enable SARADC
  2019-05-27 18:24   ` Martin Blumenstingl
@ 2019-05-29 14:17     ` Neil Armstrong
  0 siblings, 0 replies; 32+ messages in thread
From: Neil Armstrong @ 2019-05-29 14:17 UTC (permalink / raw)
  To: Martin Blumenstingl
  Cc: khilman, linux-amlogic, christianshewitt, linux-kernel, linux-arm-kernel

On 27/05/2019 20:24, Martin Blumenstingl wrote:
> On Mon, May 27, 2019 at 3:23 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Add SARARC node and associated regulator to support reading the
>> ADC inputs on the Vega S95
> I'm curious: is this the same problem than on the Wetek boards (where
> SCPI hwmon reads garbage if SAR ADC is disabled)?

Yes

> 
>> Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> in any case:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 


^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 03/10] arm64: dts: meson-gxbb-wetek: enable SARADC
  2019-05-27 18:15   ` Martin Blumenstingl
@ 2019-05-29 14:17     ` Neil Armstrong
  0 siblings, 0 replies; 32+ messages in thread
From: Neil Armstrong @ 2019-05-29 14:17 UTC (permalink / raw)
  To: Martin Blumenstingl
  Cc: khilman, linux-amlogic, Christian Hewitt, linux-kernel, linux-arm-kernel

On 27/05/2019 20:15, Martin Blumenstingl wrote:
> On Mon, May 27, 2019 at 3:22 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> From: Christian Hewitt <christianshewitt@gmail.com>
>>
>> Enable SARADC on Wetek Boards.
> as far I as remember there's a story behind this (and it would be nice
> to have it documented here):
> some of the SCPI firmware revisions don't enable the SAR ADC clock
> when reading the SoCs temperature.
> if the SAR ADC is disabled in Linux then the common clock framework
> will disable the SAR ADC clock.
> now, when the SCPI firmware uses the SAR ADC to read the SoC
> temperature we only get garbage.
> 
> enabling the SAR ADC in Linux "fixes" this issue

Yes seems to be this issue solved here

> 
>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> with that:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 


^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 02/10] arm64: dts: meson-gxm-khadas-vim2: fix Bluetooth support
  2019-05-29 10:25     ` Neil Armstrong
@ 2019-05-29 18:08       ` Martin Blumenstingl
  2019-06-03  8:57         ` Neil Armstrong
  0 siblings, 1 reply; 32+ messages in thread
From: Martin Blumenstingl @ 2019-05-29 18:08 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: khilman, linux-amlogic, Christian Hewitt, linux-kernel, linux-arm-kernel

On Wed, May 29, 2019 at 12:25 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> On 27/05/2019 20:36, Martin Blumenstingl wrote:
> > On Mon, May 27, 2019 at 3:22 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
> >>
> >> From: Christian Hewitt <christianshewitt@gmail.com>
> >>
> >> - Remove serial1 alias
> >> - Add support for uart_A rts/cts
> >> - Add bluetooth uart_A subnode qith shutdown gpio
> > I tried this on my own Khadas VIM2:
> > Bluetooth: hci0: command 0x1001 tx timeout
> > Bluetooth: hci0: BCM: Reading local version info failed (-110)
> >
> > I'm not sure whether this is specific to my board or what causes this.
>
> Which kernel version ?
5.2-rc2

it's a Khadas VIM2 Basic (thus it has a AP6356S), board revision v1.2


Martin

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 02/10] arm64: dts: meson-gxm-khadas-vim2: fix Bluetooth support
  2019-05-29 18:08       ` Martin Blumenstingl
@ 2019-06-03  8:57         ` Neil Armstrong
  2019-06-03 11:57           ` Christian Hewitt
  2019-06-06 19:52           ` Martin Blumenstingl
  0 siblings, 2 replies; 32+ messages in thread
From: Neil Armstrong @ 2019-06-03  8:57 UTC (permalink / raw)
  To: Martin Blumenstingl
  Cc: khilman, linux-amlogic, Christian Hewitt, linux-kernel, linux-arm-kernel

Hi,

On 29/05/2019 20:08, Martin Blumenstingl wrote:
> On Wed, May 29, 2019 at 12:25 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> On 27/05/2019 20:36, Martin Blumenstingl wrote:
>>> On Mon, May 27, 2019 at 3:22 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>>>
>>>> From: Christian Hewitt <christianshewitt@gmail.com>
>>>>
>>>> - Remove serial1 alias
>>>> - Add support for uart_A rts/cts
>>>> - Add bluetooth uart_A subnode qith shutdown gpio
>>> I tried this on my own Khadas VIM2:
>>> Bluetooth: hci0: command 0x1001 tx timeout
>>> Bluetooth: hci0: BCM: Reading local version info failed (-110)
>>>
>>> I'm not sure whether this is specific to my board or what causes this.
>>
>> Which kernel version ?
> 5.2-rc2
> 
> it's a Khadas VIM2 Basic (thus it has a AP6356S), board revision v1.2

Can you try with :

clocks = <&wifi32k>;
clock-names = "lpo";

added in the bluetooth node ?

Neil

> 
> 
> Martin
> 


^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 02/10] arm64: dts: meson-gxm-khadas-vim2: fix Bluetooth support
  2019-06-03  8:57         ` Neil Armstrong
@ 2019-06-03 11:57           ` Christian Hewitt
  2019-06-06 19:52           ` Martin Blumenstingl
  1 sibling, 0 replies; 32+ messages in thread
From: Christian Hewitt @ 2019-06-03 11:57 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: Martin Blumenstingl, khilman, linux-amlogic, linux-kernel,
	linux-arm-kernel

On 3 Jun 2019, at 12:57 pm, Neil Armstrong <narmstrong@baylibre.com> wrote:
> 
> On 29/05/2019 20:08, Martin Blumenstingl wrote:
>> On Wed, May 29, 2019 at 12:25 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>> 
>>> On 27/05/2019 20:36, Martin Blumenstingl wrote:
>>>> On Mon, May 27, 2019 at 3:22 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>>>> 
>>>>> From: Christian Hewitt <christianshewitt@gmail.com>
>>>>> 
>>>>> - Remove serial1 alias
>>>>> - Add support for uart_A rts/cts
>>>>> - Add bluetooth uart_A subnode qith shutdown gpio
>>>> I tried this on my own Khadas VIM2:
>>>> Bluetooth: hci0: command 0x1001 tx timeout
>>>> Bluetooth: hci0: BCM: Reading local version info failed (-110)
>>>> 
>>>> I'm not sure whether this is specific to my board or what causes this.
>>> 
>>> Which kernel version ?
>> 5.2-rc2
>> 
>> it's a Khadas VIM2 Basic (thus it has a AP6356S), board revision v1.2
> 
> Can you try with :
> 
> clocks = <&wifi32k>;
> clock-names = "lpo";
> 
> added in the bluetooth node ?

Tested and confirmed working with rev 1.2 ‘basic' and 5.1 kernel with those nodes added.

VIM2:~ # dmesg | grep -i blue
[   10.793600] Bluetooth: Core ver 2.22
[   10.793792] Bluetooth: HCI device and connection manager initialized
[   10.793814] Bluetooth: HCI socket layer initialized
[   10.793821] Bluetooth: L2CAP socket layer initialized
[   10.793851] Bluetooth: SCO socket layer initialized
[   10.801928] Bluetooth: HCI UART driver ver 2.3
[   10.801944] Bluetooth: HCI UART protocol H4 registered
[   10.804919] Bluetooth: HCI UART protocol Broadcom registered
[   10.805025] Bluetooth: HCI UART protocol QCA registered
[   11.016629] Bluetooth: hci0: BCM: chip id 101
[   11.018537] Bluetooth: hci0: BCM: features 0x2f
[   11.043112] Bluetooth: hci0: BCM4354A2
[   11.043134] Bluetooth: hci0: BCM4356A2 (001.003.015) build 0000
[   11.075919] Bluetooth: Generic Bluetooth SDIO driver ver 0.1
[   11.359784] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
[   11.359793] Bluetooth: BNEP filters: protocol multicast
[   11.359811] Bluetooth: BNEP socket layer initialized
[   17.075509] Bluetooth: hci0: BCM4356A2 (001.003.015) build 0266

I use BT remotes to avoid issues with multiple boards responding to IR so it was working before at some point. I assume I dropped a change somewhere in the process of feeding you the batch of patches - apologies!

Christian

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 00/10] arm64: meson-gx: misc fixes
  2019-05-27 13:21 [PATCH 00/10] arm64: meson-gx: misc fixes Neil Armstrong
                   ` (9 preceding siblings ...)
  2019-05-27 13:22 ` [PATCH 10/10] arm64: dts: meson-gxbb-vega-s95: add ethernet PHY interrupt Neil Armstrong
@ 2019-06-03 22:25 ` Kevin Hilman
  10 siblings, 0 replies; 32+ messages in thread
From: Kevin Hilman @ 2019-06-03 22:25 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: Neil Armstrong, linux-amlogic, linux-arm-kernel, linux-kernel

Neil Armstrong <narmstrong@baylibre.com> writes:

> This patchset :
> - Fixes GPIO key DT on Khadas VIM2 board
> - Fixes regulator naming on Vega S95 board
> - Enable SARADC on Wetek and Vega S95 boards
> - Enable/Fix Bluetooth on VIM2, Wetek and Vega S95 boards
> - Enable CEC & HDMI on Vega S95 board
> - Adds ethernet PHY interrupt on Vega S95 board

Series queued for v5.3 with tags from Martin,

Thanks,

Kevin

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 02/10] arm64: dts: meson-gxm-khadas-vim2: fix Bluetooth support
  2019-06-03  8:57         ` Neil Armstrong
  2019-06-03 11:57           ` Christian Hewitt
@ 2019-06-06 19:52           ` Martin Blumenstingl
  1 sibling, 0 replies; 32+ messages in thread
From: Martin Blumenstingl @ 2019-06-06 19:52 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: khilman, linux-amlogic, Christian Hewitt, linux-kernel, linux-arm-kernel

On Mon, Jun 3, 2019 at 10:57 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Hi,
>
> On 29/05/2019 20:08, Martin Blumenstingl wrote:
> > On Wed, May 29, 2019 at 12:25 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
> >>
> >> On 27/05/2019 20:36, Martin Blumenstingl wrote:
> >>> On Mon, May 27, 2019 at 3:22 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
> >>>>
> >>>> From: Christian Hewitt <christianshewitt@gmail.com>
> >>>>
> >>>> - Remove serial1 alias
> >>>> - Add support for uart_A rts/cts
> >>>> - Add bluetooth uart_A subnode qith shutdown gpio
> >>> I tried this on my own Khadas VIM2:
> >>> Bluetooth: hci0: command 0x1001 tx timeout
> >>> Bluetooth: hci0: BCM: Reading local version info failed (-110)
> >>>
> >>> I'm not sure whether this is specific to my board or what causes this.
> >>
> >> Which kernel version ?
> > 5.2-rc2
> >
> > it's a Khadas VIM2 Basic (thus it has a AP6356S), board revision v1.2
>
> Can you try with :
>
> clocks = <&wifi32k>;
> clock-names = "lpo";
>
> added in the bluetooth node ?
that did it!

I think I also found the explanation why:
on my Khadas VIM2 SD card I don't have linux-firmware installed.
Thus the wifi driver will disable the 32kHz LPO clock again, breaking Bluetooth

are you going to send patches for the existing boards or do you want
someone else to do it?


Martin

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 01/10] arm64: dts: meson-gxm-khadas-vim2: fix gpio-keys-polled node
  2019-05-27 13:21 ` [PATCH 01/10] arm64: dts: meson-gxm-khadas-vim2: fix gpio-keys-polled node Neil Armstrong
  2019-05-27 18:32   ` Martin Blumenstingl
@ 2019-06-06 20:00   ` Kevin Hilman
  2019-06-07 13:01     ` Neil Armstrong
  1 sibling, 1 reply; 32+ messages in thread
From: Kevin Hilman @ 2019-06-06 20:00 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: Christian Hewitt, linux-amlogic, linux-arm-kernel, linux-kernel,
	Neil Armstrong

Neil Armstrong <narmstrong@baylibre.com> writes:

> From: Christian Hewitt <christianshewitt@gmail.com>
>
> Fix DTC warnings:
>
> meson-gxm-khadas-vim2.dtb: Warning (avoid_unnecessary_addr_size):
>    /gpio-keys-polled: unnecessary #address-cells/#size-cells
> 	without "ranges" or child "reg" property
>
> Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2")
> Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

This patch is missing a S-o-B from the author (Christian?)

The From, Suggested-by and Signed-off-by send mixed messages.  Please
clarify if if this is missing a signoff from Christian or if the author
is Neil.

Thanks,

Kevin

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 01/10] arm64: dts: meson-gxm-khadas-vim2: fix gpio-keys-polled node
  2019-06-06 20:00   ` Kevin Hilman
@ 2019-06-07 13:01     ` Neil Armstrong
  2019-06-07 16:59       ` Kevin Hilman
  0 siblings, 1 reply; 32+ messages in thread
From: Neil Armstrong @ 2019-06-07 13:01 UTC (permalink / raw)
  To: Kevin Hilman
  Cc: Christian Hewitt, linux-amlogic, linux-arm-kernel, linux-kernel

On 06/06/2019 22:00, Kevin Hilman wrote:
> Neil Armstrong <narmstrong@baylibre.com> writes:
> 
>> From: Christian Hewitt <christianshewitt@gmail.com>
>>
>> Fix DTC warnings:
>>
>> meson-gxm-khadas-vim2.dtb: Warning (avoid_unnecessary_addr_size):
>>    /gpio-keys-polled: unnecessary #address-cells/#size-cells
>> 	without "ranges" or child "reg" property
>>
>> Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2")
>> Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> 
> This patch is missing a S-o-B from the author (Christian?)
> 
> The From, Suggested-by and Signed-off-by send mixed messages.  Please
> clarify if if this is missing a signoff from Christian or if the author
> is Neil.
> 
> Thanks,
> 
> Kevin
> 


The author is Christian Hewitt <christianshewitt@gmail.com>

so s/Suggested-by/Signed-off-by/

Do you need a resend ?

Neil

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: [PATCH 01/10] arm64: dts: meson-gxm-khadas-vim2: fix gpio-keys-polled node
  2019-06-07 13:01     ` Neil Armstrong
@ 2019-06-07 16:59       ` Kevin Hilman
  0 siblings, 0 replies; 32+ messages in thread
From: Kevin Hilman @ 2019-06-07 16:59 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: Christian Hewitt, linux-amlogic, linux-arm-kernel, linux-kernel

Neil Armstrong <narmstrong@baylibre.com> writes:

> On 06/06/2019 22:00, Kevin Hilman wrote:
>> Neil Armstrong <narmstrong@baylibre.com> writes:
>> 
>>> From: Christian Hewitt <christianshewitt@gmail.com>
>>>
>>> Fix DTC warnings:
>>>
>>> meson-gxm-khadas-vim2.dtb: Warning (avoid_unnecessary_addr_size):
>>>    /gpio-keys-polled: unnecessary #address-cells/#size-cells
>>> 	without "ranges" or child "reg" property
>>>
>>> Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2")
>>> Suggested-by: Christian Hewitt <christianshewitt@gmail.com>
>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> 
>> This patch is missing a S-o-B from the author (Christian?)
>> 
>> The From, Suggested-by and Signed-off-by send mixed messages.  Please
>> clarify if if this is missing a signoff from Christian or if the author
>> is Neil.
>> 
>> Thanks,
>> 
>> Kevin
>> 
>
> The author is Christian Hewitt <christianshewitt@gmail.com>
>
> so s/Suggested-by/Signed-off-by/
>
> Do you need a resend ?

No need, I'll fix up locally.

Thanks for clarifying,

Kevin

^ permalink raw reply	[flat|nested] 32+ messages in thread

end of thread, other threads:[~2019-06-07 16:59 UTC | newest]

Thread overview: 32+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-27 13:21 [PATCH 00/10] arm64: meson-gx: misc fixes Neil Armstrong
2019-05-27 13:21 ` [PATCH 01/10] arm64: dts: meson-gxm-khadas-vim2: fix gpio-keys-polled node Neil Armstrong
2019-05-27 18:32   ` Martin Blumenstingl
2019-06-06 20:00   ` Kevin Hilman
2019-06-07 13:01     ` Neil Armstrong
2019-06-07 16:59       ` Kevin Hilman
2019-05-27 13:21 ` [PATCH 02/10] arm64: dts: meson-gxm-khadas-vim2: fix Bluetooth support Neil Armstrong
2019-05-27 18:36   ` Martin Blumenstingl
2019-05-29 10:25     ` Neil Armstrong
2019-05-29 18:08       ` Martin Blumenstingl
2019-06-03  8:57         ` Neil Armstrong
2019-06-03 11:57           ` Christian Hewitt
2019-06-06 19:52           ` Martin Blumenstingl
2019-05-27 13:21 ` [PATCH 03/10] arm64: dts: meson-gxbb-wetek: enable SARADC Neil Armstrong
2019-05-27 18:15   ` Martin Blumenstingl
2019-05-29 14:17     ` Neil Armstrong
2019-05-27 13:21 ` [PATCH 04/10] arm64: dts: meson-gxbb-wetek: enable bluetooth Neil Armstrong
2019-05-27 18:19   ` Martin Blumenstingl
2019-05-27 13:21 ` [PATCH 05/10] arm64: dts: meson-gxbb-vega-s95: fix regulators Neil Armstrong
2019-05-27 18:21   ` Martin Blumenstingl
2019-05-27 13:21 ` [PATCH 06/10] arm64: dts: meson-gxbb-vega-s95: add HDMI nodes Neil Armstrong
2019-05-27 18:23   ` Martin Blumenstingl
2019-05-27 13:21 ` [PATCH 07/10] arm64: dts: meson-gxbb-vega-s95: enable CEC Neil Armstrong
2019-05-27 18:22   ` Martin Blumenstingl
2019-05-27 13:21 ` [PATCH 08/10] arm64: dts: meson-gxbb-vega-s95: enable SARADC Neil Armstrong
2019-05-27 18:24   ` Martin Blumenstingl
2019-05-29 14:17     ` Neil Armstrong
2019-05-27 13:21 ` [PATCH 09/10] arm64: dts: meson-gxbb-vega-s95: fix WiFi/BT module support Neil Armstrong
2019-05-27 18:27   ` Martin Blumenstingl
2019-05-27 13:22 ` [PATCH 10/10] arm64: dts: meson-gxbb-vega-s95: add ethernet PHY interrupt Neil Armstrong
2019-05-27 18:25   ` Martin Blumenstingl
2019-06-03 22:25 ` [PATCH 00/10] arm64: meson-gx: misc fixes Kevin Hilman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).