LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2 1/6] i2c: core: Allow whole core to use i2c_dev_irq_from_resources
@ 2019-05-27 15:19 Charles Keepax
  2019-05-27 15:19 ` [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions Charles Keepax
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Charles Keepax @ 2019-05-27 15:19 UTC (permalink / raw)
  To: wsa, mika.westerberg
  Cc: jarkko.nikula, andriy.shevchenko, linux-i2c, linux-acpi,
	linux-kernel, benjamin.tissoires, jbroadus, patches

Remove the static from i2c_dev_irq_from _resources so that other parts
of the core code can use this helper function.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---

Patch new since v1, factored out from Use available IRQ helper
functions.

Thanks,
Charles

 drivers/i2c/i2c-core-base.c | 4 ++--
 drivers/i2c/i2c-core.h      | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index d389d4fb0623a..84bf11b25a120 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -687,8 +687,8 @@ static void i2c_dev_set_name(struct i2c_adapter *adap,
 		     i2c_encode_flags_to_addr(client));
 }
 
-static int i2c_dev_irq_from_resources(const struct resource *resources,
-				      unsigned int num_resources)
+int i2c_dev_irq_from_resources(const struct resource *resources,
+			       unsigned int num_resources)
 {
 	struct irq_data *irqd;
 	int i;
diff --git a/drivers/i2c/i2c-core.h b/drivers/i2c/i2c-core.h
index c88cfef813431..8f3a08dc73a25 100644
--- a/drivers/i2c/i2c-core.h
+++ b/drivers/i2c/i2c-core.h
@@ -28,6 +28,8 @@ extern struct list_head	__i2c_board_list;
 extern int		__i2c_first_dynamic_bus_num;
 
 int i2c_check_7bit_addr_validity_strict(unsigned short addr);
+int i2c_dev_irq_from_resources(const struct resource *resources,
+			       unsigned int num_resources);
 
 /*
  * We only allow atomic transfers for very late communication, e.g. to send
-- 
2.11.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions
  2019-05-27 15:19 [PATCH v2 1/6] i2c: core: Allow whole core to use i2c_dev_irq_from_resources Charles Keepax
@ 2019-05-27 15:19 ` Charles Keepax
  2019-05-28 10:30   ` Mika Westerberg
  2019-05-27 15:19 ` [PATCH v2 3/6] i2c: acpi: Factor out getting the IRQ from ACPI Charles Keepax
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 10+ messages in thread
From: Charles Keepax @ 2019-05-27 15:19 UTC (permalink / raw)
  To: wsa, mika.westerberg
  Cc: jarkko.nikula, andriy.shevchenko, linux-i2c, linux-acpi,
	linux-kernel, benjamin.tissoires, jbroadus, patches

Use the available IRQ helper functions, most of the functions have
additional helpful side affects like configuring the trigger type of the
IRQ.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---

Changes since v1:
 - Moved earlier in the patch series.

 drivers/i2c/i2c-core-acpi.c | 24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)

diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c
index 2728006920888..4b0387d040698 100644
--- a/drivers/i2c/i2c-core-acpi.c
+++ b/drivers/i2c/i2c-core-acpi.c
@@ -137,14 +137,25 @@ static int i2c_acpi_do_lookup(struct acpi_device *adev,
 	return 0;
 }
 
+static int i2c_acpi_add_resource(struct acpi_resource *ares, void *data)
+{
+	int *irq = data;
+	struct resource r;
+
+	if (*irq < 0 && acpi_dev_resource_interrupt(ares, 0, &r))
+		*irq = i2c_dev_irq_from_resources(&r, 1);
+
+	return 1; /* No need to add resource to the list */
+}
+
 static int i2c_acpi_get_info(struct acpi_device *adev,
 			     struct i2c_board_info *info,
 			     struct i2c_adapter *adapter,
 			     acpi_handle *adapter_handle)
 {
 	struct list_head resource_list;
-	struct resource_entry *entry;
 	struct i2c_acpi_lookup lookup;
+	int irq = -ENOENT;
 	int ret;
 
 	memset(&lookup, 0, sizeof(lookup));
@@ -176,16 +187,13 @@ static int i2c_acpi_get_info(struct acpi_device *adev,
 
 	/* Then fill IRQ number if any */
 	INIT_LIST_HEAD(&resource_list);
-	ret = acpi_dev_get_resources(adev, &resource_list, NULL, NULL);
+	ret = acpi_dev_get_resources(adev, &resource_list,
+				     i2c_acpi_add_resource, &irq);
 	if (ret < 0)
 		return -EINVAL;
 
-	resource_list_for_each_entry(entry, &resource_list) {
-		if (resource_type(entry->res) == IORESOURCE_IRQ) {
-			info->irq = entry->res->start;
-			break;
-		}
-	}
+	if (irq >= 0)
+		info->irq = irq;
 
 	acpi_dev_free_resource_list(&resource_list);
 
-- 
2.11.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 3/6] i2c: acpi: Factor out getting the IRQ from ACPI
  2019-05-27 15:19 [PATCH v2 1/6] i2c: core: Allow whole core to use i2c_dev_irq_from_resources Charles Keepax
  2019-05-27 15:19 ` [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions Charles Keepax
@ 2019-05-27 15:19 ` Charles Keepax
  2019-05-28  8:37   ` Charles Keepax
  2019-05-28 10:35   ` Mika Westerberg
  2019-05-27 15:19 ` [PATCH v2 4/6] i2c: core: Move ACPI IRQ handling to probe time Charles Keepax
                   ` (2 subsequent siblings)
  4 siblings, 2 replies; 10+ messages in thread
From: Charles Keepax @ 2019-05-27 15:19 UTC (permalink / raw)
  To: wsa, mika.westerberg
  Cc: jarkko.nikula, andriy.shevchenko, linux-i2c, linux-acpi,
	linux-kernel, benjamin.tissoires, jbroadus, patches

In preparation for future refactoring factor out the fetch of the IRQ
into its own helper function.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---

Changes since v1:
 - Update function to just return the IRQ rather than use a pointer
   argument.

Thanks,
Charles

 drivers/i2c/i2c-core-acpi.c | 33 +++++++++++++++++++++------------
 1 file changed, 21 insertions(+), 12 deletions(-)

diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c
index 4b0387d040698..f28d702dc6a89 100644
--- a/drivers/i2c/i2c-core-acpi.c
+++ b/drivers/i2c/i2c-core-acpi.c
@@ -148,14 +148,30 @@ static int i2c_acpi_add_resource(struct acpi_resource *ares, void *data)
 	return 1; /* No need to add resource to the list */
 }
 
+static int i2c_acpi_get_irq(struct acpi_device *adev)
+{
+	struct list_head resource_list;
+	int irq = -ENOENT;
+	int ret;
+
+	INIT_LIST_HEAD(&resource_list);
+
+	ret = acpi_dev_get_resources(adev, &resource_list,
+				     i2c_acpi_add_resource, &irq);
+	if (ret < 0)
+		return -EINVAL;
+
+	acpi_dev_free_resource_list(&resource_list);
+
+	return irq;
+}
+
 static int i2c_acpi_get_info(struct acpi_device *adev,
 			     struct i2c_board_info *info,
 			     struct i2c_adapter *adapter,
 			     acpi_handle *adapter_handle)
 {
-	struct list_head resource_list;
 	struct i2c_acpi_lookup lookup;
-	int irq = -ENOENT;
 	int ret;
 
 	memset(&lookup, 0, sizeof(lookup));
@@ -186,16 +202,9 @@ static int i2c_acpi_get_info(struct acpi_device *adev,
 		*adapter_handle = lookup.adapter_handle;
 
 	/* Then fill IRQ number if any */
-	INIT_LIST_HEAD(&resource_list);
-	ret = acpi_dev_get_resources(adev, &resource_list,
-				     i2c_acpi_add_resource, &irq);
-	if (ret < 0)
-		return -EINVAL;
-
-	if (irq >= 0)
-		info->irq = irq;
-
-	acpi_dev_free_resource_list(&resource_list);
+	ret = i2c_acpi_get_irq(adev);
+	if (ret >= 0)
+		info->irq = ret;
 
 	acpi_set_modalias(adev, dev_name(&adev->dev), info->type,
 			  sizeof(info->type));
-- 
2.11.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 4/6] i2c: core: Move ACPI IRQ handling to probe time
  2019-05-27 15:19 [PATCH v2 1/6] i2c: core: Allow whole core to use i2c_dev_irq_from_resources Charles Keepax
  2019-05-27 15:19 ` [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions Charles Keepax
  2019-05-27 15:19 ` [PATCH v2 3/6] i2c: acpi: Factor out getting the IRQ from ACPI Charles Keepax
@ 2019-05-27 15:19 ` Charles Keepax
  2019-05-27 15:19 ` [PATCH v2 5/6] i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irq Charles Keepax
  2019-05-27 15:19 ` [PATCH v2 6/6] i2c: core: Tidy up handling of init_irq Charles Keepax
  4 siblings, 0 replies; 10+ messages in thread
From: Charles Keepax @ 2019-05-27 15:19 UTC (permalink / raw)
  To: wsa, mika.westerberg
  Cc: jarkko.nikula, andriy.shevchenko, linux-i2c, linux-acpi,
	linux-kernel, benjamin.tissoires, jbroadus, patches

Bring the ACPI path in sync with the device tree path and handle all the
IRQ fetching at probe time. This leaves the only IRQ handling at device
registration time being that which is passed directly through the board
info as either a resource or an actual IRQ number.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---

Changes since v1:
 - Kept function call on a single line despite going a couple characters
   over line length.

Thanks,
Charles

 drivers/i2c/i2c-core-acpi.c | 8 ++------
 drivers/i2c/i2c-core-base.c | 5 ++++-
 drivers/i2c/i2c-core.h      | 7 +++++++
 3 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c
index f28d702dc6a89..133fa9fa239f7 100644
--- a/drivers/i2c/i2c-core-acpi.c
+++ b/drivers/i2c/i2c-core-acpi.c
@@ -148,8 +148,9 @@ static int i2c_acpi_add_resource(struct acpi_resource *ares, void *data)
 	return 1; /* No need to add resource to the list */
 }
 
-static int i2c_acpi_get_irq(struct acpi_device *adev)
+int i2c_acpi_get_irq(struct i2c_client *client)
 {
+	struct acpi_device *adev = ACPI_COMPANION(&client->adapter->dev);
 	struct list_head resource_list;
 	int irq = -ENOENT;
 	int ret;
@@ -201,11 +202,6 @@ static int i2c_acpi_get_info(struct acpi_device *adev,
 	if (adapter_handle)
 		*adapter_handle = lookup.adapter_handle;
 
-	/* Then fill IRQ number if any */
-	ret = i2c_acpi_get_irq(adev);
-	if (ret >= 0)
-		info->irq = ret;
-
 	acpi_set_modalias(adev, dev_name(&adev->dev), info->type,
 			  sizeof(info->type));
 
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 84bf11b25a120..b6b009bfe842b 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -335,7 +335,10 @@ static int i2c_device_probe(struct device *dev)
 			if (irq == -EINVAL || irq == -ENODATA)
 				irq = of_irq_get(dev->of_node, 0);
 		} else if (ACPI_COMPANION(dev)) {
-			irq = acpi_dev_gpio_irq_get(ACPI_COMPANION(dev), 0);
+			irq = i2c_acpi_get_irq(client);
+
+			if (irq == -ENOENT)
+				irq = acpi_dev_gpio_irq_get(ACPI_COMPANION(dev), 0);
 		}
 		if (irq == -EPROBE_DEFER)
 			return irq;
diff --git a/drivers/i2c/i2c-core.h b/drivers/i2c/i2c-core.h
index 8f3a08dc73a25..15c1411f35f07 100644
--- a/drivers/i2c/i2c-core.h
+++ b/drivers/i2c/i2c-core.h
@@ -72,6 +72,8 @@ const struct acpi_device_id *
 i2c_acpi_match_device(const struct acpi_device_id *matches,
 		      struct i2c_client *client);
 void i2c_acpi_register_devices(struct i2c_adapter *adap);
+
+int i2c_acpi_get_irq(struct i2c_client *client);
 #else /* CONFIG_ACPI */
 static inline void i2c_acpi_register_devices(struct i2c_adapter *adap) { }
 static inline const struct acpi_device_id *
@@ -80,6 +82,11 @@ i2c_acpi_match_device(const struct acpi_device_id *matches,
 {
 	return NULL;
 }
+
+static inline int i2c_acpi_get_irq(struct i2c_client *client)
+{
+	return 0;
+}
 #endif /* CONFIG_ACPI */
 extern struct notifier_block i2c_acpi_notifier;
 
-- 
2.11.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 5/6] i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irq
  2019-05-27 15:19 [PATCH v2 1/6] i2c: core: Allow whole core to use i2c_dev_irq_from_resources Charles Keepax
                   ` (2 preceding siblings ...)
  2019-05-27 15:19 ` [PATCH v2 4/6] i2c: core: Move ACPI IRQ handling to probe time Charles Keepax
@ 2019-05-27 15:19 ` Charles Keepax
  2019-05-27 15:19 ` [PATCH v2 6/6] i2c: core: Tidy up handling of init_irq Charles Keepax
  4 siblings, 0 replies; 10+ messages in thread
From: Charles Keepax @ 2019-05-27 15:19 UTC (permalink / raw)
  To: wsa, mika.westerberg
  Cc: jarkko.nikula, andriy.shevchenko, linux-i2c, linux-acpi,
	linux-kernel, benjamin.tissoires, jbroadus, patches

It makes sense to contain all the ACPI IRQ handling in a single helper
function.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---

Changes since v1:
 - Use adev directly in i2c_acpi_get_irq

Thanks,
Charles

 drivers/i2c/i2c-core-acpi.c | 3 +++
 drivers/i2c/i2c-core-base.c | 3 ---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c
index 133fa9fa239f7..5d612b99c569b 100644
--- a/drivers/i2c/i2c-core-acpi.c
+++ b/drivers/i2c/i2c-core-acpi.c
@@ -164,6 +164,9 @@ int i2c_acpi_get_irq(struct i2c_client *client)
 
 	acpi_dev_free_resource_list(&resource_list);
 
+	if (irq == -ENOENT)
+		irq = acpi_dev_gpio_irq_get(adev, 0);
+
 	return irq;
 }
 
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index b6b009bfe842b..684ea2665d994 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -336,9 +336,6 @@ static int i2c_device_probe(struct device *dev)
 				irq = of_irq_get(dev->of_node, 0);
 		} else if (ACPI_COMPANION(dev)) {
 			irq = i2c_acpi_get_irq(client);
-
-			if (irq == -ENOENT)
-				irq = acpi_dev_gpio_irq_get(ACPI_COMPANION(dev), 0);
 		}
 		if (irq == -EPROBE_DEFER)
 			return irq;
-- 
2.11.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 6/6] i2c: core: Tidy up handling of init_irq
  2019-05-27 15:19 [PATCH v2 1/6] i2c: core: Allow whole core to use i2c_dev_irq_from_resources Charles Keepax
                   ` (3 preceding siblings ...)
  2019-05-27 15:19 ` [PATCH v2 5/6] i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irq Charles Keepax
@ 2019-05-27 15:19 ` Charles Keepax
  4 siblings, 0 replies; 10+ messages in thread
From: Charles Keepax @ 2019-05-27 15:19 UTC (permalink / raw)
  To: wsa, mika.westerberg
  Cc: jarkko.nikula, andriy.shevchenko, linux-i2c, linux-acpi,
	linux-kernel, benjamin.tissoires, jbroadus, patches

Only set init_irq during i2c_device_new and only handle client->irq on
the probe/remove paths.

Suggested-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---

No changes since v1.

Thanks,
Charles

 drivers/i2c/i2c-core-base.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 684ea2665d994..6d4904cdf58ac 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -322,6 +322,8 @@ static int i2c_device_probe(struct device *dev)
 
 	driver = to_i2c_driver(dev->driver);
 
+	client->irq = client->init_irq;
+
 	if (!client->irq && !driver->disable_i2c_core_irq_mapping) {
 		int irq = -ENOENT;
 
@@ -432,7 +434,7 @@ static int i2c_device_remove(struct device *dev)
 	dev_pm_clear_wake_irq(&client->dev);
 	device_init_wakeup(&client->dev, false);
 
-	client->irq = client->init_irq;
+	client->irq = 0;
 	if (client->flags & I2C_CLIENT_HOST_NOTIFY)
 		pm_runtime_put(&client->adapter->dev);
 
@@ -749,7 +751,6 @@ i2c_new_client_device(struct i2c_adapter *adap, struct i2c_board_info const *inf
 	if (!client->init_irq)
 		client->init_irq = i2c_dev_irq_from_resources(info->resources,
 							 info->num_resources);
-	client->irq = client->init_irq;
 
 	strlcpy(client->name, info->type, sizeof(client->name));
 
-- 
2.11.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/6] i2c: acpi: Factor out getting the IRQ from ACPI
  2019-05-27 15:19 ` [PATCH v2 3/6] i2c: acpi: Factor out getting the IRQ from ACPI Charles Keepax
@ 2019-05-28  8:37   ` Charles Keepax
  2019-05-28 10:35   ` Mika Westerberg
  1 sibling, 0 replies; 10+ messages in thread
From: Charles Keepax @ 2019-05-28  8:37 UTC (permalink / raw)
  To: wsa, mika.westerberg
  Cc: jarkko.nikula, andriy.shevchenko, linux-i2c, linux-acpi,
	linux-kernel, benjamin.tissoires, jbroadus, patches

On Mon, May 27, 2019 at 04:19:29PM +0100, Charles Keepax wrote:
> In preparation for future refactoring factor out the fetch of the IRQ
> into its own helper function.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
>  
> +static int i2c_acpi_get_irq(struct acpi_device *adev)
> +{
> +	struct list_head resource_list;
> +	int irq = -ENOENT;
> +	int ret;
> +
> +	INIT_LIST_HEAD(&resource_list);
> +
> +	ret = acpi_dev_get_resources(adev, &resource_list,
> +				     i2c_acpi_add_resource, &irq);
> +	if (ret < 0)
> +		return -EINVAL;
> +
> +	acpi_dev_free_resource_list(&resource_list);
> +
> +	return irq;
> +}
> +

Sorry just noticed I forgot to add the kernel doc. Will fix that
up in the next spin, or do an incremental patch.

Thanks,
Charles

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions
  2019-05-27 15:19 ` [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions Charles Keepax
@ 2019-05-28 10:30   ` Mika Westerberg
  2019-05-28 11:13     ` Charles Keepax
  0 siblings, 1 reply; 10+ messages in thread
From: Mika Westerberg @ 2019-05-28 10:30 UTC (permalink / raw)
  To: Charles Keepax
  Cc: wsa, jarkko.nikula, andriy.shevchenko, linux-i2c, linux-acpi,
	linux-kernel, benjamin.tissoires, jbroadus, patches

On Mon, May 27, 2019 at 04:19:28PM +0100, Charles Keepax wrote:
>  static int i2c_acpi_get_info(struct acpi_device *adev,
>  			     struct i2c_board_info *info,
>  			     struct i2c_adapter *adapter,
>  			     acpi_handle *adapter_handle)
>  {
>  	struct list_head resource_list;
> -	struct resource_entry *entry;
>  	struct i2c_acpi_lookup lookup;
> +	int irq = -ENOENT;
>  	int ret;
>  
>  	memset(&lookup, 0, sizeof(lookup));
> @@ -176,16 +187,13 @@ static int i2c_acpi_get_info(struct acpi_device *adev,
>  
>  	/* Then fill IRQ number if any */
>  	INIT_LIST_HEAD(&resource_list);
> -	ret = acpi_dev_get_resources(adev, &resource_list, NULL, NULL);
> +	ret = acpi_dev_get_resources(adev, &resource_list,
> +				     i2c_acpi_add_resource, &irq);
>  	if (ret < 0)
>  		return -EINVAL;
>  
> -	resource_list_for_each_entry(entry, &resource_list) {
> -		if (resource_type(entry->res) == IORESOURCE_IRQ) {
> -			info->irq = entry->res->start;
> -			break;
> -		}
> -	}
> +	if (irq >= 0)

Since 0 is not valid IRQ, I think this should be written like:

	if (irg > 0)

> +		info->irq = irq;
>  
>  	acpi_dev_free_resource_list(&resource_list);
>  
> -- 
> 2.11.0

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/6] i2c: acpi: Factor out getting the IRQ from ACPI
  2019-05-27 15:19 ` [PATCH v2 3/6] i2c: acpi: Factor out getting the IRQ from ACPI Charles Keepax
  2019-05-28  8:37   ` Charles Keepax
@ 2019-05-28 10:35   ` Mika Westerberg
  1 sibling, 0 replies; 10+ messages in thread
From: Mika Westerberg @ 2019-05-28 10:35 UTC (permalink / raw)
  To: Charles Keepax
  Cc: wsa, jarkko.nikula, andriy.shevchenko, linux-i2c, linux-acpi,
	linux-kernel, benjamin.tissoires, jbroadus, patches

On Mon, May 27, 2019 at 04:19:29PM +0100, Charles Keepax wrote:
>  static int i2c_acpi_get_info(struct acpi_device *adev,
>  			     struct i2c_board_info *info,
>  			     struct i2c_adapter *adapter,
>  			     acpi_handle *adapter_handle)
>  {
> -	struct list_head resource_list;
>  	struct i2c_acpi_lookup lookup;
> -	int irq = -ENOENT;
>  	int ret;
>  
>  	memset(&lookup, 0, sizeof(lookup));
> @@ -186,16 +202,9 @@ static int i2c_acpi_get_info(struct acpi_device *adev,
>  		*adapter_handle = lookup.adapter_handle;
>  
>  	/* Then fill IRQ number if any */
> -	INIT_LIST_HEAD(&resource_list);
> -	ret = acpi_dev_get_resources(adev, &resource_list,
> -				     i2c_acpi_add_resource, &irq);
> -	if (ret < 0)
> -		return -EINVAL;
> -
> -	if (irq >= 0)
> -		info->irq = irq;
> -
> -	acpi_dev_free_resource_list(&resource_list);
> +	ret = i2c_acpi_get_irq(adev);
> +	if (ret >= 0)

Same comment here regarding irq == 0.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions
  2019-05-28 10:30   ` Mika Westerberg
@ 2019-05-28 11:13     ` Charles Keepax
  0 siblings, 0 replies; 10+ messages in thread
From: Charles Keepax @ 2019-05-28 11:13 UTC (permalink / raw)
  To: Mika Westerberg
  Cc: wsa, jarkko.nikula, andriy.shevchenko, linux-i2c, linux-acpi,
	linux-kernel, benjamin.tissoires, jbroadus, patches

On Tue, May 28, 2019 at 01:30:28PM +0300, Mika Westerberg wrote:
> On Mon, May 27, 2019 at 04:19:28PM +0100, Charles Keepax wrote:
> >  static int i2c_acpi_get_info(struct acpi_device *adev,
> >  			     struct i2c_board_info *info,
> >  			     struct i2c_adapter *adapter,
> >  			     acpi_handle *adapter_handle)
> >  {
> >  	struct list_head resource_list;
> > -	struct resource_entry *entry;
> >  	struct i2c_acpi_lookup lookup;
> > +	int irq = -ENOENT;
> >  	int ret;
> >  
> >  	memset(&lookup, 0, sizeof(lookup));
> > @@ -176,16 +187,13 @@ static int i2c_acpi_get_info(struct acpi_device *adev,
> >  
> >  	/* Then fill IRQ number if any */
> >  	INIT_LIST_HEAD(&resource_list);
> > -	ret = acpi_dev_get_resources(adev, &resource_list, NULL, NULL);
> > +	ret = acpi_dev_get_resources(adev, &resource_list,
> > +				     i2c_acpi_add_resource, &irq);
> >  	if (ret < 0)
> >  		return -EINVAL;
> >  
> > -	resource_list_for_each_entry(entry, &resource_list) {
> > -		if (resource_type(entry->res) == IORESOURCE_IRQ) {
> > -			info->irq = entry->res->start;
> > -			break;
> > -		}
> > -	}
> > +	if (irq >= 0)
> 
> Since 0 is not valid IRQ, I think this should be written like:
> 
> 	if (irg > 0)
> 

Yeah sorry thought IRQs were like GPIOs where 0 is a valid
number, will update the patches.

Thanks,
Charles
> > +		info->irq = irq;
> >  
> >  	acpi_dev_free_resource_list(&resource_list);
> >  
> > -- 
> > 2.11.0

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-05-28 11:14 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-27 15:19 [PATCH v2 1/6] i2c: core: Allow whole core to use i2c_dev_irq_from_resources Charles Keepax
2019-05-27 15:19 ` [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions Charles Keepax
2019-05-28 10:30   ` Mika Westerberg
2019-05-28 11:13     ` Charles Keepax
2019-05-27 15:19 ` [PATCH v2 3/6] i2c: acpi: Factor out getting the IRQ from ACPI Charles Keepax
2019-05-28  8:37   ` Charles Keepax
2019-05-28 10:35   ` Mika Westerberg
2019-05-27 15:19 ` [PATCH v2 4/6] i2c: core: Move ACPI IRQ handling to probe time Charles Keepax
2019-05-27 15:19 ` [PATCH v2 5/6] i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irq Charles Keepax
2019-05-27 15:19 ` [PATCH v2 6/6] i2c: core: Tidy up handling of init_irq Charles Keepax

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).