LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Ruslan Babayev <ruslan@babayev.com>
Cc: wsa@the-dreams.de, linux@armlinux.org.uk, andrew@lunn.ch,
	f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
	xe-linux-external@cisco.com
Subject: Re: [net-next,v3 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle
Date: Tue, 28 May 2019 13:39:36 +0300	[thread overview]
Message-ID: <20190528103936.GD2781@lahna.fi.intel.com> (raw)
In-Reply-To: <20190528032213.19839-2-ruslan@babayev.com>

On Mon, May 27, 2019 at 08:22:12PM -0700, Ruslan Babayev wrote:
> This allows drivers to lookup i2c adapters on ACPI based systems similar to
> of_get_i2c_adapter_by_node() with DT based systems.
> 
> Signed-off-by: Ruslan Babayev <ruslan@babayev.com>
> Cc: xe-linux-external@cisco.com
> ---
>  drivers/i2c/i2c-core-acpi.c | 3 ++-
>  include/linux/i2c.h         | 6 ++++++
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c
> index 272800692088..964687534754 100644
> --- a/drivers/i2c/i2c-core-acpi.c
> +++ b/drivers/i2c/i2c-core-acpi.c
> @@ -337,7 +337,7 @@ static int i2c_acpi_find_match_device(struct device *dev, void *data)
>  	return ACPI_COMPANION(dev) == data;
>  }
>  
> -static struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle)
> +struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle)
>  {
>  	struct device *dev;
>  
> @@ -345,6 +345,7 @@ static struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle)
>  			      i2c_acpi_find_match_adapter);
>  	return dev ? i2c_verify_adapter(dev) : NULL;
>  }
> +EXPORT_SYMBOL_GPL(i2c_acpi_find_adapter_by_handle);
>  
>  static struct i2c_client *i2c_acpi_find_client_by_adev(struct acpi_device *adev)
>  {
> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index 1308126fc384..9808993f5fd5 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -21,6 +21,7 @@
>  #include <linux/rtmutex.h>
>  #include <linux/irqdomain.h>		/* for Host Notify IRQ */
>  #include <linux/of.h>		/* for struct device_node */
> +#include <linux/acpi.h>		/* for acpi_handle */
>  #include <linux/swab.h>		/* for swab16 */
>  #include <uapi/linux/i2c.h>
>  
> @@ -981,6 +982,7 @@ bool i2c_acpi_get_i2c_resource(struct acpi_resource *ares,
>  u32 i2c_acpi_find_bus_speed(struct device *dev);
>  struct i2c_client *i2c_acpi_new_device(struct device *dev, int index,
>  				       struct i2c_board_info *info);
> +struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle);
>  #else
>  static inline bool i2c_acpi_get_i2c_resource(struct acpi_resource *ares,
>  					     struct acpi_resource_i2c_serialbus **i2c)
> @@ -996,6 +998,10 @@ static inline struct i2c_client *i2c_acpi_new_device(struct device *dev,
>  {
>  	return NULL;
>  }
> +static inline struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle h)

You should use the same argument naming as with the non-stubbed one:

static inline struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle)

Anyway looks good to me,

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

  reply	other threads:[~2019-05-28 10:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28  3:22 [net-next,v3 0/2] Enable SFP on ACPI based systems Ruslan Babayev
2019-05-28  3:22 ` [net-next,v3 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle Ruslan Babayev
2019-05-28 10:39   ` Mika Westerberg [this message]
2019-05-28  3:22 ` [net-next,v3 2/2] net: phy: sfp: enable i2c-bus detection on ACPI based systems Ruslan Babayev
2019-05-28 10:42   ` Mika Westerberg
2019-05-28 10:53   ` Russell King - ARM Linux admin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190528103936.GD2781@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=ruslan@babayev.com \
    --cc=wsa@the-dreams.de \
    --cc=xe-linux-external@cisco.com \
    --subject='Re: [net-next,v3 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).