LKML Archive on
help / color / mirror / Atom feed
From: Kalle Valo <>
To: Gen Zhang <>
Subject: Re: [PATCH] wlcore: spi: Fix a memory leaking bug in wl1271_probe()
Date: Tue, 28 May 2019 11:39:23 +0000 (UTC)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20190524030117.GA6024@zhanggen-UX430UQ>

Gen Zhang <> wrote:

> In wl1271_probe(), 'glue->core' is allocated by platform_device_alloc(),
> when this allocation fails, ENOMEM is returned. However, 'pdev_data'
> and 'glue' are allocated by devm_kzalloc() before 'glue->core'. When
> platform_device_alloc() returns NULL, we should also free 'pdev_data'
> and 'glue' before wl1271_probe() ends to prevent leaking memory.
> Similarly, we shoulf free 'pdev_data' when 'glue' is NULL. And we should
> free 'pdev_data' and 'glue' when 'glue->reg' is error and when 'ret' is
> error.
> Further, we should free 'glue->core', 'pdev_data' and 'glue' when this 
> function normally ends to prevent leaking memory.
> Signed-off-by: Gen Zhang <>

Same questions as with similar SDIO patch:

Patch set to Changes Requested.


  reply	other threads:[~2019-05-28 11:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24  3:02 Gen Zhang
2019-05-28 11:39 ` Kalle Valo [this message]
     [not found] ` <>
2019-05-28 12:14   ` Gen Zhang
2019-05-28 12:33     ` Kalle Valo
2019-05-28 12:38       ` Gen Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] wlcore: spi: Fix a memory leaking bug in wl1271_probe()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).