LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: Eric Wheeler <drbd-dev@lists.ewheeler.net>
Cc: drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drbd: fix discard_zeroes_if_aligned regression
Date: Tue, 28 May 2019 15:18:23 +0200 [thread overview]
Message-ID: <20190528131823.GD5803@soda.linbit> (raw)
In-Reply-To: <alpine.LRH.2.11.1905101728280.1835@mx.ewheeler.net>
On Fri, May 10, 2019 at 05:36:32PM +0000, Eric Wheeler wrote:
> Hi Lars,
>
> We just tried 4.19.x and this bugs still exists. We applied the patch
> which was originally submitted to this thread and it still applies cleanly
> and seems to work for our use case. You mentioned that you had some older
> code which zeroed out unaligned discard requests (or perhaps it was for a
> different purpose) that you may be able to use to patch this. Could you
> dig those up and see if we can get this solved?
>
> It would be nice to be able to use drbd with thin backing volumes from the
> vanilla kernel. If this has already been fixed in something newer than
> 4.19, then please point me to the commit.
I think it was merged upstream in 5.0
f31e583aa2c2 drbd: introduce P_ZEROES (REQ_OP_WRITE_ZEROES on the "wire")
--
: Lars Ellenberg
: LINBIT | Keeping the Digital World Running
: DRBD -- Heartbeat -- Corosync -- Pacemaker
: R&D, Integration, Ops, Consulting, Support
DRBD® and LINBIT® are registered trademarks of LINBIT
next prev parent reply other threads:[~2019-05-28 13:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <15124635.GA4107@soda.linbit>
2018-01-15 23:00 ` Eric Wheeler
2018-01-16 7:26 ` Christoph Hellwig
2018-01-16 9:49 ` Lars Ellenberg
2019-05-10 17:36 ` Eric Wheeler
2019-05-28 13:18 ` Lars Ellenberg [this message]
2019-06-02 0:28 ` Eric Wheeler
2018-01-17 0:43 ` Eric Wheeler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528131823.GD5803@soda.linbit \
--to=lars.ellenberg@linbit.com \
--cc=drbd-dev@lists.ewheeler.net \
--cc=drbd-dev@lists.linbit.com \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH] drbd: fix discard_zeroes_if_aligned regression' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).