LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH -next] usb: host: ohci-st: Remove set but not used variable 'ohci'
@ 2019-05-28 13:38 YueHaibing
  2019-06-03  8:53 ` Patrice CHOTARD
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-05-28 13:38 UTC (permalink / raw)
  To: patrice.chotard, stern, gregkh
  Cc: linux-kernel, linux-usb, linux-arm-kernel, YueHaibing

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/usb/host/ohci-st.c: In function st_ohci_platform_probe:
drivers/usb/host/ohci-st.c:135:19: warning: variable ohci set but not used [-Wunused-but-set-variable]

It's never used, so can be removed.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/usb/host/ohci-st.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/host/ohci-st.c b/drivers/usb/host/ohci-st.c
index 992807c9850a..638a92bd2cdc 100644
--- a/drivers/usb/host/ohci-st.c
+++ b/drivers/usb/host/ohci-st.c
@@ -132,7 +132,6 @@ static int st_ohci_platform_probe(struct platform_device *dev)
 	struct resource *res_mem;
 	struct usb_ohci_pdata *pdata = &ohci_platform_defaults;
 	struct st_ohci_platform_priv *priv;
-	struct ohci_hcd *ohci;
 	int err, irq, clk = 0;
 
 	if (usb_disabled())
@@ -158,7 +157,6 @@ static int st_ohci_platform_probe(struct platform_device *dev)
 	platform_set_drvdata(dev, hcd);
 	dev->dev.platform_data = pdata;
 	priv = hcd_to_ohci_priv(hcd);
-	ohci = hcd_to_ohci(hcd);
 
 	priv->phy = devm_phy_get(&dev->dev, "usb");
 	if (IS_ERR(priv->phy)) {
-- 
2.17.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] usb: host: ohci-st: Remove set but not used variable 'ohci'
  2019-05-28 13:38 [PATCH -next] usb: host: ohci-st: Remove set but not used variable 'ohci' YueHaibing
@ 2019-06-03  8:53 ` Patrice CHOTARD
  0 siblings, 0 replies; 2+ messages in thread
From: Patrice CHOTARD @ 2019-06-03  8:53 UTC (permalink / raw)
  To: YueHaibing, stern, gregkh; +Cc: linux-kernel, linux-usb, linux-arm-kernel

Hi

On 5/28/19 3:38 PM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/usb/host/ohci-st.c: In function st_ohci_platform_probe:
> drivers/usb/host/ohci-st.c:135:19: warning: variable ohci set but not used [-Wunused-but-set-variable]
> 
> It's never used, so can be removed.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/usb/host/ohci-st.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ohci-st.c b/drivers/usb/host/ohci-st.c
> index 992807c9850a..638a92bd2cdc 100644
> --- a/drivers/usb/host/ohci-st.c
> +++ b/drivers/usb/host/ohci-st.c
> @@ -132,7 +132,6 @@ static int st_ohci_platform_probe(struct platform_device *dev)
>  	struct resource *res_mem;
>  	struct usb_ohci_pdata *pdata = &ohci_platform_defaults;
>  	struct st_ohci_platform_priv *priv;
> -	struct ohci_hcd *ohci;
>  	int err, irq, clk = 0;
>  
>  	if (usb_disabled())
> @@ -158,7 +157,6 @@ static int st_ohci_platform_probe(struct platform_device *dev)
>  	platform_set_drvdata(dev, hcd);
>  	dev->dev.platform_data = pdata;
>  	priv = hcd_to_ohci_priv(hcd);
> -	ohci = hcd_to_ohci(hcd);
>  
>  	priv->phy = devm_phy_get(&dev->dev, "usb");
>  	if (IS_ERR(priv->phy)) {
> 

Acked-by: Patrice Chotard <patrice.chotard@st.com>

Thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-03  8:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-28 13:38 [PATCH -next] usb: host: ohci-st: Remove set but not used variable 'ohci' YueHaibing
2019-06-03  8:53 ` Patrice CHOTARD

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).