LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Sven Van Asbroeck <thesven73@gmail.com>,
	devel@driverdev.osuosl.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO
Date: Tue, 28 May 2019 17:59:56 +0200	[thread overview]
Message-ID: <20190528155956.GA21964@kroah.com> (raw)
In-Reply-To: <3f4c1d4c-656b-8266-38c4-3f7c36a2bd7e@huawei.com>

On Tue, May 28, 2019 at 11:41:57PM +0800, YueHaibing wrote:
> On 2019/5/28 22:35, Sven Van Asbroeck wrote:
> > On Tue, May 28, 2019 at 10:31 AM YueHaibing <yuehaibing@huawei.com> wrote:
> >>
> >> Fix gcc build error while CONFIG_REGMAP_MMIO is not set
> >>
> > 
> > checkpatch.pl errors remain:
> > 
> > $ ./scripts/checkpatch.pl < ~/Downloads/YueHaibing.eml
> > ERROR: DOS line endings
> > #92: FILE: drivers/staging/fieldbus/anybuss/Kconfig:17:
> > +^Iselect REGMAP_MMIO^M$
> 
> This seems text/plain messages have crlf set when saved as .eml file,
> 
> I do check my v2 patch is not crlf ending, but when save as eml file in
> 
> my thunderbird, it becomes crlf ending.

You all need a better email client, mutt handles this just fine, it's
not a problem on my system with my workflow at all :)

So this patch looks fine to me from a formatting point of view.  But
does it do what it says it does, that's up to Sven...

thanks,

greg k-h

  reply	other threads:[~2019-05-28 16:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28 13:32 [PATCH " YueHaibing
2019-05-28 13:41 ` Sven Van Asbroeck
2019-05-28 14:10   ` YueHaibing
2019-05-28 14:29   ` [PATCH v2 " YueHaibing
2019-05-28 14:35     ` Sven Van Asbroeck
2019-05-28 15:41       ` YueHaibing
2019-05-28 15:59         ` Greg KH [this message]
2019-05-28 17:31           ` Sven Van Asbroeck
2019-06-10 12:51             ` Sven Van Asbroeck
2019-06-10 14:09               ` Greg KH
2019-05-28 14:36     ` YueHaibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190528155956.GA21964@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thesven73@gmail.com \
    --cc=yuehaibing@huawei.com \
    --subject='Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).