LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH net-next] net: stmmac: Fix build error without CONFIG_INET
@ 2019-05-28  9:10 YueHaibing
  2019-05-29 21:19 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-05-28  9:10 UTC (permalink / raw)
  To: peppe.cavallaro, alexandre.torgue, joabreu, davem, mcoquelin.stm32
  Cc: linux-kernel, netdev, linux-stm32, linux-arm-kernel, YueHaibing

Fix gcc build error while CONFIG_INET is not set

drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.o: In function `__stmmac_test_loopback':
stmmac_selftests.c:(.text+0x8ec): undefined reference to `ip_send_check'
stmmac_selftests.c:(.text+0xacc): undefined reference to `udp4_hwcsum'

Add CONFIG_INET dependency to fix this.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/stmicro/stmmac/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
index 7791ad5..0b5c8d7 100644
--- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
+++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
@@ -15,6 +15,7 @@ if STMMAC_ETH
 
 config STMMAC_SELFTESTS
 	bool "Support for STMMAC Selftests"
+	depends on INET
 	depends on STMMAC_ETH
 	default n
 	---help---
-- 
2.7.4



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] net: stmmac: Fix build error without CONFIG_INET
  2019-05-28  9:10 [PATCH net-next] net: stmmac: Fix build error without CONFIG_INET YueHaibing
@ 2019-05-29 21:19 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-05-29 21:19 UTC (permalink / raw)
  To: yuehaibing
  Cc: peppe.cavallaro, alexandre.torgue, joabreu, mcoquelin.stm32,
	linux-kernel, netdev, linux-stm32, linux-arm-kernel

From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 28 May 2019 17:10:40 +0800

> Fix gcc build error while CONFIG_INET is not set
> 
> drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.o: In function `__stmmac_test_loopback':
> stmmac_selftests.c:(.text+0x8ec): undefined reference to `ip_send_check'
> stmmac_selftests.c:(.text+0xacc): undefined reference to `udp4_hwcsum'
> 
> Add CONFIG_INET dependency to fix this.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-29 21:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-28  9:10 [PATCH net-next] net: stmmac: Fix build error without CONFIG_INET YueHaibing
2019-05-29 21:19 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).