From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 333E5C28CC0 for ; Wed, 29 May 2019 15:15:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11A8123BE5 for ; Wed, 29 May 2019 15:15:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727112AbfE2PPO (ORCPT ); Wed, 29 May 2019 11:15:14 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:47994 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726012AbfE2PPN (ORCPT ); Wed, 29 May 2019 11:15:13 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D7737341; Wed, 29 May 2019 08:15:12 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E0F0A3F5AF; Wed, 29 May 2019 08:15:09 -0700 (PDT) Date: Wed, 29 May 2019 16:15:07 +0100 From: Mark Rutland To: Marco Elver Cc: peterz@infradead.org, aryabinin@virtuozzo.com, dvyukov@google.com, glider@google.com, andreyknvl@google.com, corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org, arnd@arndb.de, jpoimboe@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com Subject: Re: [PATCH v2 1/3] lib/test_kasan: Add bitops tests Message-ID: <20190529151507.GI31777@lakrids.cambridge.arm.com> References: <20190529141500.193390-1-elver@google.com> <20190529141500.193390-2-elver@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190529141500.193390-2-elver@google.com> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 29, 2019 at 04:14:59PM +0200, Marco Elver wrote: > This adds bitops tests to the test_kasan module. In a follow-up patch, > support for bitops instrumentation will be added. > > Signed-off-by: Marco Elver > --- > Changes in v2: > * Use BITS_PER_LONG. > * Use heap allocated memory for test, as newer compilers (correctly) > warn on OOB stack access. > --- > lib/test_kasan.c | 75 ++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 72 insertions(+), 3 deletions(-) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index 7de2702621dc..6562df0ca30d 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -11,16 +11,17 @@ > > #define pr_fmt(fmt) "kasan test: %s " fmt, __func__ > > +#include > #include > +#include > #include > -#include > #include > +#include > +#include > #include > #include > #include > #include > -#include > -#include > > /* > * Note: test functions are marked noinline so that their names appear in > @@ -623,6 +624,73 @@ static noinline void __init kasan_strings(void) > strnlen(ptr, 1); > } > > +static noinline void __init kasan_bitops(void) > +{ > + long *bits = kmalloc(sizeof(long), GFP_KERNEL | __GFP_ZERO); Trivial nit, but this can/should be: long *bits = kzalloc(sizeof(*bits), GFP_KERNEL); ... which is the usual style for sizeof() to keep the LHS and RHS types the same, and using kzalloc avoids the need to explicitly pass __GFP_ZERO. Otherwise, this looks good to me. > + if (!bits) > + return; > + > + pr_info("within-bounds in set_bit"); > + set_bit(0, bits); > + > + pr_info("within-bounds in set_bit"); > + set_bit(BITS_PER_LONG - 1, bits); > + > + pr_info("out-of-bounds in set_bit\n"); > + set_bit(BITS_PER_LONG, bits); > + > + pr_info("out-of-bounds in __set_bit\n"); > + __set_bit(BITS_PER_LONG, bits); > + > + pr_info("out-of-bounds in clear_bit\n"); > + clear_bit(BITS_PER_LONG, bits); > + > + pr_info("out-of-bounds in __clear_bit\n"); > + __clear_bit(BITS_PER_LONG, bits); > + > + pr_info("out-of-bounds in clear_bit_unlock\n"); > + clear_bit_unlock(BITS_PER_LONG, bits); > + > + pr_info("out-of-bounds in __clear_bit_unlock\n"); > + __clear_bit_unlock(BITS_PER_LONG, bits); > + > + pr_info("out-of-bounds in change_bit\n"); > + change_bit(BITS_PER_LONG, bits); > + > + pr_info("out-of-bounds in __change_bit\n"); > + __change_bit(BITS_PER_LONG, bits); > + > + pr_info("out-of-bounds in test_and_set_bit\n"); > + test_and_set_bit(BITS_PER_LONG, bits); > + > + pr_info("out-of-bounds in __test_and_set_bit\n"); > + __test_and_set_bit(BITS_PER_LONG, bits); > + > + pr_info("out-of-bounds in test_and_set_bit_lock\n"); > + test_and_set_bit_lock(BITS_PER_LONG, bits); > + > + pr_info("out-of-bounds in test_and_clear_bit\n"); > + test_and_clear_bit(BITS_PER_LONG, bits); > + > + pr_info("out-of-bounds in __test_and_clear_bit\n"); > + __test_and_clear_bit(BITS_PER_LONG, bits); > + > + pr_info("out-of-bounds in test_and_change_bit\n"); > + test_and_change_bit(BITS_PER_LONG, bits); > + > + pr_info("out-of-bounds in __test_and_change_bit\n"); > + __test_and_change_bit(BITS_PER_LONG, bits); > + > + pr_info("out-of-bounds in test_bit\n"); > + (void)test_bit(BITS_PER_LONG, bits); > + > +#if defined(clear_bit_unlock_is_negative_byte) > + pr_info("out-of-bounds in clear_bit_unlock_is_negative_byte\n"); > + clear_bit_unlock_is_negative_byte(BITS_PER_LONG, bits); > +#endif > + kfree(bits); > +} > + > static int __init kmalloc_tests_init(void) > { > /* > @@ -664,6 +732,7 @@ static int __init kmalloc_tests_init(void) > kasan_memchr(); > kasan_memcmp(); > kasan_strings(); > + kasan_bitops(); > > kasan_restore_multi_shot(multishot); > > -- > 2.22.0.rc1.257.g3120a18244-goog >