LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: hch@lst.de, robin.murphy@arm.com, m.szyprowski@samsung.com,
	vdumpa@nvidia.com, linux@armlinux.org.uk,
	catalin.marinas@arm.com, will.deacon@arm.com, chris@zankel.net,
	jcmvbkbc@gmail.com, joro@8bytes.org, dwmw2@infradead.org,
	tony@atomide.com, akpm@linux-foundation.org,
	sfr@canb.auug.org.au, treding@nvidia.com, keescook@chromium.org,
	iamjoonsoo.kim@lge.com, wsa+renesas@sang-engineering.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-xtensa@linux-xtensa.org,
	iommu@lists.linux-foundation.org, dann.frazier@canonical.com,
	clang-built-linux@googlegroups.com
Subject: Re: [PATCH v3 1/2] dma-contiguous: Abstract dma_{alloc,free}_contiguous()
Date: Wed, 29 May 2019 15:48:07 -0700	[thread overview]
Message-ID: <20190529224806.GA3270@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <20190529183546.GA12747@archlinux-epyc>

Hi Nathan,

On Wed, May 29, 2019 at 11:35:46AM -0700, Nathan Chancellor wrote:
> This commit is causing boot failures in QEMU on x86_64 defconfig:
> 
> https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/203825363
> 
> Attached is a bisect log and a boot log with GCC (just to show it is not
> a compiler thing).
> 
> My QEMU command line is:
> 
> qemu-system-x86_64 -m 512m \
>                    -drive file=images/x86_64/rootfs.ext4,format=raw,if=ide \
>                    -append 'console=ttyS0 root=/dev/sda' \
>                    -nographic \
>                    -kernel arch/x86_64/boot/bzImage
> 
> and the rootfs is available here:
> 
> https://github.com/ClangBuiltLinux/continuous-integration/raw/master/images/x86_64/rootfs.ext4

Thanks for reporting the bug.

I am able to repro the issue with the given command and rootfs. The
problem is that x86_64 has CONFIG_DMA_CMA=n so the helper function
is blank on x86_64 while dma-direct should be platform independent.

A simple fix is to add alloc_pages_node() for !CONFIG_DMA_CMA. I'll
submit a fix soon -- need to figure out a good way though. It seems
that adding the fallback to the !CONFIG_DMA_CMA version would cause
some recipe errors when building the kernel...

  reply	other threads:[~2019-05-29 22:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24  4:06 [PATCH v3 0/2] Optimize dma_*_from_contiguous calls Nicolin Chen
2019-05-24  4:06 ` [PATCH v3 1/2] dma-contiguous: Abstract dma_{alloc,free}_contiguous() Nicolin Chen
2019-05-29 18:35   ` Nathan Chancellor
2019-05-29 22:48     ` Nicolin Chen [this message]
2019-07-25 16:06   ` Ezequiel Garcia
2019-07-25 16:50     ` Nicolin Chen
2019-07-25 17:31       ` Dafna Hirschfeld
2019-07-25 23:42         ` Nicolin Chen
2019-05-24  4:06 ` [PATCH v3 2/2] dma-contiguous: Use fallback alloc_pages for single pages Nicolin Chen
2019-05-24 16:16   ` Ira Weiny
2019-05-27 10:55     ` Nicolin Chen
2019-05-24 20:03 ` [PATCH v3 0/2] Optimize dma_*_from_contiguous calls dann frazier
2019-05-28  6:04 ` Christoph Hellwig
2019-05-29 23:06   ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190529224806.GA3270@Asurada-Nvidia.nvidia.com \
    --to=nicoleotsuka@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=chris@zankel.net \
    --cc=clang-built-linux@googlegroups.com \
    --cc=dann.frazier@canonical.com \
    --cc=dwmw2@infradead.org \
    --cc=hch@lst.de \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=joro@8bytes.org \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xtensa@linux-xtensa.org \
    --cc=linux@armlinux.org.uk \
    --cc=m.szyprowski@samsung.com \
    --cc=natechancellor@gmail.com \
    --cc=robin.murphy@arm.com \
    --cc=sfr@canb.auug.org.au \
    --cc=tony@atomide.com \
    --cc=treding@nvidia.com \
    --cc=vdumpa@nvidia.com \
    --cc=will.deacon@arm.com \
    --cc=wsa+renesas@sang-engineering.com \
    --subject='Re: [PATCH v3 1/2] dma-contiguous: Abstract dma_{alloc,free}_contiguous()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).