LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH][next] nexthop: remove redundant assignment to err
@ 2019-05-30 15:57 Colin King
2019-05-31 18:37 ` David Ahern
2019-05-31 21:34 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2019-05-30 15:57 UTC (permalink / raw)
To: David S . Miller, Alexey Kuznetsov, Hideaki YOSHIFUJI, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable err is initialized with a value that is never read
and err is reassigned a few statements later. This initialization
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/ipv4/nexthop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c
index 1af8a329dacb..7a5a3d08fec3 100644
--- a/net/ipv4/nexthop.c
+++ b/net/ipv4/nexthop.c
@@ -836,7 +836,7 @@ static int nh_create_ipv6(struct net *net, struct nexthop *nh,
.fc_encap = cfg->nh_encap,
.fc_encap_type = cfg->nh_encap_type,
};
- int err = -EINVAL;
+ int err;
if (!ipv6_addr_any(&cfg->gw.ipv6))
fib6_cfg.fc_flags |= RTF_GATEWAY;
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] nexthop: remove redundant assignment to err
2019-05-30 15:57 [PATCH][next] nexthop: remove redundant assignment to err Colin King
@ 2019-05-31 18:37 ` David Ahern
2019-05-31 21:34 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Ahern @ 2019-05-31 18:37 UTC (permalink / raw)
To: Colin King, David S . Miller, Alexey Kuznetsov,
Hideaki YOSHIFUJI, netdev
Cc: kernel-janitors, linux-kernel
On 5/30/19 9:57 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable err is initialized with a value that is never read
> and err is reassigned a few statements later. This initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/ipv4/nexthop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] nexthop: remove redundant assignment to err
2019-05-30 15:57 [PATCH][next] nexthop: remove redundant assignment to err Colin King
2019-05-31 18:37 ` David Ahern
@ 2019-05-31 21:34 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-05-31 21:34 UTC (permalink / raw)
To: colin.king; +Cc: kuznet, yoshfuji, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 30 May 2019 16:57:54 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable err is initialized with a value that is never read
> and err is reassigned a few statements later. This initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-31 21:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-30 15:57 [PATCH][next] nexthop: remove redundant assignment to err Colin King
2019-05-31 18:37 ` David Ahern
2019-05-31 21:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).