LKML Archive on
help / color / mirror / Atom feed
From: Greg KH <>
To: Matt Sickler <>
Cc: "Simon Sandström" <>,
	"" <>,
	"" <>
Subject: Re: [PATCH 1/4] staging: kpc2000: add spaces around operators in core.c
Date: Thu, 30 May 2019 17:11:56 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, May 30, 2019 at 10:57:09PM +0000, Matt Sickler wrote:
> >From: devel <> On Behalf Of
> >Greg KH
> >On Fri, May 24, 2019 at 01:07:59PM +0200, Simon Sandström wrote:
> >> --- a/drivers/staging/kpc2000/kpc2000/core.c
> >> +++ b/drivers/staging/kpc2000/kpc2000/core.c
> >> @@ -276,18 +276,18 @@ static ssize_t kp2000_cdev_read(struct file *filp,
> >
> >This whole function just needs to be deleted, it's a horrible hack.
> >From the outside, I would definitely agree with you.  On the inside though, we
> rely on this function to quickly identify what kind and version is running on
> a given piece of hardware.  Since that same information is provided by an ioctl,
> I could be convinced to remove this API and write a userspace application that
> uses the ioctl to get the information and pretty prints it.

The ioctl needs to die as well, just use the sysfs entries instead, as
you already have them :)

> I'd be more inclined to agree with the deletion if it means the whole char dev
> interface can be removed from the kpc2000 driver.  That won't be straightforward
> as the ioctl is exposed through this interface.  We could remove the ioctl, but
> we'd need to ensure that all the same information is exposed via sysfs.

I think you are there already, what is missing?

> Our userspace side is all funneled through a single class, so changing
> it to use sysfs wouldn't be too difficult.  I'd support that change if
> someone wants to make it.

I will be glad to do that, it's always nice to delete code :)


greg k-h

  reply	other threads:[~2019-05-31  0:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24 11:07 [PATCH 0/4] Fix whitespace issues in staging/kpc2000 Simon Sandström
2019-05-24 11:07 ` [PATCH 1/4] staging: kpc2000: add spaces around operators in core.c Simon Sandström
2019-05-30 21:05   ` Greg KH
2019-05-30 22:57     ` Matt Sickler
2019-05-31  0:11       ` Greg KH [this message]
2019-05-24 11:08 ` [PATCH 2/4] staging: kpc2000: remove extra blank line " Simon Sandström
2019-05-24 11:08 ` [PATCH 3/4] staging: kpc2000: add missing spaces " Simon Sandström
2019-05-27  7:31   ` Dan Carpenter
2019-05-29 15:54     ` Simon Sandström
2019-05-29 18:15       ` Dan Carpenter
2019-05-24 11:08 ` [PATCH 4/4] staging: kpc2000: remove extra " Simon Sandström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH 1/4] staging: kpc2000: add spaces around operators in core.c' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).