LKML Archive on
help / color / mirror / Atom feed
From: Michal Hocko <>
To: "Huang, Ying" <>
Cc: Andrew Morton <>,,,
	Mike Kravetz <>,
	Andrea Parri <>,
	"Paul E . McKenney" <>,
	Minchan Kim <>, Hugh Dickins <>
Subject: Re: [PATCH -mm] mm, swap: Fix bad swap file entry warning
Date: Fri, 31 May 2019 08:10:47 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri 31-05-19 10:41:02, Huang, Ying wrote:
> From: Huang Ying <>
> Mike reported the following warning messages
>   get_swap_device: Bad swap file entry 1400000000000001
> This is produced by
> - total_swapcache_pages()
>   - get_swap_device()
> Where get_swap_device() is used to check whether the swap device is
> valid and prevent it from being swapoff if so.  But get_swap_device()
> may produce warning message as above for some invalid swap devices.
> This is fixed via calling swp_swap_info() before get_swap_device() to
> filter out the swap devices that may cause warning messages.
> Fixes: 6a946753dbe6 ("mm/swap_state.c: simplify total_swapcache_pages() with get_swap_device()")

I suspect this is referring to a mmotm patch right? There doesn't seem
to be any sha like this in Linus' tree AFAICS. If that is the case then
please note that mmotm patch showing up in linux-next do not have a
stable sha1 and therefore you shouldn't reference them in the commit
message. Instead please refer to the specific mmotm patch file so that
Andrew knows it should be folded in to it.

Michal Hocko

  reply	other threads:[~2019-05-31  6:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31  2:41 Huang, Ying
2019-05-31  6:10 ` Michal Hocko [this message]
2019-06-01  0:14   ` Huang, Ying
2019-05-31 16:59 ` Mike Kravetz
2019-05-31 18:27   ` Dexuan-Linux Cui
2019-05-31 19:16     ` Qian Cai
2019-06-01  4:25 Yuri Norov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH -mm] mm, swap: Fix bad swap file entry warning' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).