LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Petr Mladek <pmladek@suse.com>, Jiri Kosina <jikos@kernel.org>,
	Joe Lawrence <joe.lawrence@redhat.com>,
	Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
	live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable()
Date: Fri, 31 May 2019 14:27:51 -0500	[thread overview]
Message-ID: <20190531192751.uz2egendytx6lqwv@treble> (raw)
In-Reply-To: <alpine.LSU.2.21.1905311418120.742@pobox.suse.cz>

On Fri, May 31, 2019 at 02:25:15PM +0200, Miroslav Benes wrote:
> On Fri, 31 May 2019, Petr Mladek wrote:
> 
> > WARN_ONCE() in the generic save_stack_trace_tsk_reliable() is superfluous.
> > 
> > The information is passed also via the return value. The only current
> > user klp_check_stack() writes its own warning when the reliable stack
> > traces are not supported. Other eventual users might want its own error
> > handling as well.
> > 
> > Signed-off-by: Petr Mladek <pmladek@suse.com>
> > Acked-by: Miroslav Benes <mbenes@suse.cz>
> > Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> > ---
> >  kernel/stacktrace.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/kernel/stacktrace.c b/kernel/stacktrace.c
> > index 5667f1da3ede..8d088408928d 100644
> > --- a/kernel/stacktrace.c
> > +++ b/kernel/stacktrace.c
> > @@ -259,7 +259,6 @@ __weak int
> >  save_stack_trace_tsk_reliable(struct task_struct *tsk,
> >  			      struct stack_trace *trace)
> >  {
> > -	WARN_ONCE(1, KERN_INFO "save_stack_tsk_reliable() not implemented yet.\n");
> >  	return -ENOSYS;
> >  }
> 
> Do we even need the weak function now after Thomas' changes to 
> kernel/stacktrace.c?
> 
> - livepatch is the only user and it calls stack_trace_save_tsk_reliable()
> - x86 defines CONFIG_ARCH_STACKWALK and CONFIG_HAVE_RELIABLE_STACKTRACE, 
>   so it has stack_trace_save_tsk_reliable() implemented and it calls 
>   arch_stack_walk_reliable()
> - powerpc defines CONFIG_HAVE_RELIABLE_STACKTRACE and does not have 
>   CONFIG_ARCH_STACKWALK. It also has stack_trace_save_tsk_reliable() 
>   implemented and it calls save_stack_trace_tsk_reliable(), which is 
>   implemented in arch/powerpc/
> - all other archs do not have CONFIG_HAVE_RELIABLE_STACKTRACE and there is 
>   stack_trace_save_tsk_reliable() returning ENOSYS for these cases in 
>   include/linux/stacktrace.c

I think you're right.  stack_trace_save_tsk_reliable() in stacktrace.h
returning -ENOSYS serves the same purpose as the old weak version of
save_stack_trace_tsk_reliable() which is no longer called directly.

-- 
Josh

  reply	other threads:[~2019-05-31 19:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31  7:41 [PATCH 0/3] livepatch: Clean up of reliable stacktrace warnings Petr Mladek
2019-05-31  7:41 ` [PATCH 1/3] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable() Petr Mladek
2019-05-31 12:25   ` Miroslav Benes
2019-05-31 19:27     ` Josh Poimboeuf [this message]
2019-05-31  7:41 ` [PATCH 2/3] livepatch: Remove duplicate warning about missing reliable stacktrace support Petr Mladek
2019-05-31 12:32   ` Miroslav Benes
2019-05-31 13:19     ` Petr Mladek
2019-05-31 13:29       ` Miroslav Benes
2019-05-31 19:37     ` Josh Poimboeuf
2019-05-31  7:41 ` [PATCH 3/3] livepatch: Use static buffer for debugging messages under rq lock Petr Mladek
2019-05-31 12:37   ` Miroslav Benes
2019-06-03  8:07     ` Petr Mladek
2019-05-31 19:39   ` Josh Poimboeuf
2019-06-06 13:27     ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190531192751.uz2egendytx6lqwv@treble \
    --to=jpoimboe@redhat.com \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.com \
    --subject='Re: [PATCH 1/3] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).