LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] scripts/decode_stacktrace: Accept dash/underscore in modules
@ 2019-05-31 20:59 Evan Green
2019-05-31 21:01 ` Doug Anderson
2019-06-03 7:51 ` Konstantin Khlebnikov
0 siblings, 2 replies; 3+ messages in thread
From: Evan Green @ 2019-05-31 20:59 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Douglas Anderson, Evan Green, Konstantin Khlebnikov,
linux-kernel, Nicolas Boichat, Marc Zyngier, Manuel Traut,
Andrew Morton
The manpage for modprobe mentions that dashes and underscores are
treated interchangeably in module names. The stack trace dumps seem
to print module names with underscores. Use bash to replace _ with
the pattern [-_] so that file names with dashes or underscores can be
found.
For example, this line:
[ 27.919759] hda_widget_sysfs_init+0x2b8/0x3a5 [snd_hda_core]
should find a module named snd-hda-core.ko.
Signed-off-by: Evan Green <evgreen@chromium.org>
---
Note: This should apply atop linux-next.
Thanks to Doug for showing me the bash string substitution magic.
---
scripts/decode_stacktrace.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
index fa704f17275e..13e5fbafdf2f 100755
--- a/scripts/decode_stacktrace.sh
+++ b/scripts/decode_stacktrace.sh
@@ -28,7 +28,7 @@ parse_symbol() {
local objfile=${modcache[$module]}
else
[[ $modpath == "" ]] && return
- local objfile=$(find "$modpath" -name "$module.ko*" -print -quit)
+ local objfile=$(find "$modpath" -name "${module//_/[-_]}.ko*" -print -quit)
[[ $objfile == "" ]] && return
modcache[$module]=$objfile
fi
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scripts/decode_stacktrace: Accept dash/underscore in modules
2019-05-31 20:59 [PATCH] scripts/decode_stacktrace: Accept dash/underscore in modules Evan Green
@ 2019-05-31 21:01 ` Doug Anderson
2019-06-03 7:51 ` Konstantin Khlebnikov
1 sibling, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2019-05-31 21:01 UTC (permalink / raw)
To: Evan Green
Cc: Stephen Rothwell, Konstantin Khlebnikov, LKML, Nicolas Boichat,
Marc Zyngier, Manuel Traut, Andrew Morton
Hi,
On Fri, May 31, 2019 at 1:59 PM Evan Green <evgreen@chromium.org> wrote:
>
> The manpage for modprobe mentions that dashes and underscores are
> treated interchangeably in module names. The stack trace dumps seem
> to print module names with underscores. Use bash to replace _ with
> the pattern [-_] so that file names with dashes or underscores can be
> found.
>
> For example, this line:
> [ 27.919759] hda_widget_sysfs_init+0x2b8/0x3a5 [snd_hda_core]
>
> should find a module named snd-hda-core.ko.
>
> Signed-off-by: Evan Green <evgreen@chromium.org>
> ---
>
> Note: This should apply atop linux-next.
>
> Thanks to Doug for showing me the bash string substitution magic.
>
> ---
> scripts/decode_stacktrace.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
> index fa704f17275e..13e5fbafdf2f 100755
> --- a/scripts/decode_stacktrace.sh
> +++ b/scripts/decode_stacktrace.sh
> @@ -28,7 +28,7 @@ parse_symbol() {
> local objfile=${modcache[$module]}
> else
> [[ $modpath == "" ]] && return
> - local objfile=$(find "$modpath" -name "$module.ko*" -print -quit)
> + local objfile=$(find "$modpath" -name "${module//_/[-_]}.ko*" -print -quit)
> [[ $objfile == "" ]] && return
> modcache[$module]=$objfile
> fi
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scripts/decode_stacktrace: Accept dash/underscore in modules
2019-05-31 20:59 [PATCH] scripts/decode_stacktrace: Accept dash/underscore in modules Evan Green
2019-05-31 21:01 ` Doug Anderson
@ 2019-06-03 7:51 ` Konstantin Khlebnikov
1 sibling, 0 replies; 3+ messages in thread
From: Konstantin Khlebnikov @ 2019-06-03 7:51 UTC (permalink / raw)
To: Evan Green, Stephen Rothwell
Cc: Douglas Anderson, linux-kernel, Nicolas Boichat, Marc Zyngier,
Manuel Traut, Andrew Morton
On 31.05.2019 23:59, Evan Green wrote:
> The manpage for modprobe mentions that dashes and underscores are
> treated interchangeably in module names. The stack trace dumps seem
> to print module names with underscores. Use bash to replace _ with
> the pattern [-_] so that file names with dashes or underscores can be
> found.
>
> For example, this line:
> [ 27.919759] hda_widget_sysfs_init+0x2b8/0x3a5 [snd_hda_core]
>
> should find a module named snd-hda-core.ko.
>
> Signed-off-by: Evan Green <evgreen@chromium.org>
Acked-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> ---
>
> Note: This should apply atop linux-next.
>
> Thanks to Doug for showing me the bash string substitution magic.
>
> ---
> scripts/decode_stacktrace.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
> index fa704f17275e..13e5fbafdf2f 100755
> --- a/scripts/decode_stacktrace.sh
> +++ b/scripts/decode_stacktrace.sh
> @@ -28,7 +28,7 @@ parse_symbol() {
> local objfile=${modcache[$module]}
> else
> [[ $modpath == "" ]] && return
> - local objfile=$(find "$modpath" -name "$module.ko*" -print -quit)
> + local objfile=$(find "$modpath" -name "${module//_/[-_]}.ko*" -print -quit)
> [[ $objfile == "" ]] && return
> modcache[$module]=$objfile
> fi
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-03 7:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-31 20:59 [PATCH] scripts/decode_stacktrace: Accept dash/underscore in modules Evan Green
2019-05-31 21:01 ` Doug Anderson
2019-06-03 7:51 ` Konstantin Khlebnikov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).