LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Hui Wang <hui.wang@canonical.com>
Cc: Xiaoxiao Liu <xiaoxiao.liu-1@cn.alps.com>,
	XiaoXiao Liu <sliuuxiaonxiao@gmail.com>,
	"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
	"peter.hutterer@who-t.net" <peter.hutterer@who-t.net>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Xiaojian Cao <xiaojian.cao@cn.alps.com>,
	"zhangfp1@lenovo.com" <zhangfp1@lenovo.com>,
	Naoki Saito <naoki.saito@alpsalpine.com>,
	Hideo Kawase <hideo.kawase@alpsalpine.com>
Subject: Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue alps cs19 trackstick do not work.
Date: Tue, 11 Jun 2019 09:23:33 +0200	[thread overview]
Message-ID: <20190611072333.nd4va4q2m5epmukc@pali> (raw)
In-Reply-To: <5587ddb9-fb5f-03db-ac11-a696c85c5f2f@canonical.com>

On Tuesday 11 June 2019 12:32:33 Hui Wang wrote:
> On 2019/6/11 上午11:23, Hui Wang wrote:
> > On 2019/6/11 上午11:05, Xiaoxiao Liu wrote:
> > > Hi Pali,
> > > 
> > > I discussed with our FW team about this problem.
> > > We think the V8 method means a touchpad feature  and does not fit
> > > the CS19 trackpoint device.
> > > CS19 TrackPoint needn't  use any Absolute (Raw) mode and is usually
> > > use standard mouse data.
> > > CS19 TrackPoint device is a completely different device with
> > > DualPoint device of Dell/HP.
> > > CS19 TrackPoint device is independent  of Touchpad. (Touchpad is
> > > connecting by I2C, TrackPoint is directly connecting with PS2 port.)
> > > And it has completely another FW.
> > > 
> > > So we think it is better to use the mouse mode for CS19 trackpoint.
> > 
> > Maybe here is some mis-understanding,  the mouse mode here doesn't mean
> > we use psmouse-base.c for cs19 (bare ps/2 mouse), we plan to use
> > trackpoint.c to drive this HW, so this trackpoint has all features a
> > trackpoint should have.
> > 
> And I sent a patch one month ago to let the the trackpoint.c to drive this
> HW: https://www.spinics.net/lists/linux-input/msg61341.html, maybe that
> patch is reference.

So instead of creating blacklist, you should check for TP_VARIANT_ALPS
in alps.c and disallow its usage.

Or maybe better, move trackpoint.c detect code before alsp.c detect code
in psmouse-base. And no changes in alps.c are needed.

> > Regards,
> > 
> > Hui.
> > 
> > > 
> > > Best Regards
> > > Shona
> > > -----邮件原件-----
> > > 发件人: Pali Rohár <pali.rohar@gmail.com>
> > > 发送时间: Monday, June 10, 2019 6:43 PM
> > > 收件人: 劉 曉曉 Xiaoxiao Liu <xiaoxiao.liu-1@cn.alps.com>
> > > 抄送: XiaoXiao Liu <sliuuxiaonxiao@gmail.com>;
> > > dmitry.torokhov@gmail.com; peter.hutterer@who-t.net;
> > > hui.wang@canonical.com; linux-input@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; 曹 曉建 Xiaojian Cao
> > > <xiaojian.cao@cn.alps.com>; zhangfp1@lenovo.com; 斉藤 直樹 Naoki
> > > Saito <naoki.saito@alpsalpine.com>; 川瀬 英夫 Hideo Kawase
> > > <hideo.kawase@alpsalpine.com>
> > > 主题: Re: 答复: 答复: [PATCH] input: alps-fix the issue alps cs19
> > > trackstick do not work.
> > > 
> > > On Monday 10 June 2019 10:03:51 Xiaoxiao Liu wrote:
> > > > Hi Pali,
> > > Hi!
> > > 
> > > > We register our CS19 device as ALPS_ONLY_TRACKSTICK device.
> > > > And let the V8 protocol function support the process of
> > > > ALPS_ONLY_TRACKSTICK device.
> > > > 
> > > > I want to confirm if this solution OK?
> > > Yes, it is fine. Just make sure that touchapad input device is not
> > > registered when this ALPS_ONLY_TRACKSTICK flag is set. So userspace
> > > would not see any fake/unavailable touchpad input device.
> > > 
> > > > Xiaoxiao.Liu
> > > -- 
> > > Pali Rohár
> > > pali.rohar@gmail.com

-- 
Pali Rohár
pali.rohar@gmail.com

  reply	other threads:[~2019-06-11  7:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27  9:44 XiaoXiao Liu
2019-05-27 10:09 ` Pali Rohár
2019-05-28  1:37   ` 答复: " Xiaoxiao Liu
2019-05-28  7:18     ` Pali Rohár
2019-05-28  7:55       ` 答复: " Xiaoxiao Liu
2019-06-10  9:20         ` Xiaoxiao Liu
2019-06-10 10:03           ` Xiaoxiao Liu
2019-06-10 10:43             ` Pali Rohár
2019-06-11  3:05               ` 答复: " Xiaoxiao Liu
2019-06-11  3:23                 ` Hui Wang
2019-06-11  4:32                   ` Hui Wang
2019-06-11  7:23                     ` Pali Rohár [this message]
2019-06-11 17:07                       ` dmitry.torokhov
2019-06-11 17:17                         ` Pali Rohár
2019-06-11 17:32                           ` dmitry.torokhov
2019-06-11 17:38                             ` Pali Rohár
2019-06-11 17:45                               ` dmitry.torokhov
2019-06-17  1:29                               ` 答复: " Xiaoxiao Liu
2019-06-17  7:49                                 ` Pali Rohár
2019-06-18  8:19                                   ` Hui Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190611072333.nd4va4q2m5epmukc@pali \
    --to=pali.rohar@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hideo.kawase@alpsalpine.com \
    --cc=hui.wang@canonical.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naoki.saito@alpsalpine.com \
    --cc=peter.hutterer@who-t.net \
    --cc=sliuuxiaonxiao@gmail.com \
    --cc=xiaojian.cao@cn.alps.com \
    --cc=xiaoxiao.liu-1@cn.alps.com \
    --cc=zhangfp1@lenovo.com \
    --subject='Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue alps cs19 trackstick do not work.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).