From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C85C3C31E45 for ; Thu, 13 Jun 2019 15:09:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9539A21473 for ; Thu, 13 Jun 2019 15:09:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="N7WXUKUI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387711AbfFMPJO (ORCPT ); Thu, 13 Jun 2019 11:09:14 -0400 Received: from mail.skyhub.de ([5.9.137.197]:51706 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732365AbfFMN6d (ORCPT ); Thu, 13 Jun 2019 09:58:33 -0400 Received: from zn.tnic (p200300EC2F06D50021762B7834B766B8.dip0.t-ipconnect.de [IPv6:2003:ec:2f06:d500:2176:2b78:34b7:66b8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 24D161EC0235; Thu, 13 Jun 2019 15:58:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1560434311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Maz4qhAv7CzEe1mERK2XkKpnUOaeRk1rwNJ3zxGQF7I=; b=N7WXUKUIVx0KgZifoTbCmMOS7qM3sPGf7X/zw2AGmVlrIytZIXqgLLPwJHp3m0cCWg4JHi nb53PKNfplx9ToP2i9o/CXOlul4FRsMK1FcqRDiH11isM00a4NU99UpEom0qVpZyXq3aL9 bVXYL6LJaKzUkImk+V2fOArCJJkqHuE= Date: Thu, 13 Jun 2019 15:58:22 +0200 From: Borislav Petkov To: "Ghannam, Yazen" Cc: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/8] EDAC/amd64: Fix number of DIMMs and Chip Select bases/masks on Family17h Message-ID: <20190613135822.GC11598@zn.tnic> References: <20190531234501.32826-1-Yazen.Ghannam@amd.com> <20190531234501.32826-2-Yazen.Ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190531234501.32826-2-Yazen.Ghannam@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 31, 2019 at 11:45:11PM +0000, Ghannam, Yazen wrote: > From: Yazen Ghannam > > ...because AMD Family 17h systems support 2 DIMMs, 4 CS bases, and 2 CS > masks per channel. > > Fixes: 07ed82ef93d6 ("EDAC, amd64: Add Fam17h debug output") > Signed-off-by: Yazen Ghannam > --- > drivers/edac/amd64_edac.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c > index 873437be86d9..9fa2f205f05c 100644 > --- a/drivers/edac/amd64_edac.c > +++ b/drivers/edac/amd64_edac.c > @@ -810,7 +810,7 @@ static void debug_display_dimm_sizes_df(struct amd64_pvt *pvt, u8 ctrl) > > edac_printk(KERN_DEBUG, EDAC_MC, "UMC%d chip selects:\n", ctrl); > > - for (dimm = 0; dimm < 4; dimm++) { > + for (dimm = 0; dimm < 2; dimm++) { > size0 = 0; > cs0 = dimm * 2; > > @@ -942,6 +942,9 @@ static void prep_chip_selects(struct amd64_pvt *pvt) > } else if (pvt->fam == 0x15 && pvt->model == 0x30) { > pvt->csels[0].b_cnt = pvt->csels[1].b_cnt = 4; > pvt->csels[0].m_cnt = pvt->csels[1].m_cnt = 2; > + } else if (pvt->fam >= 0x17) { > + pvt->csels[0].b_cnt = pvt->csels[1].b_cnt = 4; > + pvt->csels[0].m_cnt = pvt->csels[1].m_cnt = 2; I guess it is about time that function gets turned into a switch-case so that the assignment lines do not get duplicated. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.