From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F3BCC31E4E for ; Fri, 14 Jun 2019 22:44:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 42DC52184C for ; Fri, 14 Jun 2019 22:44:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="Y2t0/2mr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726318AbfFNWop (ORCPT ); Fri, 14 Jun 2019 18:44:45 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:43017 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725972AbfFNWop (ORCPT ); Fri, 14 Jun 2019 18:44:45 -0400 Received: by mail-ed1-f66.google.com with SMTP id e3so5591116edr.10 for ; Fri, 14 Jun 2019 15:44:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=h2YsZJ/hpz/dktPd7lJ9/WdLKqP8cOEcDv4gWF/xH7M=; b=Y2t0/2mr8aihOd4yjitVfbPHHMKDHwZD9B6ADKgMF/1yloLEFDKbVCRHfVvaojZBhW X9iJJUE6HuWUrExWayDRtjj+0OY9xfenQmbiD65VYnZPJOUFGdTbi3xuEA07tqg3ncbv ajDe+y4rUbN/CGxSwjohrEi6tZZ+rb0czHc523vfaeBuj/plC1g5QA1E/xwdWDUbC4Hd RklEBmoxmZUKNVrU/LEZqMvsSeLzhM9NmIDLrG2hAKwrIZM2QBMIxo1U2J3pm1Yk5ZQ5 p0ydX7NAPzB8rkCRYyO5wZUKpOOL548iP7pggw258oF7RxeVGfPE4TrDcwadMkWMbA1a BUNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=h2YsZJ/hpz/dktPd7lJ9/WdLKqP8cOEcDv4gWF/xH7M=; b=Pkm+dx8g7Wa9ngB87eo9+b+GjiHV/iqY6pNia0ea9fT4fjT6MICKXPzG9FC7OSncWb anz8wPcgKilrarPEhnFcCt8nI8k+uNCK50Qky7pr3no+mmF9be3BwEA6TqCFdjA73A4q rPehK+ZCfuVGJ/xDaQYYBpdQgm8AL+meGA+hgL4aIbPSaITXvJMbxFh5TuajI+0WanUn d3R16rjrgrJxPZbIEvKgU3ARignmuUed7jEiLkWbAFPjUgBgfNsic7zw0F44OCsBG7S5 9LUUyVKFN+WyuxcGIVo2Pb/FgcWsqv1kH5EmNyDhlkKuL5Bc/O4SysjYltUbyFBOXIwd lGxg== X-Gm-Message-State: APjAAAUcL9G7joonQnh+qGM8uZBauT/7I2KBSo1uId3BKz/XTrWtJrl+ LYqXWom5pnhC7J1X8n0g6Jr7ug== X-Google-Smtp-Source: APXvYqzu11aNlHQ8Ctnz/nojH1rYOSaIZ8gUOC9DmalwLiJMfeuh07K661B4hMO+kTvku1uEQp/sMw== X-Received: by 2002:a17:906:b2c6:: with SMTP id cf6mr66162140ejb.274.1560552283205; Fri, 14 Jun 2019 15:44:43 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id j19sm1212825edr.69.2019.06.14.15.44.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jun 2019 15:44:42 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 42D7D1032BB; Sat, 15 Jun 2019 01:44:43 +0300 (+03) Date: Sat, 15 Jun 2019 01:44:43 +0300 From: "Kirill A. Shutemov" To: Peter Zijlstra Cc: "Kirill A. Shutemov" , Andrew Morton , x86@kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Borislav Petkov , Andy Lutomirski , David Howells , Kees Cook , Dave Hansen , Kai Huang , Jacob Pan , Alison Schofield , linux-mm@kvack.org, kvm@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH, RFC 20/62] mm/page_ext: Export lookup_page_ext() symbol Message-ID: <20190614224443.qmqolaigu5wnf75p@box> References: <20190508144422.13171-1-kirill.shutemov@linux.intel.com> <20190508144422.13171-21-kirill.shutemov@linux.intel.com> <20190614111259.GA3436@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190614111259.GA3436@hirez.programming.kicks-ass.net> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 14, 2019 at 01:12:59PM +0200, Peter Zijlstra wrote: > On Wed, May 08, 2019 at 05:43:40PM +0300, Kirill A. Shutemov wrote: > > page_keyid() is inline funcation that uses lookup_page_ext(). KVM is > > going to use page_keyid() and since KVM can be built as a module > > lookup_page_ext() has to be exported. > > I _really_ hate having to export world+dog for KVM. This one might not > be a real issue, but I itch every time I see an export for KVM these > days. Is there any better way? Do we need to invent EXPORT_SYMBOL_KVM()? :P -- Kirill A. Shutemov