LKML Archive on
help / color / mirror / Atom feed
From: Maximilian Luz <>
To: unlisted-recipients:; (no To-header on input)
	Dmitry Torokhov <>,
	Hans de Goede <>,
	Chen Yu <>, Darren Hart <>,
	Andy Shevchenko <>,
	Benjamin Tissoires <>,
	Maximilian Luz <>
Subject: [PATCH 0/2] Support for buttons on newer MS Surface devices
Date: Thu, 20 Jun 2019 13:50:54 +0200	[thread overview]
Message-ID: <> (raw)

This series adds suport for power and volume buttons on 5th and 6th
generation Microsoft Surface devices. Specifically, it adds support for
the power-button on the Surface Laptop 1 and Laptop 2, as well as
support for power- and (on-device) volume-buttons on the Surface Pro 5
(2017), Pro 6, and Book 2.

These devices use the same MSHW0040 device as on the Surface Pro 4,
however, whereas the Pro 4 uses an ACPI notify handler, the newer
devices use GPIO interrupts to signal these events.

The first patch of this series ensures that the surfacepro3_button
driver, used for MSHW0040 on the Pro 4, does not probe for the newer
devices. The second patch adapts soc_button_array to implement the
actual button support.

I think the changes to soc_button_array in the second patch warrant a
thorough review. I've tried to make things a bit more generic to be able
to integrate arbitrary ACPI GPIO power-/volume-button devices more
easily, I'm not sure if there may be reasons against this.

These patches have also been tested on various Surface devices via the patchset.

Maximilian Luz (2):
  platform: Fix device check for surfacepro3_button
  input: soc_button_array for newer surface devices

 drivers/input/misc/soc_button_array.c     | 134 ++++++++++++++++++++--
 drivers/platform/x86/surfacepro3_button.c |  38 ++++++
 2 files changed, 160 insertions(+), 12 deletions(-)


             reply	other threads:[~2019-06-20 11:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20 11:50 Maximilian Luz [this message]
2019-06-20 11:50 ` [PATCH 1/2] platform: Fix device check for surfacepro3_button Maximilian Luz
2019-06-20 11:50 ` [PATCH 2/2] input: soc_button_array for newer surface devices Maximilian Luz
2019-06-29 14:22   ` Andy Shevchenko
2019-06-29 14:18 ` [PATCH 0/2] Support for buttons on newer MS Surface devices Andy Shevchenko
2019-07-02  0:43   ` Maximilian Luz
2019-07-02  0:37 Maximilian Luz
2019-07-02 17:13 ` Andy Shevchenko
2019-07-02 17:26   ` Maximilian Luz
2019-07-20 15:15 ` Maximilian Luz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 0/2] Support for buttons on newer MS Surface devices' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).