LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ignat Korchagin <ignat@cloudflare.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
	Ivan Babrou <ivan@cloudflare.com>,
	Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Ingo Molnar <mingo@redhat.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	kernel-team <kernel-team@cloudflare.com>
Subject: Re: Linux 4.19 and GCC 9
Date: Tue, 25 Jun 2019 15:50:29 +0800	[thread overview]
Message-ID: <20190625075029.GC19452@kroah.com> (raw)
In-Reply-To: <CALrw=nFcp-+C7ceTFj=R=aG0Z5OpRRVXFoUxUoh=CjcfW79-+g@mail.gmail.com>

On Mon, Jun 24, 2019 at 11:42:34AM +0100, Ignat Korchagin wrote:
> Hi Greg,
> 
> > > For us it seems applying the following 4 mainline patches makes 4.19.x
> > > branch perf compile with GCC-9:
> > >
> > > 4d0f16d059ddb91424480d88473f7392f24aebdc: perf ui helpline: Use
> > > strlcpy() as a shorter form of strncpy() + explicit set nul
> > > b6313899f4ed2e76b8375cf8069556f5b94fbff0: perf help: Remove needless
> > > use of strncpy()
> > > 5192bde7d98c99f2cd80225649e3c2e7493722f7: perf header: Fix unchecked
> > > usage of strncpy()
> > > 97acec7df172cd1e450f81f5e293c0aa145a2797: perf data: Fix 'strncat may
> > > truncate' build failure with recent gcc
> > >
> > > I also checked that 4.19.49 compiles fine with GCC 9, although with a
> > > lot of warnings, mostly from objtool, like "warning: objtool:
> > > sock_register()+0xd: sibling call from callable instruction with
> > > modified stack frame". But it's a start.
> > >
> > > Can we apply the above-mentioned patches, please?
> 
> > I'll look into these after the next round of kernels are released.  I
> 
> Did you by any chance forget to queue these patches? :) (the build is
> still broken for GCC 9.1)

I am on the road and getting to backports for this stuff is on the
bottom of my list until next week at the earliest, sorry.

> > guess I'll go find a distro that has gcc9 on it to actually test
> > things...
> 
> BTW, Arch already has GCC 9.1 package, so no need to compile your own
> anymore for testing:
> https://www.archlinux.org/packages/core/x86_64/gcc/

Yes, my laptop just updated, so I'm building here.  Some gcc9 patches
did just get backported, but not for perf.

thanks,

greg k-h

  reply	other threads:[~2019-06-25  7:52 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CABWYdi06NUOWRLingNuybgZZsTZPjhmsOx-9oCGK94qZGYbzcw@mail.gmail.com>
     [not found] ` <CANiq72kvpiC-i53AXM-YsCUvWroHQemmqxsXjnB330ZEeHahUg@mail.gmail.com>
     [not found]   ` <CABWYdi1zhTTaN-GSgH0DnPfz7p=SRw0wts5QVYYVtfvoiS0qnQ@mail.gmail.com>
2019-05-16 21:20     ` Miguel Ojeda
2019-05-16 21:24       ` Ivan Babrou
2019-05-17  2:03       ` Josh Poimboeuf
2019-05-17  3:14         ` Ivan Babrou
2019-05-17  5:09           ` Greg KH
2019-05-17  7:38             ` Peter Zijlstra
2019-05-17  8:35               ` Miguel Ojeda
2019-05-17  8:51                 ` Greg KH
2019-05-17  9:01                   ` Miguel Ojeda
2019-05-17  9:23                     ` Greg KH
2019-05-17  9:27                       ` Miguel Ojeda
2019-05-17  9:42                         ` Greg KH
2019-05-17 11:52                           ` Greg KH
2019-05-17  9:48                     ` Greg KH
2019-05-17 15:22                     ` Arnaldo Carvalho de Melo
2019-05-17 17:23                       ` Ivan Babrou
2019-05-17 17:37                         ` Arnaldo Carvalho de Melo
2019-06-10  7:21                           ` Ivan Babrou
2019-06-10  7:45                             ` Greg KH
2019-06-10  9:32                               ` Ignat Korchagin
2019-06-10 14:21                                 ` Greg KH
2019-06-10 14:42                                   ` Miguel Ojeda
2019-06-10 14:48                                     ` Greg KH
2019-06-10 15:01                                       ` Ignat Korchagin
2019-06-10 15:04                                       ` Miguel Ojeda
2019-06-10 15:14                             ` Arnaldo Carvalho de Melo
2019-06-10 15:25                               ` Greg KH
2019-06-10 19:14                                 ` Arnaldo Carvalho de Melo
2019-06-24 10:42                                   ` Ignat Korchagin
2019-06-25  7:50                                     ` Greg KH [this message]
2019-06-25  8:08                                       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190625075029.GC19452@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=arnaldo.melo@gmail.com \
    --cc=ignat@cloudflare.com \
    --cc=ivan@cloudflare.com \
    --cc=jolsa@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=kernel-team@cloudflare.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --subject='Re: Linux 4.19 and GCC 9' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).