LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Chester Lin <clin@suse.com>
Cc: "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
	"lenb@kernel.org" <lenb@kernel.org>,
	"robert.moore@intel.com" <robert.moore@intel.com>,
	"erik.schmauss@intel.com" <erik.schmauss@intel.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Joey Lee <JLee@suse.com>, "mhocko@kernel.org" <mhocko@kernel.org>
Subject: Re: [RFC PATCH v2 2/3] ACPI / hotplug: Eject status trace and auto-remove approach
Date: Fri, 3 Jan 2020 09:33:39 +0100	[thread overview]
Message-ID: <20200103083339.GA831558@kroah.com> (raw)
In-Reply-To: <20200103043926.31507-3-clin@suse.com>

On Fri, Jan 03, 2020 at 04:40:13AM +0000, Chester Lin wrote:
> +	eject_node = (struct eject_data *)adev->eject_stat;

No need for this cast.

You do that all over this patch, it can be removed everywhere.

thanks,

greg k-h

  reply	other threads:[~2020-01-03  8:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-03  4:40 [RFC PATCH v2 0/3] ACPI: New eject flow to remove devices cautiously Chester Lin
2020-01-03  4:40 ` [RFC PATCH v2 1/3] ACPI / hotplug: Send change events for offline/online requests when eject is triggered Chester Lin
2020-01-15 10:15   ` Rafael J. Wysocki
2020-03-13  8:21     ` Chester Lin
2020-01-03  4:40 ` [RFC PATCH v2 2/3] ACPI / hotplug: Eject status trace and auto-remove approach Chester Lin
2020-01-03  8:33   ` gregkh [this message]
2020-01-03  4:40 ` [RFC PATCH v2 3/3] ACPI / device_sysfs: Add eject_show and add a cancel option in eject_store Chester Lin
2020-01-03  8:37   ` gregkh
2020-01-03 10:28     ` Chester Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200103083339.GA831558@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=JLee@suse.com \
    --cc=clin@suse.com \
    --cc=erik.schmauss@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).