LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, yoshihiro.shimoda.uh@renesas.com,
	andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
	B38611@freescale.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: phy: Avoid multiple suspends
Date: Sun, 23 Feb 2020 20:59:11 -0800 (PST)	[thread overview]
Message-ID: <20200223.205911.1667092059432885700.davem@davemloft.net> (raw)
In-Reply-To: <20200220233454.31514-1-f.fainelli@gmail.com>

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 20 Feb 2020 15:34:53 -0800

> It is currently possible for a PHY device to be suspended as part of a
> network device driver's suspend call while it is still being attached to
> that net_device, either via phy_suspend() or implicitly via phy_stop().
> 
> Later on, when the MDIO bus controller get suspended, we would attempt
> to suspend again the PHY because it is still attached to a network
> device.
> 
> This is both a waste of time and creates an opportunity for improper
> clock/power management bugs to creep in.
> 
> Fixes: 803dd9c77ac3 ("net: phy: avoid suspending twice a PHY")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied, and queued up for -stable, thanks Florian.

  reply	other threads:[~2020-02-24  4:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20 23:34 Florian Fainelli
2020-02-24  4:59 ` David Miller [this message]
2020-03-10 14:16   ` Geert Uytterhoeven
2020-03-10 16:46     ` Florian Fainelli
2020-03-10 17:34       ` Heiner Kallweit
2020-03-11  9:17       ` Geert Uytterhoeven
2020-03-11 21:22         ` Heiner Kallweit
2020-03-12  8:26           ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200223.205911.1667092059432885700.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=B38611@freescale.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    --subject='Re: [PATCH net] net: phy: Avoid multiple suspends' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).