LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <firstname.lastname@example.org>
To: Arnd Bergmann <email@example.com>
Cc: Scott Branden <firstname.lastname@example.org>,
Luis Chamberlain <email@example.com>,
David Brown <firstname.lastname@example.org>,
Alexander Viro <email@example.com>,
Shuah Khan <firstname.lastname@example.org>,
Bjorn Andersson <email@example.com>,
Shuah Khan <firstname.lastname@example.org>,
"Rafael J . Wysocki" <email@example.com>,
Linux FS-devel Mailing List <firstname.lastname@example.org>,
BCM Kernel Feedback <email@example.com>,
Olof Johansson <firstname.lastname@example.org>,
Andrew Morton <email@example.com>,
Dan Carpenter <firstname.lastname@example.org>,
Colin Ian King <email@example.com>,
Kees Cook <firstname.lastname@example.org>, Takashi Iwai <email@example.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<firstname.lastname@example.org>, Andy Gross <email@example.com>,
Desmond Yan <firstname.lastname@example.org>,
James Hu <email@example.com>
Subject: Re: [PATCH v2 6/7] misc: bcm-vk: add Broadcom VK driver
Date: Sun, 23 Feb 2020 11:00:22 +0100 [thread overview]
Message-ID: <20200223100022.GB120495@kroah.com> (raw)
On Sat, Feb 22, 2020 at 09:02:44AM +0100, Arnd Bergmann wrote:
> On Fri, Feb 21, 2020 at 7:19 PM Scott Branden
> <firstname.lastname@example.org> wrote:
> > On 2020-02-19 11:47 p.m., Greg Kroah-Hartman wrote:
> > > Have you worked with the V4L developers to tie this into the proper
> > > in-kernel apis for this type of functionality?
> > We looked at the V4L model doesn't have any support for anything we are
> > doing in this driver.
> > We also want a driver that doesn't care about video. It could be
> > offloading crypto or other operations.
> > We talked with Olof about all of this previously and he said leave it as
> > a misc driver for now.
> > He was going to discuss at linux plumbers conference that we need some
> > sort of offload engine model that such devices could fit into.
> I see. Have you looked at the "uacce" driver submission? It seems
> theirs is similar enough that there might be some way to share interfaces.
> > > Using a tty driver seems like the totally incorrect way to do this, what
> > > am I missing?
> > tty driver is used to provide console access to the processors running
> > on vk.
> > Data is sent using the bcm_vk_msg interface by read/write operations
> > from user space.
> > VK then gets the messages and DMA's the data to/from host memory when
> > needed to process.
> In turn here, it sounds like you'd want to look at what drivers/misc/mic/
> and the mellanox bluefield drivers are doing. As I understand, they have the
> same requirements for console, but have a nicer approach of providing
> abstract 'virtio' channels between the PCIe endpoint and the host, and
> then run regular virtio based drivers (console, tty, block, filesystem,
> network, ...) along with application specific ones to provide the custom
> high-level protocols. This is also similar to what the drivers/pci/endpoint
> (from the other end) as the drivers/ntb (pci host on both ends) frameworks
> and of course the rpmsg/remoteproc framework do.
> In the long run, I would want much more consolidation between the
> low-level parts of all these frameworks, but moving your high-level
> protocols to the same virtio method would sound like a step in the
> direction towards a generialized framework and easier sharing of
> the abstractions.
I agree, please do not override the generic tty api with something so
hardware-specific like this as it really is not a serial device here.
next prev parent reply other threads:[~2020-02-23 10:00 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 0:48 [PATCH v2 0/7] firmware: add partial read support in request_firmware_into_buf Scott Branden
2020-02-20 0:48 ` [PATCH v2 1/7] fs: introduce kernel_pread_file* support Scott Branden
2020-02-20 0:48 ` [PATCH v2 2/7] firmware: add offset to request_firmware_into_buf Scott Branden
2020-02-20 1:22 ` Luis Chamberlain
2020-02-21 0:14 ` Scott Branden
2020-02-20 0:48 ` [PATCH v2 3/7] test_firmware: add partial read support for request_firmware_into_buf Scott Branden
2020-02-20 8:42 ` Dan Carpenter
2020-02-21 18:30 ` Scott Branden
2020-02-22 1:13 ` Scott Branden
2020-02-24 8:08 ` Dan Carpenter
2020-02-25 19:11 ` Luis Chamberlain
2020-02-20 0:48 ` [PATCH v2 4/7] firmware: test partial file reads of request_firmware_into_buf Scott Branden
2020-02-20 0:48 ` [PATCH v2 5/7] bcm-vk: add bcm_vk UAPI Scott Branden
2020-02-20 7:50 ` Greg Kroah-Hartman
2020-02-21 1:15 ` Scott Branden
2020-02-21 8:34 ` Arnd Bergmann
2020-02-21 18:27 ` Scott Branden
2020-02-21 9:22 ` Greg Kroah-Hartman
2020-02-20 0:48 ` [PATCH v2 6/7] misc: bcm-vk: add Broadcom VK driver Scott Branden
2020-02-20 1:04 ` Randy Dunlap
2020-02-21 0:06 ` Scott Branden
2020-02-21 0:21 ` Randy Dunlap
2020-02-20 7:47 ` Greg Kroah-Hartman
2020-02-21 18:19 ` Scott Branden
2020-02-22 8:02 ` Arnd Bergmann
2020-02-23 10:00 ` Greg Kroah-Hartman [this message]
2020-02-23 23:55 ` Olof Johansson
2020-02-25 22:37 ` Scott Branden
2020-02-20 10:43 ` Dan Carpenter
2020-02-21 18:29 ` Scott Branden
2020-04-17 21:49 ` Scott Branden
2020-04-18 11:45 ` Dan Carpenter
2020-04-18 11:47 ` Dan Carpenter
2020-04-18 17:25 ` Scott Branden
2020-02-22 16:44 ` kbuild test robot
2020-02-22 16:44 ` [RFC PATCH] misc: bcm-vk: image_tab can be static kbuild test robot
2020-02-20 0:48 ` [PATCH v2 7/7] MAINTAINERS: bcm-vk: add maintainer for Broadcom VK Driver Scott Branden
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [PATCH v2 6/7] misc: bcm-vk: add Broadcom VK driver' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).