LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Scott Branden <scott.branden@broadcom.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Brown <david.brown@linaro.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Shuah Khan <shuah@kernel.org>,
bjorn.andersson@linaro.org,
Shuah Khan <skhan@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
Olof Johansson <olof@lixom.net>,
Andrew Morton <akpm@linux-foundation.org>,
Colin Ian King <colin.king@canonical.com>,
Kees Cook <keescook@chromium.org>, Takashi Iwai <tiwai@suse.de>,
linux-kselftest@vger.kernel.org, Andy Gross <agross@kernel.org>
Subject: Re: [PATCH v2 3/7] test_firmware: add partial read support for request_firmware_into_buf
Date: Mon, 24 Feb 2020 11:08:42 +0300 [thread overview]
Message-ID: <20200224080842.GA3308@kadam> (raw)
In-Reply-To: <4a666590-461d-17f9-5580-31a41869383f@broadcom.com>
On Fri, Feb 21, 2020 at 05:13:08PM -0800, Scott Branden wrote:
> > > > +static ssize_t test_dev_config_show_size_t(char *buf, int cfg)
> > > > +{
> > > > + size_t val;
> > > > +
> > > > + mutex_lock(&test_fw_mutex);
> > > > + val = cfg;
> > > > + mutex_unlock(&test_fw_mutex);
> > > Both val and cfg are stack variables so there is no need for locking.
> > > Probably you meant to pass a pointer to cfg?
> I am following the existing code as was done for
> test_dev_config_show_bool(),
> test_dev_config_show_int(),
> test_dev_config_show_u8()
Heh. Yes. Those are buggy as well. Good eyes. Could you send a patch
to fix them?
regards,
dan caprnter
next prev parent reply other threads:[~2020-02-24 11:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 0:48 [PATCH v2 0/7] firmware: add partial read support in request_firmware_into_buf Scott Branden
2020-02-20 0:48 ` [PATCH v2 1/7] fs: introduce kernel_pread_file* support Scott Branden
2020-02-20 0:48 ` [PATCH v2 2/7] firmware: add offset to request_firmware_into_buf Scott Branden
2020-02-20 1:22 ` Luis Chamberlain
2020-02-21 0:14 ` Scott Branden
2020-02-20 0:48 ` [PATCH v2 3/7] test_firmware: add partial read support for request_firmware_into_buf Scott Branden
2020-02-20 8:42 ` Dan Carpenter
2020-02-21 18:30 ` Scott Branden
2020-02-22 1:13 ` Scott Branden
2020-02-24 8:08 ` Dan Carpenter [this message]
2020-02-25 19:11 ` Luis Chamberlain
2020-02-20 0:48 ` [PATCH v2 4/7] firmware: test partial file reads of request_firmware_into_buf Scott Branden
2020-02-20 0:48 ` [PATCH v2 5/7] bcm-vk: add bcm_vk UAPI Scott Branden
2020-02-20 7:50 ` Greg Kroah-Hartman
2020-02-21 1:15 ` Scott Branden
2020-02-21 8:34 ` Arnd Bergmann
2020-02-21 18:27 ` Scott Branden
2020-02-21 9:22 ` Greg Kroah-Hartman
2020-02-20 0:48 ` [PATCH v2 6/7] misc: bcm-vk: add Broadcom VK driver Scott Branden
2020-02-20 1:04 ` Randy Dunlap
2020-02-21 0:06 ` Scott Branden
2020-02-21 0:21 ` Randy Dunlap
2020-02-20 7:47 ` Greg Kroah-Hartman
2020-02-21 18:19 ` Scott Branden
2020-02-22 8:02 ` Arnd Bergmann
2020-02-23 10:00 ` Greg Kroah-Hartman
2020-02-23 23:55 ` Olof Johansson
2020-02-25 22:37 ` Scott Branden
2020-02-20 10:43 ` Dan Carpenter
2020-02-21 18:29 ` Scott Branden
2020-04-17 21:49 ` Scott Branden
2020-04-18 11:45 ` Dan Carpenter
2020-04-18 11:47 ` Dan Carpenter
2020-04-18 17:25 ` Scott Branden
2020-02-22 16:44 ` kbuild test robot
2020-02-22 16:44 ` [RFC PATCH] misc: bcm-vk: image_tab[] can be static kbuild test robot
2020-02-20 0:48 ` [PATCH v2 7/7] MAINTAINERS: bcm-vk: add maintainer for Broadcom VK Driver Scott Branden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224080842.GA3308@kadam \
--to=dan.carpenter@oracle.com \
--cc=agross@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=colin.king@canonical.com \
--cc=david.brown@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=olof@lixom.net \
--cc=rafael@kernel.org \
--cc=scott.branden@broadcom.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tiwai@suse.de \
--cc=viro@zeniv.linux.org.uk \
--subject='Re: [PATCH v2 3/7] test_firmware: add partial read support for request_firmware_into_buf' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).