LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: madalin.bucur@oss.nxp.com
Cc: netdev@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
	shawnguo@kernel.org, leoyang.li@nxp.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	madalin.bucur@nxp.com
Subject: Re: [PATCH net 4/4] dpaa_eth: FMan erratum A050385 workaround
Date: Tue, 03 Mar 2020 15:54:26 -0800 (PST)	[thread overview]
Message-ID: <20200303.155426.707583465205863443.davem@davemloft.net> (raw)
In-Reply-To: <1583250939-24645-5-git-send-email-madalin.bucur@oss.nxp.com>

From: Madalin Bucur <madalin.bucur@oss.nxp.com>
Date: Tue,  3 Mar 2020 17:55:39 +0200

> +#define DPAA_FD_DATA_ALIGNMENT  ((fman_has_errata_a050385()) ? \

You don't need parenthesis around that fman_has_errata_a050385() call.

> +#define dpaa_bp_size(raw_size) ((SKB_WITH_OVERHEAD(raw_size)) & \

Similar again for SKB_WITH_OVERHEAD()

Also, how often does this errata code trigger on effected platforms and
what is the performance degradation from that?  I don't see this analysis
performed anywhere.


  reply	other threads:[~2020-03-03 23:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03 15:55 [PATCH net 0/4] QorIQ DPAA FMan erratum A050385 workaround Madalin Bucur
2020-03-03 15:55 ` [PATCH net 1/4] dt-bindings: net: FMan erratum A050385 Madalin Bucur
2020-03-03 15:55 ` [PATCH net 2/4] arm64: dts: ls1043a: " Madalin Bucur
2020-03-03 15:55 ` [PATCH net 3/4] fsl/fman: detect " Madalin Bucur
2020-03-03 23:52   ` David Miller
2020-03-03 15:55 ` [PATCH net 4/4] dpaa_eth: FMan erratum A050385 workaround Madalin Bucur
2020-03-03 23:54   ` David Miller [this message]
2020-03-04 15:51     ` Madalin Bucur (OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200303.155426.707583465205863443.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madalin.bucur@nxp.com \
    --cc=madalin.bucur@oss.nxp.com \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).