LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Shile Zhang <shile.zhang@linux.alibaba.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Shile Zhang <shile.zhang@linux.alibaba.com>
Subject: [PATCH v2 1/1] mm: fix interrupt disabled long time inside deferred_init_memmap()
Date: Wed, 4 Mar 2020 00:15:51 +0800 [thread overview]
Message-ID: <20200303161551.132263-2-shile.zhang@linux.alibaba.com> (raw)
In-Reply-To: <20200303161551.132263-1-shile.zhang@linux.alibaba.com>
When 'CONFIG_DEFERRED_STRUCT_PAGE_INIT' is set, 'pgdatinit' kthread will
initialise the deferred pages with local interrupts disabled. It is
introduced by commit 3a2d7fa8a3d5 ("mm: disable interrupts while
initializing deferred pages").
The local interrupt will be disabled long time inside
deferred_init_memmap(), depends on memory size.
On machine with NCPUS <= 2, the 'pgdatinit' kthread could be pined on
boot CPU, then the tick timer will stuck long time, which caused the
system wall time inaccuracy.
For example, the dmesg shown that:
[ 0.197975] node 0 initialised, 32170688 pages in 1ms
Obviously, 1ms is unreasonable.
Now, fix it by restore in the pending interrupts inside the while loop.
The reasonable demsg shown likes:
[ 1.069306] node 0 initialised, 32203456 pages in 894ms
Signed-off-by: Shile Zhang <shile.zhang@linux.alibaba.com>
---
mm/page_alloc.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 3c4eb750a199..d3f337f2e089 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1809,8 +1809,12 @@ static int __init deferred_init_memmap(void *data)
* that we can avoid introducing any issues with the buddy
* allocator.
*/
- while (spfn < epfn)
+ while (spfn < epfn) {
nr_pages += deferred_init_maxorder(&i, zone, &spfn, &epfn);
+ /* let in any pending interrupts */
+ local_irq_restore(flags);
+ local_irq_save(flags);
+ }
zone_empty:
pgdat_resize_unlock(pgdat, &flags);
--
2.24.0.rc2
next prev parent reply other threads:[~2020-03-03 16:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 16:15 [PATCH v2 0/1] mm: fix interrupt disabled long time inside Shile Zhang
2020-03-03 16:15 ` Shile Zhang [this message]
2020-03-03 16:52 ` [PATCH v2 1/1] mm: fix interrupt disabled long time inside deferred_init_memmap() Kirill Tkhai
2020-03-04 2:34 ` Shile Zhang
2020-03-04 10:47 ` Kirill Tkhai
2020-03-11 1:44 ` Shile Zhang
2020-03-11 11:42 ` Kirill Tkhai
2020-03-11 12:00 ` Shile Zhang
2020-03-11 12:04 ` Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303161551.132263-2-shile.zhang@linux.alibaba.com \
--to=shile.zhang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--subject='Re: [PATCH v2 1/1] mm: fix interrupt disabled long time inside deferred_init_memmap()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).