LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
	alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
	ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v1 05/14] perf util: Calculate the sum of all streams hits
Date: Tue, 10 Mar 2020 12:14:05 -0300	[thread overview]
Message-ID: <20200310151405.GH15931@kernel.org> (raw)
In-Reply-To: <20200310070245.16314-6-yao.jin@linux.intel.com>

Em Tue, Mar 10, 2020 at 03:02:36PM +0800, Jin Yao escreveu:
> We have used callchain_node->hit to measure the hot level of one
> stream. This patch calculates the sum of hits of all streams.
> 
> Then in next patch, we can use following formula to report hot
> percent for one stream.
> 
> hot percent = callchain_node->hit / sum of all hits
> 
> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
> ---
>  tools/perf/util/callchain.c | 35 +++++++++++++++++++++++++++++++++++
>  tools/perf/util/callchain.h |  1 +
>  2 files changed, 36 insertions(+)
> 
> diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
> index a9dd91268b00..040995405664 100644
> --- a/tools/perf/util/callchain.c
> +++ b/tools/perf/util/callchain.c
> @@ -1685,6 +1685,39 @@ static void update_hot_streams(struct hist_entry *he,
>  	}
>  }
>  
> +static u64 count_callchain_hits(struct hist_entry *he)
> +{
> +	struct rb_root *root = &he->sorted_chain;
> +	struct rb_node *rb_node = rb_first(root);
> +	struct callchain_node *node;
> +	u64 chain_hits = 0;
> +
> +	while (rb_node) {
> +		node = rb_entry(rb_node, struct callchain_node, rb_node);
> +		chain_hits += node->hit;
> +		rb_node = rb_next(rb_node);
> +	}
> +
> +	return chain_hits;
> +}
> +
> +static u64 total_callchain_hits(struct hists *hists)
> +{
> +	struct rb_node *next;
> +	u64 chain_hits = 0;
> +
> +	next = rb_first_cached(&hists->entries);

Try to combine the variable decl line with its initial assignment,
saving one line, i.e.:

+static u64 total_callchain_hits(struct hists *hists)
+{
+	struct rb_node *next = rb_first_cached(&hists->entries);
+	u64 chain_hits = 0;
+
> +	while (next) {
> +		struct hist_entry *he;
> +
> +		he = rb_entry(next, struct hist_entry, rb_node);

Ditto:

+		struct hist_entry *he = rb_entry(next, struct hist_entry, rb_node);

> +		chain_hits += count_callchain_hits(he);
> +		next = rb_next(&he->rb_node);
> +	}
> +
> +	return chain_hits;
> +}
> +
>  static void get_hot_streams(struct hists *hists,
>  			    struct callchain_streams *s)
>  {
> @@ -1698,6 +1731,8 @@ static void get_hot_streams(struct hists *hists,
>  		update_hot_streams(he, s);
>  		next = rb_next(&he->rb_node);
>  	}
> +
> +	s->chain_hits = total_callchain_hits(hists);
>  }
>  
>  struct callchain_streams *callchain_evsel_streams_create(struct evlist *evlist,
> diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
> index c996ab4fb108..3c0e0b45656b 100644
> --- a/tools/perf/util/callchain.h
> +++ b/tools/perf/util/callchain.h
> @@ -173,6 +173,7 @@ struct callchain_streams {
>  	int			nr_streams_max;
>  	int			nr_streams;
>  	int			evsel_idx;
> +	u64			chain_hits;
>  };
>  
>  extern __thread struct callchain_cursor callchain_cursor;
> -- 
> 2.17.1
> 

-- 

- Arnaldo

  reply	other threads:[~2020-03-10 15:14 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10  7:02 [PATCH v1 00/14] perf: Stream comparison Jin Yao
2020-03-10  7:02 ` [PATCH v1 01/14] perf util: Create source line mapping table Jin Yao
2020-03-10 15:08   ` Arnaldo Carvalho de Melo
2020-03-11  5:33     ` Jin, Yao
2020-03-10  7:02 ` [PATCH v1 02/14] perf util: Create streams for managing top N hottest callchains Jin Yao
2020-03-10 15:11   ` Arnaldo Carvalho de Melo
2020-03-11  5:38     ` Jin, Yao
2020-03-10  7:02 ` [PATCH v1 03/14] perf util: Return per-event callchain streams Jin Yao
2020-03-10  7:02 ` [PATCH v1 04/14] perf util: Compare two streams Jin Yao
2020-03-10  7:02 ` [PATCH v1 05/14] perf util: Calculate the sum of all streams hits Jin Yao
2020-03-10 15:14   ` Arnaldo Carvalho de Melo [this message]
2020-03-11  5:44     ` Jin, Yao
2020-03-10  7:02 ` [PATCH v1 06/14] perf util: Report hot streams Jin Yao
2020-03-10  7:02 ` [PATCH v1 07/14] perf diff: Support hot streams comparison Jin Yao
2020-03-10  7:02 ` [PATCH v1 08/14] perf util: Add new block info functions for top N hot blocks comparison Jin Yao
2020-03-10 15:17   ` Arnaldo Carvalho de Melo
2020-03-11  5:47     ` Jin, Yao
2020-03-10  7:02 ` [PATCH v1 09/14] perf util: Add new block info fmts for showing " Jin Yao
2020-03-10  7:02 ` [PATCH v1 10/14] perf util: Enable block source line comparison Jin Yao
2020-03-10  7:02 ` [PATCH v1 11/14] perf diff: support hot blocks comparison Jin Yao
2020-03-10  7:02 ` [PATCH v1 12/14] perf util: Filter out streams by name of changed functions Jin Yao
2020-03-10  7:02 ` [PATCH v1 13/14] perf util: Filter out blocks " Jin Yao
2020-03-10  7:02 ` [PATCH v1 14/14] perf diff: Filter out streams by " Jin Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200310151405.GH15931@kernel.org \
    --to=arnaldo.melo@gmail.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    --cc=yao.jin@linux.intel.com \
    --subject='Re: [PATCH v1 05/14] perf util: Calculate the sum of all streams hits' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).