From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC1E7C18E5A for ; Tue, 10 Mar 2020 16:32:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C648021D7E for ; Tue, 10 Mar 2020 16:32:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583857961; bh=/2iPAON56KiKp4VwG3w8X0u28X5Zi54HWAvPebGYCEc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=l1CJIgPu/uhdCz3sy53Bi6j/KGfjtMuC7P+ROEonvopDfaJoAIql5a6X0yoI0n92w qogLGEClozwlFTLH6orHqoF9bnYU6g/SOSrfkOvk51gSvTONXNWBQxs2QtHliyy++I Db8oM6xC7oRJlhZ9Tw+VFCdTdd1a8Vur+a0/Vk6c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726385AbgCJQcl (ORCPT ); Tue, 10 Mar 2020 12:32:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:46786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727007AbgCJQck (ORCPT ); Tue, 10 Mar 2020 12:32:40 -0400 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 89DBD20848; Tue, 10 Mar 2020 16:32:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583857959; bh=/2iPAON56KiKp4VwG3w8X0u28X5Zi54HWAvPebGYCEc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Rb36kZ2IbhnZyB3p1V4V9GfgNg6bejDxx1CE6wjMZfT6YUH/psCRAb2RrJkPjMgH2 Go0BJJKKyZ5lTjS5QhXBu42kon1eWwEY210z/9Ec+pBRGEjfzfyFtu+GiWsT6Os2CD XunWcletPjGcSg/F8kGYtouEaW6O5e0gn8UznE8s= Date: Tue, 10 Mar 2020 09:32:39 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, chao@kernel.org Subject: Re: [PATCH 2/5] f2fs: force compressed data into warm area Message-ID: <20200310163239.GC240315@google.com> References: <20200310125009.12966-1-yuchao0@huawei.com> <20200310125009.12966-2-yuchao0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310125009.12966-2-yuchao0@huawei.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/10, Chao Yu wrote: > Generally, data shows better continuity in warm data area as its > default allocation direction is right, in order to enhance > sequential read/write performance of compress inode, let's force > compress data into warm area. Not quite sure tho, compressed blocks are logically cold, no? > > Signed-off-by: Chao Yu > --- > fs/f2fs/segment.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index 601d67e72c50..ab1bc750712a 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -3037,9 +3037,10 @@ static int __get_segment_type_6(struct f2fs_io_info *fio) > if (fio->type == DATA) { > struct inode *inode = fio->page->mapping->host; > > - if (is_cold_data(fio->page) || file_is_cold(inode) || > - f2fs_compressed_file(inode)) > + if (is_cold_data(fio->page) || file_is_cold(inode)) > return CURSEG_COLD_DATA; > + if (f2fs_compressed_file(inode)) > + return CURSEG_WARM_DATA; > if (file_is_hot(inode) || > is_inode_flag_set(inode, FI_HOT_DATA) || > f2fs_is_atomic_file(inode) || > -- > 2.18.0.rc1