From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 247D1C10F27 for ; Tue, 10 Mar 2020 17:48:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01E0B2146E for ; Tue, 10 Mar 2020 17:48:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727468AbgCJRsL (ORCPT ); Tue, 10 Mar 2020 13:48:11 -0400 Received: from verein.lst.de ([213.95.11.211]:54323 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbgCJRsJ (ORCPT ); Tue, 10 Mar 2020 13:48:09 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C5C4168BE1; Tue, 10 Mar 2020 18:48:07 +0100 (CET) Date: Tue, 10 Mar 2020 18:48:07 +0100 From: Christoph Hellwig To: Martijn Coenen Cc: axboe@kernel.dk, hch@lst.de, bvanassche@acm.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH] loop: Only change blocksize when needed. Message-ID: <20200310174807.GB8359@lst.de> References: <20200310131230.106427-1-maco@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310131230.106427-1-maco@android.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2020 at 02:12:30PM +0100, Martijn Coenen wrote: > Return early in loop_set_block_size() if the requested block size is > identical to the one we already have; this avoids expensive calls to > freeze the block queue. > > Signed-off-by: Martijn Coenen Looks good, Reviewed-by: Christoph Hellwig