LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: rtl8188eu: Fix block comments to use *
@ 2020-03-11  1:23 Thiago Souza Ferreira
  2020-03-11  7:08 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Thiago Souza Ferreira @ 2020-03-11  1:23 UTC (permalink / raw)
  To: Larry.Finger, gregkh, devel, linux-kernel, lkcamp

Fix "Block comments use * on subsequent lines" warning of
rtw_mlme_ext.c, found by checkpatch.pl script

Signed-off-by: Thiago Souza Ferreira <thsouza2013@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 69 ++++++++++---------
 1 file changed, 35 insertions(+), 34 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
index 36841d20c..02b87a804 100644
--- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
@@ -20,8 +20,8 @@
 static u8 null_addr[ETH_ALEN] = {};
 
 /**************************************************
-OUI definitions for the vendor specific IE
-***************************************************/
+ *OUI definitions for the vendor specific IE
+ ***************************************************/
 const u8 RTW_WPA_OUI[] = {0x00, 0x50, 0xf2, 0x01};
 const u8 WPS_OUI[] = {0x00, 0x50, 0xf2, 0x04};
 static const u8 WMM_OUI[] = {0x00, 0x50, 0xf2, 0x02};
@@ -33,16 +33,16 @@ const u8 WPA_TKIP_CIPHER[4] = {0x00, 0x50, 0xf2, 0x02};
 const u8 RSN_TKIP_CIPHER[4] = {0x00, 0x0f, 0xac, 0x02};
 
 /********************************************************
-MCS rate definitions
-*********************************************************/
+ *MCS rate definitions
+ *********************************************************/
 const u8 MCS_rate_1R[16] = {
 	0xff, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,
 	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
 };
 
 /********************************************************
-ChannelPlan definitions
-*********************************************************/
+ *ChannelPlan definitions
+ *********************************************************/
 static struct rt_channel_plan_2g RTW_ChannelPlan2G[RT_CHANNEL_DOMAIN_2G_MAX] = {
 	{{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13}, 13},		/*  0x00, RT_CHANNEL_DOMAIN_2G_WORLD , Passive scan CH 12, 13 */
 	{{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13}, 13},		/*  0x01, RT_CHANNEL_DOMAIN_2G_ETSI1 */
@@ -173,10 +173,10 @@ struct xmit_frame *alloc_mgtxmitframe(struct xmit_priv *pxmitpriv)
 }
 
 /****************************************************************************
-
-Following are some TX functions for WiFi MLME
-
-*****************************************************************************/
+ *
+ * Following are some TX functions for WiFi MLME
+ *
+ *****************************************************************************/
 
 void update_mgnt_tx_rate(struct adapter *padapter, u8 rate)
 {
@@ -1895,10 +1895,10 @@ unsigned int send_beacon(struct adapter *padapter)
 }
 
 /****************************************************************************
-
-Following are some utility functions for WiFi MLME
-
-*****************************************************************************/
+ *
+ *Following are some utility functions for WiFi MLME
+ *
+ *****************************************************************************/
 
 static void site_survey(struct adapter *padapter)
 {
@@ -2497,10 +2497,11 @@ static void process_80211d(struct adapter *padapter, struct wlan_bssid_ex *bssid
 }
 
 /****************************************************************************
-
-Following are the callback functions for each subtype of the management frames
-
-*****************************************************************************/
+ *
+ * Following are the callback functions for each subtype of the management
+ * frames
+ *
+ *****************************************************************************/
 
 static unsigned int OnProbeReq(struct adapter *padapter,
 			       struct recv_frame *precv_frame)
@@ -3822,10 +3823,10 @@ static unsigned int OnAction(struct adapter *padapter,
 }
 
 /****************************************************************************
-
-Following are the initialization functions for WiFi MLME
-
-*****************************************************************************/
+ *
+ * Following are the initialization functions for WiFi MLME
+ *
+ *****************************************************************************/
 
 static struct mlme_handler mlme_sta_tbl[] = {
 	{WIFI_ASSOCREQ,	  "OnAssocReq",	  &OnAssocReq},
@@ -4151,10 +4152,10 @@ void mgt_dispatcher(struct adapter *padapter, struct recv_frame *precv_frame)
 }
 
 /****************************************************************************
-
-Following are the functions to report events
-
-*****************************************************************************/
+ *
+ * Following are the functions to report events
+ *
+ *****************************************************************************/
 
 void report_survey_event(struct adapter *padapter,
 			 struct recv_frame *precv_frame)
@@ -4405,10 +4406,10 @@ void report_add_sta_event(struct adapter *padapter, unsigned char *MacAddr,
 }
 
 /****************************************************************************
-
-Following are the event callback functions
-
-*****************************************************************************/
+ *
+ * Following are the event callback functions
+ *
+ *****************************************************************************/
 
 /* for sta/adhoc mode */
 void update_sta_info(struct adapter *padapter, struct sta_info *psta)
@@ -4599,10 +4600,10 @@ void mlmeext_sta_del_event_callback(struct adapter *padapter)
 }
 
 /****************************************************************************
-
-Following are the functions for the timer handlers
-
-*****************************************************************************/
+ *
+ * Following are the functions for the timer handlers
+ *
+ *****************************************************************************/
 
 static u8 chk_ap_is_alive(struct adapter *padapter, struct sta_info *psta)
 {
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: rtl8188eu: Fix block comments to use *
  2020-03-11  1:23 [PATCH] staging: rtl8188eu: Fix block comments to use * Thiago Souza Ferreira
@ 2020-03-11  7:08 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-03-11  7:08 UTC (permalink / raw)
  To: Thiago Souza Ferreira; +Cc: Larry.Finger, devel, linux-kernel, lkcamp

On Wed, Mar 11, 2020 at 01:23:32AM +0000, Thiago Souza Ferreira wrote:
> Fix "Block comments use * on subsequent lines" warning of
> rtw_mlme_ext.c, found by checkpatch.pl script
> 
> Signed-off-by: Thiago Souza Ferreira <thsouza2013@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 69 ++++++++++---------
>  1 file changed, 35 insertions(+), 34 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> index 36841d20c..02b87a804 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> @@ -20,8 +20,8 @@
>  static u8 null_addr[ETH_ALEN] = {};
>  
>  /**************************************************
> -OUI definitions for the vendor specific IE
> -***************************************************/
> + *OUI definitions for the vendor specific IE
> + ***************************************************/

Please use a ' ' before the text to make it look "clean".

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-11  7:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11  1:23 [PATCH] staging: rtl8188eu: Fix block comments to use * Thiago Souza Ferreira
2020-03-11  7:08 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).