LKML Archive on
help / color / mirror / Atom feed
From: Ido Schimmel <>
To: Masahiro Yamada <>,,
Cc:, "David S . Miller" <>,
	Stephen Rothwell <>,
	Nicolas Pitre <>,, Jakub Kicinski <>,
Subject: Re: [PATCH] net: drop_monitor: use IS_REACHABLE() to guard net_dm_hw_report()
Date: Wed, 11 Mar 2020 11:31:43 +0200	[thread overview]
Message-ID: <20200311093143.GB279080@splinter> (raw)
In-Reply-To: <>

On Wed, Mar 11, 2020 at 03:29:25PM +0900, Masahiro Yamada wrote:
> In net/Kconfig, NET_DEVLINK implies NET_DROP_MONITOR.
> The original behavior of the 'imply' keyword prevents NET_DROP_MONITOR
> from being 'm' when NET_DEVLINK=y.
> With the planned Kconfig change that relaxes the 'imply', the
> combination of NET_DEVLINK=y and NET_DROP_MONITOR=m would be allowed.
> Use IS_REACHABLE() to avoid the vmlinux link error for this case.
> Reported-by: Stephen Rothwell <>
> Signed-off-by: Masahiro Yamada <>

Thanks, Masahiro.

Neil, Jiri, another option (long term) is to add a raw tracepoint (not
part of ABI) in devlink and have drop monitor register its probe on it
when monitoring.

Two advantages:
1. Consistent with what drop monitor is already doing with kfree_skb()
2. We can remove 'imply NET_DROP_MONITOR' altogether

What do you think?

  reply	other threads:[~2020-03-11  9:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11  6:29 Masahiro Yamada
2020-03-11  9:31 ` Ido Schimmel [this message]
2020-03-11 10:47   ` Neil Horman
2020-03-11 11:28     ` Ido Schimmel
2020-03-11 17:30       ` Neil Horman
2020-03-11 21:26         ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200311093143.GB279080@splinter \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] net: drop_monitor: use IS_REACHABLE() to guard net_dm_hw_report()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).