LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net: drop_monitor: use IS_REACHABLE() to guard net_dm_hw_report()
@ 2020-03-11  6:29 Masahiro Yamada
  2020-03-11  9:31 ` Ido Schimmel
  0 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2020-03-11  6:29 UTC (permalink / raw)
  To: Neil Horman, netdev, David S . Miller
  Cc: Ido Schimmel, Jiri Pirko, Stephen Rothwell, Nicolas Pitre,
	linux-kbuild, Masahiro Yamada, Jakub Kicinski, linux-kernel

In net/Kconfig, NET_DEVLINK implies NET_DROP_MONITOR.

The original behavior of the 'imply' keyword prevents NET_DROP_MONITOR
from being 'm' when NET_DEVLINK=y.

With the planned Kconfig change that relaxes the 'imply', the
combination of NET_DEVLINK=y and NET_DROP_MONITOR=m would be allowed.

Use IS_REACHABLE() to avoid the vmlinux link error for this case.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

This build error was reported in linux-next.
https://lkml.org/lkml/2020/3/10/1936

If this patch is acceptable,
I'd like to get Ack from the maintainers,
and insert this patch before my Kconfig change.


 include/net/drop_monitor.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/drop_monitor.h b/include/net/drop_monitor.h
index 2ab668461463..f68bc373544a 100644
--- a/include/net/drop_monitor.h
+++ b/include/net/drop_monitor.h
@@ -19,7 +19,7 @@ struct net_dm_hw_metadata {
 	struct net_device *input_dev;
 };
 
-#if IS_ENABLED(CONFIG_NET_DROP_MONITOR)
+#if IS_REACHABLE(CONFIG_NET_DROP_MONITOR)
 void net_dm_hw_report(struct sk_buff *skb,
 		      const struct net_dm_hw_metadata *hw_metadata);
 #else
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-03-11 21:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11  6:29 [PATCH] net: drop_monitor: use IS_REACHABLE() to guard net_dm_hw_report() Masahiro Yamada
2020-03-11  9:31 ` Ido Schimmel
2020-03-11 10:47   ` Neil Horman
2020-03-11 11:28     ` Ido Schimmel
2020-03-11 17:30       ` Neil Horman
2020-03-11 21:26         ` Masahiro Yamada

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).