LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ath5k: Add proper dependency for ATH5K_AHB
@ 2020-02-24 18:24 Krzysztof Kozlowski
  2020-03-11 16:52 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-02-24 18:24 UTC (permalink / raw)
  To: Jiri Slaby, Nick Kossifidis, Luis Chamberlain, Kalle Valo,
	David S. Miller, linux-wireless, netdev, linux-kernel
  Cc: Krzysztof Kozlowski

The CONFIG_ATH5K_AHB could be enabled on ATH25 system without enabling
ATH5K driver itself.  This does not make sense because CONFIG_ATH5K_AHB
controls object build within drivers/net/wireless/ath/ath5k/ so enabling
it without CONFIG_ATH5K brings nothing.

Add proper dependency to CONFIG_ATH5K_AHB.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/net/wireless/ath/ath5k/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath5k/Kconfig b/drivers/net/wireless/ath/ath5k/Kconfig
index 802f8f87773a..96010d4b00e7 100644
--- a/drivers/net/wireless/ath/ath5k/Kconfig
+++ b/drivers/net/wireless/ath/ath5k/Kconfig
@@ -54,7 +54,7 @@ config ATH5K_TRACER
 
 config ATH5K_AHB
 	bool "Atheros 5xxx AHB bus support"
-	depends on ATH25
+	depends on ATH25 && ATH5K
 	---help---
 	  This adds support for WiSoC type chipsets of the 5xxx Atheros
 	  family.
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ath5k: Add proper dependency for ATH5K_AHB
  2020-02-24 18:24 [PATCH] ath5k: Add proper dependency for ATH5K_AHB Krzysztof Kozlowski
@ 2020-03-11 16:52 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-03-11 16:52 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jiri Slaby, Nick Kossifidis, Luis Chamberlain, David S. Miller,
	linux-wireless, netdev, linux-kernel, Krzysztof Kozlowski

Krzysztof Kozlowski <krzk@kernel.org> wrote:

> The CONFIG_ATH5K_AHB could be enabled on ATH25 system without enabling
> ATH5K driver itself.  This does not make sense because CONFIG_ATH5K_AHB
> controls object build within drivers/net/wireless/ath/ath5k/ so enabling
> it without CONFIG_ATH5K brings nothing.
> 
> Add proper dependency to CONFIG_ATH5K_AHB.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

c98cdaef931c ath5k: Add proper dependency for ATH5K_AHB

-- 
https://patchwork.kernel.org/patch/11401313/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-11 16:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-24 18:24 [PATCH] ath5k: Add proper dependency for ATH5K_AHB Krzysztof Kozlowski
2020-03-11 16:52 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).