LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ASoC: dt-bindings: google,cros-ec-codec: Fix dtc warnings in example
@ 2020-03-11 20:58 Rob Herring
  2020-03-12  8:55 ` Enric Balletbo i Serra
  2020-03-12 13:46 ` Applied "ASoC: dt-bindings: google, cros-ec-codec: Fix dtc warnings in example" to the asoc tree Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2020-03-11 20:58 UTC (permalink / raw)
  To: Mark Brown
  Cc: devicetree, linux-kernel, Cheng-Yi Chiang,
	Enric Balletbo i Serra, Guenter Roeck, Liam Girdwood,
	Benson Leung, alsa-devel

Extra dtc warnings (roughly what W=1 enables) are now enabled by default
when building the binding examples. These were fixed treewide in
5.6-rc5, but the newly added google,cros-ec-codec schema adds some new
warnings:

Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:17.28-21.11:
Warning (unit_address_vs_reg): /example-0/reserved_mem: node has a reg or ranges property, but no unit name
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:22.19-32.11:
Warning (unit_address_vs_reg): /example-0/cros-ec@0: node has a unit name, but no reg property
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:26.37-31.15:
Warning (unit_address_vs_reg): /example-0/cros-ec@0/ec-codec: node has a reg or ranges property, but no unit name

Fixing the above, then results in:

Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:26.13-23:
Warning (reg_format): /example-0/cros-ec@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:27.37-32.15:
Warning (unit_address_vs_reg): /example-0/cros-ec@0/ec-codec: node has a reg or ranges property, but no unit name

Fixes: eadd54c75f1e ("dt-bindings: Convert the binding file google, cros-ec-codec.txt to yaml format.")
Cc: Cheng-Yi Chiang <cychiang@chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Guenter Roeck <groeck@chromium.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Benson Leung <bleung@chromium.org>
Cc: alsa-devel@alsa-project.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../bindings/sound/google,cros-ec-codec.yaml  | 27 +++++++++++--------
 1 file changed, 16 insertions(+), 11 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
index 94a85d0cbf43..c84e656afb0a 100644
--- a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
+++ b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
@@ -44,19 +44,24 @@ additionalProperties: false
 
 examples:
   - |
-    reserved_mem: reserved_mem {
+    reserved_mem: reserved-mem@52800000 {
         compatible = "shared-dma-pool";
-        reg = <0 0x52800000 0 0x100000>;
+        reg = <0x52800000 0x100000>;
         no-map;
     };
-    cros-ec@0 {
-        compatible = "google,cros-ec-spi";
-        #address-cells = <2>;
-        #size-cells = <1>;
-        cros_ec_codec: ec-codec {
-            compatible = "google,cros-ec-codec";
-            #sound-dai-cells = <1>;
-            reg = <0x0 0x10500000 0x80000>;
-            memory-region = <&reserved_mem>;
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        cros-ec@0 {
+            compatible = "google,cros-ec-spi";
+            #address-cells = <2>;
+            #size-cells = <1>;
+            reg = <0>;
+            cros_ec_codec: ec-codec@10500000 {
+                compatible = "google,cros-ec-codec";
+                #sound-dai-cells = <1>;
+                reg = <0x0 0x10500000 0x80000>;
+                memory-region = <&reserved_mem>;
+            };
         };
     };
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: google,cros-ec-codec: Fix dtc warnings in example
  2020-03-11 20:58 [PATCH] ASoC: dt-bindings: google,cros-ec-codec: Fix dtc warnings in example Rob Herring
@ 2020-03-12  8:55 ` Enric Balletbo i Serra
  2020-03-12 13:46 ` Applied "ASoC: dt-bindings: google, cros-ec-codec: Fix dtc warnings in example" to the asoc tree Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Enric Balletbo i Serra @ 2020-03-12  8:55 UTC (permalink / raw)
  To: Rob Herring, Mark Brown
  Cc: devicetree, linux-kernel, Cheng-Yi Chiang, Guenter Roeck,
	Liam Girdwood, Benson Leung, alsa-devel

Hi Rob,

On 11/3/20 21:58, Rob Herring wrote:
> Extra dtc warnings (roughly what W=1 enables) are now enabled by default
> when building the binding examples. These were fixed treewide in
> 5.6-rc5, but the newly added google,cros-ec-codec schema adds some new
> warnings:
> 
> Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:17.28-21.11:
> Warning (unit_address_vs_reg): /example-0/reserved_mem: node has a reg or ranges property, but no unit name
> Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:22.19-32.11:
> Warning (unit_address_vs_reg): /example-0/cros-ec@0: node has a unit name, but no reg property
> Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:26.37-31.15:
> Warning (unit_address_vs_reg): /example-0/cros-ec@0/ec-codec: node has a reg or ranges property, but no unit name
> 
> Fixing the above, then results in:
> 
> Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:26.13-23:
> Warning (reg_format): /example-0/cros-ec@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
> Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:27.37-32.15:
> Warning (unit_address_vs_reg): /example-0/cros-ec@0/ec-codec: node has a reg or ranges property, but no unit name
> 
> Fixes: eadd54c75f1e ("dt-bindings: Convert the binding file google, cros-ec-codec.txt to yaml format.")
> Cc: Cheng-Yi Chiang <cychiang@chromium.org>
> Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Cc: Guenter Roeck <groeck@chromium.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Benson Leung <bleung@chromium.org>
> Cc: alsa-devel@alsa-project.org
> Signed-off-by: Rob Herring <robh@kernel.org>

Just a minor nit, but the patch looks good to me, so:

Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>


> ---
>  .../bindings/sound/google,cros-ec-codec.yaml  | 27 +++++++++++--------
>  1 file changed, 16 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
> index 94a85d0cbf43..c84e656afb0a 100644
> --- a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
> +++ b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
> @@ -44,19 +44,24 @@ additionalProperties: false
>  
>  examples:
>    - |
> -    reserved_mem: reserved_mem {
> +    reserved_mem: reserved-mem@52800000 {
>          compatible = "shared-dma-pool";
> -        reg = <0 0x52800000 0 0x100000>;
> +        reg = <0x52800000 0x100000>;
>          no-map;
>      };
> -    cros-ec@0 {
> -        compatible = "google,cros-ec-spi";
> -        #address-cells = <2>;
> -        #size-cells = <1>;
> -        cros_ec_codec: ec-codec {
> -            compatible = "google,cros-ec-codec";
> -            #sound-dai-cells = <1>;
> -            reg = <0x0 0x10500000 0x80000>;
> -            memory-region = <&reserved_mem>;
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        cros-ec@0 {
> +            compatible = "google,cros-ec-spi";
> +            #address-cells = <2>;
> +            #size-cells = <1>;
> +            reg = <0>;
> +            cros_ec_codec: ec-codec@10500000 {

nit: shouldn't this be just codec@105500000 to match the class? However I am not
sure codec is a class itself.

> +                compatible = "google,cros-ec-codec";
> +                #sound-dai-cells = <1>;
> +                reg = <0x0 0x10500000 0x80000>;
> +                memory-region = <&reserved_mem>;
> +            };
>          };
>      };
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Applied "ASoC: dt-bindings: google, cros-ec-codec: Fix dtc warnings in example" to the asoc tree
  2020-03-11 20:58 [PATCH] ASoC: dt-bindings: google,cros-ec-codec: Fix dtc warnings in example Rob Herring
  2020-03-12  8:55 ` Enric Balletbo i Serra
@ 2020-03-12 13:46 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2020-03-12 13:46 UTC (permalink / raw)
  To: Rob Herring
  Cc: alsa-devel, Benson Leung, Cheng-Yi Chiang, devicetree,
	Enric Balletbo i Serra, Guenter Roeck, Liam Girdwood,
	linux-kernel, Mark Brown

The patch

   ASoC: dt-bindings: google, cros-ec-codec: Fix dtc warnings in example

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From b239d0c238126f478d2fcd26ad8ffc346547ce67 Mon Sep 17 00:00:00 2001
From: Rob Herring <robh@kernel.org>
Date: Wed, 11 Mar 2020 15:58:41 -0500
Subject: [PATCH] ASoC: dt-bindings: google, cros-ec-codec: Fix dtc warnings in
 example

Extra dtc warnings (roughly what W=1 enables) are now enabled by default
when building the binding examples. These were fixed treewide in
5.6-rc5, but the newly added google,cros-ec-codec schema adds some new
warnings:

Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:17.28-21.11:
Warning (unit_address_vs_reg): /example-0/reserved_mem: node has a reg or ranges property, but no unit name
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:22.19-32.11:
Warning (unit_address_vs_reg): /example-0/cros-ec@0: node has a unit name, but no reg property
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:26.37-31.15:
Warning (unit_address_vs_reg): /example-0/cros-ec@0/ec-codec: node has a reg or ranges property, but no unit name

Fixing the above, then results in:

Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:26.13-23:
Warning (reg_format): /example-0/cros-ec@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:27.37-32.15:
Warning (unit_address_vs_reg): /example-0/cros-ec@0/ec-codec: node has a reg or ranges property, but no unit name

Fixes: eadd54c75f1e ("dt-bindings: Convert the binding file google, cros-ec-codec.txt to yaml format.")
Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: alsa-devel@alsa-project.org
Cc: Benson Leung <bleung@chromium.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Guenter Roeck <groeck@chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Cheng-Yi Chiang <cychiang@chromium.org>
Link: https://lore.kernel.org/r/20200311205841.2710-1-robh@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 .../bindings/sound/google,cros-ec-codec.yaml  | 27 +++++++++++--------
 1 file changed, 16 insertions(+), 11 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
index 94a85d0cbf43..c84e656afb0a 100644
--- a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
+++ b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml
@@ -44,19 +44,24 @@ additionalProperties: false
 
 examples:
   - |
-    reserved_mem: reserved_mem {
+    reserved_mem: reserved-mem@52800000 {
         compatible = "shared-dma-pool";
-        reg = <0 0x52800000 0 0x100000>;
+        reg = <0x52800000 0x100000>;
         no-map;
     };
-    cros-ec@0 {
-        compatible = "google,cros-ec-spi";
-        #address-cells = <2>;
-        #size-cells = <1>;
-        cros_ec_codec: ec-codec {
-            compatible = "google,cros-ec-codec";
-            #sound-dai-cells = <1>;
-            reg = <0x0 0x10500000 0x80000>;
-            memory-region = <&reserved_mem>;
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        cros-ec@0 {
+            compatible = "google,cros-ec-spi";
+            #address-cells = <2>;
+            #size-cells = <1>;
+            reg = <0>;
+            cros_ec_codec: ec-codec@10500000 {
+                compatible = "google,cros-ec-codec";
+                #sound-dai-cells = <1>;
+                reg = <0x0 0x10500000 0x80000>;
+                memory-region = <&reserved_mem>;
+            };
         };
     };
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-12 13:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11 20:58 [PATCH] ASoC: dt-bindings: google,cros-ec-codec: Fix dtc warnings in example Rob Herring
2020-03-12  8:55 ` Enric Balletbo i Serra
2020-03-12 13:46 ` Applied "ASoC: dt-bindings: google, cros-ec-codec: Fix dtc warnings in example" to the asoc tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).