From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E2EEC10DCE for ; Thu, 12 Mar 2020 22:43:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46E4A20716 for ; Thu, 12 Mar 2020 22:43:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726780AbgCLWni (ORCPT ); Thu, 12 Mar 2020 18:43:38 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:36044 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726623AbgCLWnh (ORCPT ); Thu, 12 Mar 2020 18:43:37 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0B05C15842384; Thu, 12 Mar 2020 15:43:36 -0700 (PDT) Date: Thu, 12 Mar 2020 15:43:36 -0700 (PDT) Message-Id: <20200312.154336.1295319497057805539.davem@davemloft.net> To: antoine.tenart@bootlin.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 2/3] net: phy: mscc: split the driver into separate files From: David Miller In-Reply-To: <20200312221033.777437-3-antoine.tenart@bootlin.com> References: <20200312221033.777437-1-antoine.tenart@bootlin.com> <20200312221033.777437-3-antoine.tenart@bootlin.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 12 Mar 2020 15:43:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Antoine Tenart Date: Thu, 12 Mar 2020 23:10:32 +0100 > +inline int vsc8584_macsec_init(struct phy_device *phydev) > +{ > + return 0; > +} > +inline void vsc8584_handle_macsec_interrupt(struct phy_device *phydev) > +{ > +} > +inline void vsc8584_config_macsec_intr(struct phy_device *phydev) > +{ > +} Please use "static inline", as otherwise if this file is included multiple times it will cause the compiler to emit potentially two uninlined copies which will result in a linking error.