LKML Archive on
help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <>
To: Vlastimil Babka <>
Cc: Mike Kravetz <>,
	Andrew Morton <>,,
Subject: Re: [PATCH] mm/hugetlb: remove unnecessary memory fetch in PageHeadHuge()
Date: Thu, 12 Mar 2020 03:41:19 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Mar 11, 2020 at 06:24:40PM +0100, Vlastimil Babka wrote:
> Commit f1e61557f023 ("mm: pack compound_dtor and compound_order into one word
> in struct page") changed compound_dtor from a pointer to an array index in
> order to pack it. To check if page has the hugeltbfs compound_dtor, we can
> just compare the index directly without fetching the function pointer.
> Said commit did that with PageHuge() and we can do the same with PageHeadHuge()
> to make the code a bit smaller and faster.
> Signed-off-by: Vlastimil Babka <>
> Cc: Mike Kravetz <>
> Cc: Kirill A. Shutemov <>

Acked-by: Kirill A. Shutemov <>

We use literaly the same check in the function next to this one --

 Kirill A. Shutemov

  parent reply	other threads:[~2020-03-12  0:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 17:24 Vlastimil Babka
2020-03-11 18:20 ` Mike Kravetz
2020-03-11 19:25 ` David Rientjes
2020-03-12  0:41 ` Kirill A. Shutemov [this message]
2020-03-12  0:42   ` Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] mm/hugetlb: remove unnecessary memory fetch in PageHeadHuge()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).