LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/hugetlb: remove unnecessary memory fetch in PageHeadHuge()
Date: Thu, 12 Mar 2020 03:42:52 +0300	[thread overview]
Message-ID: <20200312004252.efb3bfirdk4ghe4z@black.fi.intel.com> (raw)
In-Reply-To: <20200312004119.b7uew2jriwx2mks5@black.fi.intel.com>

On Thu, Mar 12, 2020 at 03:41:19AM +0300, Kirill A. Shutemov wrote:
> On Wed, Mar 11, 2020 at 06:24:40PM +0100, Vlastimil Babka wrote:
> > Commit f1e61557f023 ("mm: pack compound_dtor and compound_order into one word
> > in struct page") changed compound_dtor from a pointer to an array index in
> > order to pack it. To check if page has the hugeltbfs compound_dtor, we can
> > just compare the index directly without fetching the function pointer.
> > Said commit did that with PageHuge() and we can do the same with PageHeadHuge()
> > to make the code a bit smaller and faster.
> > 
> > Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
> > Cc: Mike Kravetz <mike.kravetz@oracle.com>
> > Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> 
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> 
> We use literaly the same check in the function next to this one --
> PageHuge().

Ugh.. I have to read the commit message, not only the code :P

-- 
 Kirill A. Shutemov

      reply	other threads:[~2020-03-12  0:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 17:24 Vlastimil Babka
2020-03-11 18:20 ` Mike Kravetz
2020-03-11 19:25 ` David Rientjes
2020-03-12  0:41 ` Kirill A. Shutemov
2020-03-12  0:42   ` Kirill A. Shutemov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200312004252.efb3bfirdk4ghe4z@black.fi.intel.com \
    --to=kirill.shutemov@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=vbabka@suse.cz \
    --subject='Re: [PATCH] mm/hugetlb: remove unnecessary memory fetch in PageHeadHuge()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).