LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vinod Koul <email@example.com>
To: Mathias Nyman <firstname.lastname@example.org>
Cc: Christian Lamparter <email@example.com>,
Greg Kroah-Hartman <firstname.lastname@example.org>,
John Stultz <email@example.com>,
Mathias Nyman <firstname.lastname@example.org>,
Bjorn Andersson <email@example.com>,
Yoshihiro Shimoda <firstname.lastname@example.org>,
USB list <email@example.com>,
Linux Kernel Mailing List <firstname.lastname@example.org>,
Alan Stern <email@example.com>,
Heikki Krogerus <firstname.lastname@example.org>
Subject: Re: [PATCH v6 0/5] usb: xhci: Add support for Renesas USB controllers
Date: Thu, 12 Mar 2020 12:26:36 +0530 [thread overview]
Message-ID: <20200312065636.GX4885@vkoul-mobl> (raw)
On 04-02-20, 18:33, Mathias Nyman wrote:
> > >
> > > There are a few other opens regarding this series. Mostly because I'm not (yet)
> > > familiar with all the details, so I'll just just list them here.
> > >
> > > - Is it really enough to add the Renesas driver to Makefile before xhci-pci
> > > driver to make sure it gets matched and probed based on vendor/device id
> > > before xhci-pci driver is matched and probed based on pci class?
> > > What if the Renesas driver is a module and xhci-pci compiled in?
> > The driver loading rules are based on level and makefile order. So
> > renesas will always be loaded before xhci driver. This is required since
> > xhci claims all devices, so we need to make sure it loads before.
> > I think we should make it inbuilt driver rather than a module. xhci
> > driver is only inbuilt.
> > If there is a better way to handle this, am all for it.
> > > - Previously probe didn't return before hcd's were added and everything set up.
> > > Now with request_firmware_nowait() probe returns early successfully, and the
> > > old xhci_pci_probe() which sets up everything is called later by the request
> > > firmware callback. So there could be whole new set of races possible.
> > > For example pci remove can be called mid firmware loading, or when the old
> > > xhci_pci_probe is still setting up things.
> > I think this is a valid concern. Let me think about how to solve this..
> > maybe add a flag in remove which ensure remove doesnt run untill the
> > probe/firmware callback is completed.
> How about initiating async firmware loading before probe is called by using
> DECLARE_PCI_FIXUP_*() hooks?
Well somehow that does not work :(
I tried using DECLARE_PCI_FIXUP_FINAL hook to request the firmware.
Doing so from probe works but from fixup fails always!
So expect this one, I have done the rest of the changes requested, will
send them over soon
next prev parent reply other threads:[~2020-03-12 6:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 8:40 Vinod Koul
2020-01-13 8:40 ` [PATCH v6 1/5] usb: xhci: export few functions Vinod Koul
2020-01-13 8:40 ` [PATCH v6 2/5] usb: renesas-xhci: Add the renesas xhci driver Vinod Koul
2020-01-13 8:40 ` [PATCH v6 3/5] usb: renesas-xhci: Add ROM loader for uPD720201 Vinod Koul
2020-01-13 8:40 ` [PATCH v6 4/5] usb: renesas-xhci: allow multiple firmware versions Vinod Koul
2020-01-13 8:40 ` [PATCH v6 5/5] usb: xhci: provide a debugfs hook for erasing rom Vinod Koul
2020-01-13 20:09 ` [PATCH v6 0/5] usb: xhci: Add support for Renesas USB controllers John Stultz
2020-01-13 20:33 ` Christian Lamparter
2020-01-21 6:46 ` Vinod Koul
2020-01-21 20:26 ` Christian Lamparter
2020-01-24 21:38 ` Christian Lamparter
2020-01-25 5:32 ` Vinod Koul
2020-01-30 17:07 ` Mathias Nyman
2020-01-31 8:40 ` Vinod Koul
2020-02-04 16:33 ` Mathias Nyman
2020-03-12 6:56 ` Vinod Koul [this message]
2020-01-31 15:47 ` Alan Stern
2020-03-10 11:55 ` Vinod Koul
2020-01-26 0:11 ` Andreas Böhler
2020-01-26 13:07 ` Christian Lamparter
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [PATCH v6 0/5] usb: xhci: Add support for Renesas USB controllers' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).