From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CF91C2BB1D for ; Fri, 13 Mar 2020 07:20:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03A81206EB for ; Fri, 13 Mar 2020 07:20:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="pNnl0Z2v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726414AbgCMHUl (ORCPT ); Fri, 13 Mar 2020 03:20:41 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:51998 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726060AbgCMHUk (ORCPT ); Fri, 13 Mar 2020 03:20:40 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02D7JUEO118126; Fri, 13 Mar 2020 07:20:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=89vp+zN42N9ozDuBNs14lAfstpR3evh7sDJu7fH/Y0E=; b=pNnl0Z2voFEtbAqhJf+4WUHBUcN739NV15wKgSMy4svibtpWsExTbW8buCV24nDfHIrD 8+X+POqul71kLJftq/l2IpkatwAtDCu9UkmZgTunKMtxKzMQKyoilEcYK5KzVmp2zanF Shww8rOm8DznVcKgpXxdpTs4z9SLzehTZX1U9suN6fBgzxBbZP4INMNQb/SjQhqp3WBq FpcW5j8kd3o21p1qky48405NxEdv8rfN4+MFU9rvIhWbzl758DV8ft6DCewJ7/MBtb9h +s7CicgyU08Sqo0XVE1+EqvDOxnzFi59O9Zg9tMHRY0SkzeP6bD5C1oSmkwqtE/nguWa aw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2yqtavj8aj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Mar 2020 07:20:29 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02D7KHVg007103; Fri, 13 Mar 2020 07:20:29 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 2yqtaaj6he-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Mar 2020 07:20:29 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02D7KRBD003373; Fri, 13 Mar 2020 07:20:27 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 13 Mar 2020 00:20:26 -0700 Date: Fri, 13 Mar 2020 10:20:21 +0300 From: Dan Carpenter To: Shreeya Patel Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, sbrivio@redhat.com, daniel.baluta@gmail.com, nramas@linux.microsoft.com, hverkuil@xs4all.nl, Larry.Finger@lwfinger.net Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: sdio_halinit: Remove unnecessary conditions Message-ID: <20200313072021.GQ11561@kadam> References: <20200311133811.2246-1-shreeya.patel23498@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311133811.2246-1-shreeya.patel23498@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9558 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003130040 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9558 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 phishscore=0 priorityscore=1501 clxscore=1031 mlxscore=0 adultscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003130040 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2020 at 07:08:11PM +0530, Shreeya Patel wrote: > diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c > index e813382e78a6..643592b0bd38 100644 > --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c > +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c > @@ -551,18 +551,11 @@ static void HalRxAggr8723BSdio(struct adapter *padapter) > > pregistrypriv = &padapter->registrypriv; > > - if (pregistrypriv->wifi_spec) { > - /* 2010.04.27 hpfan */ > - /* Adjust RxAggrTimeout to close to zero disable RxAggr, suggested by designer */ > - /* Timeout value is calculated by 34 / (2^n) */ > - valueDMATimeout = 0x06; > - valueDMAPageCount = 0x06; > - } else { > - /* 20130530, Isaac@SD1 suggest 3 kinds of parameter */ > - /* TX/RX Balance */ > - valueDMATimeout = 0x06; > - valueDMAPageCount = 0x06; > - } > + /* 2010.04.27 hpfan */ Delete these sorts of comments where it's just a name of someone and a time stamp when they wrote it. We don't know how to contact "hpfan" so it's useless. regards, dan carpenter