LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	linux-arm-msm@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Patrick Lai <plai@codeaurora.org>,
	Banajit Goswami <bgoswami@codeaurora.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] ALSA: compress: add wma codec profiles
Date: Fri, 13 Mar 2020 13:23:24 +0530	[thread overview]
Message-ID: <20200313075324.GA4885@vkoul-mobl> (raw)
In-Reply-To: <s5h36ac67nl.wl-tiwai@suse.de>

On 13-03-20, 08:22, Takashi Iwai wrote:
> On Fri, 13 Mar 2020 08:08:39 +0100,
> Vinod Koul wrote:
> > 
> > Some codec profiles were missing for WMA, like WMA9/10 lossless and
> > wma10 pro, so add these profiles
> > 
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> >  include/uapi/sound/compress_params.h | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h
> > index 9c96fb0e4d90..634daa354b58 100644
> > --- a/include/uapi/sound/compress_params.h
> > +++ b/include/uapi/sound/compress_params.h
> > @@ -142,6 +142,9 @@
> >  #define SND_AUDIOPROFILE_WMA8                ((__u32) 0x00000002)
> >  #define SND_AUDIOPROFILE_WMA9                ((__u32) 0x00000004)
> >  #define SND_AUDIOPROFILE_WMA10               ((__u32) 0x00000008)
> > +#define SND_AUDIOPROFILE_WMA9_PRO            ((__u32) 0x00000010)
> > +#define SND_AUDIOPROFILE_WMA9_LOSSLESS       ((__u32) 0x00000011)
> > +#define SND_AUDIOPROFILE_WMA10_LOSSLESS      ((__u32) 0x00000012)
> 
> Are the profiles are bit flags, or they are just enums?
> All other definitions are set as if bit flags.

Yup, sorry missed that, will revise

Thanks
-- 
~Vinod

  reply	other threads:[~2020-03-13  7:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13  7:08 [PATCH 0/9] ALSA: compress: Add wma, alac and ape support Vinod Koul
2020-03-13  7:08 ` [PATCH 1/9] ALSA: compress: add wma codec profiles Vinod Koul
2020-03-13  7:22   ` Takashi Iwai
2020-03-13  7:53     ` Vinod Koul [this message]
2020-03-13  7:08 ` [PATCH 2/9] ALSA: compress: Add wma decoder params Vinod Koul
2020-03-13  7:08 ` [PATCH 3/9] ASoC: qcom: q6asm: pass codec profile to q6asm_open_write Vinod Koul
2020-03-13  7:08 ` [PATCH 4/9] ASoC: qcom: q6asm: add support to wma config Vinod Koul
2020-03-13  7:08 ` [PATCH 5/9] ASoC: qcom: q6asm-dai: add support to wma decoder Vinod Koul
2020-03-13  7:08 ` [PATCH 6/9] ALSA: compress: add alac & ape decoder params Vinod Koul
2020-03-13  7:08 ` [PATCH 7/9] ASoC: qcom: q6asm: add support for alac and ape configs Vinod Koul
2020-03-13  7:08 ` [PATCH 8/9] ASoC: qcom: q6asm-dai: add support for ALAC and APE decoders Vinod Koul
2020-03-13  7:08 ` [PATCH 9/9] ALSA: compress: bump the version Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200313075324.GA4885@vkoul-mobl \
    --to=vkoul@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=plai@codeaurora.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    --subject='Re: [PATCH 1/9] ALSA: compress: add wma codec profiles' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).