From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9334AC4CECE for ; Fri, 13 Mar 2020 07:53:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62E782073E for ; Fri, 13 Mar 2020 07:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584086010; bh=02M3P2Zxs5dVvaBf5blffcFjm6XvmTXJxXybLj3CmlU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qFmw4l8xrfoYdRPYKZmZq2gmPHehaiAE6elDdqbjwKc7/2f6l5a8HT7OVmgw4EEaX 1JzsNDWz03jVvnOOiHPEO+pzFFJYOXksZYD187/d6RWulvddVaFnz0taoHenjTR0SK HU4R/0s19E9DZkQAAIAbPC+JyCMw6PC/ZB12mVDA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726462AbgCMHx3 (ORCPT ); Fri, 13 Mar 2020 03:53:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:37090 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726300AbgCMHx3 (ORCPT ); Fri, 13 Mar 2020 03:53:29 -0400 Received: from localhost (unknown [171.76.107.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B6D3B206FA; Fri, 13 Mar 2020 07:53:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584086008; bh=02M3P2Zxs5dVvaBf5blffcFjm6XvmTXJxXybLj3CmlU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pGZ8jwdBNbCtcx1eXL+kgMOZksL+1pN8+mn/JdKV+ybcymsKKqRJQRCJ73n75yfCm C92zfrJDEOeV6hpOSLDUh1PxEakVm1+JFcaoDpC+a34RHAfCUUkbBLYSVmPfsCjfP+ J36sEn1WBdc7pFXNGB/tSGdYErOaN9z1ycPNlJRw= Date: Fri, 13 Mar 2020 13:23:24 +0530 From: Vinod Koul To: Takashi Iwai Cc: Mark Brown , Takashi Iwai , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Patrick Lai , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Srinivas Kandagatla , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/9] ALSA: compress: add wma codec profiles Message-ID: <20200313075324.GA4885@vkoul-mobl> References: <20200313070847.1464977-1-vkoul@kernel.org> <20200313070847.1464977-2-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13-03-20, 08:22, Takashi Iwai wrote: > On Fri, 13 Mar 2020 08:08:39 +0100, > Vinod Koul wrote: > > > > Some codec profiles were missing for WMA, like WMA9/10 lossless and > > wma10 pro, so add these profiles > > > > Signed-off-by: Vinod Koul > > --- > > include/uapi/sound/compress_params.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h > > index 9c96fb0e4d90..634daa354b58 100644 > > --- a/include/uapi/sound/compress_params.h > > +++ b/include/uapi/sound/compress_params.h > > @@ -142,6 +142,9 @@ > > #define SND_AUDIOPROFILE_WMA8 ((__u32) 0x00000002) > > #define SND_AUDIOPROFILE_WMA9 ((__u32) 0x00000004) > > #define SND_AUDIOPROFILE_WMA10 ((__u32) 0x00000008) > > +#define SND_AUDIOPROFILE_WMA9_PRO ((__u32) 0x00000010) > > +#define SND_AUDIOPROFILE_WMA9_LOSSLESS ((__u32) 0x00000011) > > +#define SND_AUDIOPROFILE_WMA10_LOSSLESS ((__u32) 0x00000012) > > Are the profiles are bit flags, or they are just enums? > All other definitions are set as if bit flags. Yup, sorry missed that, will revise Thanks -- ~Vinod