LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chester Lin <firstname.lastname@example.org>
To: "Rafael J. Wysocki" <email@example.com>
Cc: "firstname.lastname@example.org" <email@example.com>,
Joey Lee <JLee@suse.com>, "firstname.lastname@example.org" <email@example.com>
Subject: Re: [RFC PATCH v2 1/3] ACPI / hotplug: Send change events for offline/online requests when eject is triggered
Date: Fri, 13 Mar 2020 16:21:45 +0800 [thread overview]
Message-ID: <20200313082026.GA4725@linux-8mug> (raw)
On Wed, Jan 15, 2020 at 11:15:08AM +0100, Rafael J. Wysocki wrote:
> On Friday, January 3, 2020 5:40:09 AM CET Chester Lin wrote:
> > Here we change offline/online handling in device hotplug by sending change
> > events to userland as notification so that userland can have control and
> > determine when will be a good time to put them offline/online based on
> > current workload. In this approach the real offline/online opertions are
> > handed over to userland so that userland can have more time to prepare
> > before any device change actually happens.
> > All child devices under the ejection target are traversed and notified
> > hierarchically based on ACPI namespace in ascending order when an eject
> > event happens.
> > Signed-off-by: Chester Lin <firstname.lastname@example.org>
> So you replace the old flow with the new one and make the new one mandatory AFAICS.
> Thus if anyone has relied on the old flow, they now need to switch over.
> This is unfriendly and generally unwelcome, so please avoid making changes like
Thank you for the reminder.
> Instead, I would consider adding a device attribute to allow user space to
> opt in for getting offline notifications for specific individual devices (by
> setting that attribute user space would tell the kernel that it wants to
> get offline notifications for the device in question and it would take
> care of offlining it as needed).
Thanks for your advice. If no one is working on this device attribute [please free
feel to correct me if I'm wrong], I am willing to implement it and will send a new
RFC patch for code review.
next prev parent reply other threads:[~2020-03-13 8:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 4:40 [RFC PATCH v2 0/3] ACPI: New eject flow to remove devices cautiously Chester Lin
2020-01-03 4:40 ` [RFC PATCH v2 1/3] ACPI / hotplug: Send change events for offline/online requests when eject is triggered Chester Lin
2020-01-15 10:15 ` Rafael J. Wysocki
2020-03-13 8:21 ` Chester Lin [this message]
2020-01-03 4:40 ` [RFC PATCH v2 2/3] ACPI / hotplug: Eject status trace and auto-remove approach Chester Lin
2020-01-03 8:33 ` gregkh
2020-01-03 4:40 ` [RFC PATCH v2 3/3] ACPI / device_sysfs: Add eject_show and add a cancel option in eject_store Chester Lin
2020-01-03 8:37 ` gregkh
2020-01-03 10:28 ` Chester Lin
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [RFC PATCH v2 1/3] ACPI / hotplug: Send change events for offline/online requests when eject is triggered' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).