LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* linux-next: build warning after merge of the amdgpu tree
@ 2020-03-13 9:57 Stephen Rothwell
2020-03-13 12:57 ` [PATCH] drm/amd/powerplay: Move fallthrough; into containing #ifdef/#endif Joe Perches
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2020-03-13 9:57 UTC (permalink / raw)
To: Alex Deucher
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Joe Perches
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) produced this warning:
In file included from include/linux/compiler_types.h:59,
from <command-line>:
drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c: In function 'smu7_request_link_speed_change_before_state_change':
include/linux/compiler_attributes.h:200:41: warning: statement will never be executed [-Wswitch-unreachable]
200 | # define fallthrough __attribute__((__fallthrough__))
| ^~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:3706:4: note: in expansion of macro 'fallthrough'
3706 | fallthrough;
| ^~~~~~~~~~~
Introduced by commit
e86efa063cd1 ("AMD POWERPLAY: Use fallthrough;")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* [PATCH] drm/amd/powerplay: Move fallthrough; into containing #ifdef/#endif
2020-03-13 9:57 linux-next: build warning after merge of the amdgpu tree Stephen Rothwell
@ 2020-03-13 12:57 ` Joe Perches
2020-03-13 14:22 ` Alex Deucher
0 siblings, 1 reply; 68+ messages in thread
From: Joe Perches @ 2020-03-13 12:57 UTC (permalink / raw)
To: Stephen Rothwell, Alex Deucher
Cc: Linux Next Mailing List, Linux Kernel Mailing List
The automated conversion of /* fallthrough */ comments converted
a comment outside of an #ifdef/#endif case block that should be
inside the block.
Move the fallthrough inside the block to silence the warning.
Signed-off-by: Joe Perches <joe@perches.com>
---
On Fri, 2020-03-13 at 20:57 +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the amdgpu tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
>
> In file included from include/linux/compiler_types.h:59,
> from <command-line>:
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c: In function 'smu7_request_link_speed_change_before_state_change':
> include/linux/compiler_attributes.h:200:41: warning: statement will never be executed [-Wswitch-unreachable]
> 200 | # define fallthrough __attribute__((__fallthrough__))
> | ^~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:3706:4: note: in expansion of macro 'fallthrough'
> 3706 | fallthrough;
> | ^~~~~~~~~~~
>
> Introduced by commit
>
> e86efa063cd1 ("AMD POWERPLAY: Use fallthrough;")
This is also one of the #ifdef/#endif pairs
where the fallthrough is outside of the #endif.
https://lore.kernel.org/lkml/cover.1584040050.git.joe@perches.com/
Here is a delta patch for this.
Let me know if another form is needed.
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
index fc5236c..774048 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
@@ -3702,8 +3702,8 @@ static int smu7_request_link_speed_change_before_state_change(
case PP_PCIEGen2:
if (0 == amdgpu_acpi_pcie_performance_request(hwmgr->adev, PCIE_PERF_REQ_GEN2, false))
break;
-#endif
fallthrough;
+#endif
default:
data->force_pcie_gen = smu7_get_current_pcie_speed(hwmgr);
break;
--
2.24.0
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [PATCH] drm/amd/powerplay: Move fallthrough; into containing #ifdef/#endif
2020-03-13 12:57 ` [PATCH] drm/amd/powerplay: Move fallthrough; into containing #ifdef/#endif Joe Perches
@ 2020-03-13 14:22 ` Alex Deucher
0 siblings, 0 replies; 68+ messages in thread
From: Alex Deucher @ 2020-03-13 14:22 UTC (permalink / raw)
To: Joe Perches
Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List
On Fri, Mar 13, 2020 at 8:59 AM Joe Perches <joe@perches.com> wrote:
>
> The automated conversion of /* fallthrough */ comments converted
> a comment outside of an #ifdef/#endif case block that should be
> inside the block.
>
> Move the fallthrough inside the block to silence the warning.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied. Thanks!
Alex
> ---
>
> On Fri, 2020-03-13 at 20:57 +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the amdgpu tree, today's linux-next build (powerpc
> > allyesconfig) produced this warning:
> >
> > In file included from include/linux/compiler_types.h:59,
> > from <command-line>:
> > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c: In function 'smu7_request_link_speed_change_before_state_change':
> > include/linux/compiler_attributes.h:200:41: warning: statement will never be executed [-Wswitch-unreachable]
> > 200 | # define fallthrough __attribute__((__fallthrough__))
> > | ^~~~~~~~~~~~~
> > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:3706:4: note: in expansion of macro 'fallthrough'
> > 3706 | fallthrough;
> > | ^~~~~~~~~~~
> >
> > Introduced by commit
> >
> > e86efa063cd1 ("AMD POWERPLAY: Use fallthrough;")
>
> This is also one of the #ifdef/#endif pairs
> where the fallthrough is outside of the #endif.
>
> https://lore.kernel.org/lkml/cover.1584040050.git.joe@perches.com/
>
> Here is a delta patch for this.
> Let me know if another form is needed.
>
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> index fc5236c..774048 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> @@ -3702,8 +3702,8 @@ static int smu7_request_link_speed_change_before_state_change(
> case PP_PCIEGen2:
> if (0 == amdgpu_acpi_pcie_performance_request(hwmgr->adev, PCIE_PERF_REQ_GEN2, false))
> break;
> -#endif
> fallthrough;
> +#endif
> default:
> data->force_pcie_gen = smu7_get_current_pcie_speed(hwmgr);
> break;
> --
> 2.24.0
>
>
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2023-03-01 0:34 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2023-03-01 0:34 UTC (permalink / raw)
To: Alex Deucher
Cc: Alvin Lee, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/display/dc/dc.h:878: warning: Function parameter or member 'override_dispclk_programming' not described in 'dc_debug_options'
Introduced by commit
7bd571b274fd ("drm/amd/display: DAL to program DISPCLK WDIVIDER if PMFW doesn't")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2023-02-15 4:13 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2023-02-15 4:13 UTC (permalink / raw)
To: Alex Deucher
Cc: Wenjing Liu, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/display/dc/dc.h:877: warning: Function parameter or member 'temp_mst_deallocation_sequence' not described in 'dc_debug_options'
Introduced by commit
3d8fcc6740c9 ("drm/amd/display: Extract temp drm mst deallocation wa into its own function")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2023-01-18 3:13 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2023-01-18 3:13 UTC (permalink / raw)
To: Alex Deucher
Cc: Charlene Liu, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/display/dc/dc.h:877: warning: Function parameter or member 'dig_fifo_off_in_blank' not described in 'dc_debug_options'
Introduced by commit
40774ad1c460 ("drm/amd/display: contional remove disable dig_fifo when blank")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2022-12-15 0:35 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2022-12-15 0:35 UTC (permalink / raw)
To: Alex Deucher
Cc: Dillon Varone, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/display/dc/dc.h:876: warning: Function parameter or member 'disable_unbounded_requesting' not described in 'dc_debug_options'
Introduced by commit
c96d529773db ("drm/amd/display: Add debug bit to disable unbounded requesting")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2022-11-18 6:47 Stephen Rothwell
@ 2022-11-18 8:29 ` Christian König
0 siblings, 0 replies; 68+ messages in thread
From: Christian König @ 2022-11-18 8:29 UTC (permalink / raw)
To: Stephen Rothwell, Alex Deucher
Cc: Linux Kernel Mailing List, Linux Next Mailing List
Am 18.11.22 um 07:47 schrieb Stephen Rothwell:
> Hi all,
>
> After merging the amdgpu tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Error: Cannot open file /home/sfr/next/next/drivers/gpu/drm/amd/amdgpu/amdgpu_mn
> .c
>
> Introduced by commit
>
> d9483ecd327b ("drm/amdgpu: rename the files for HMM handling")
>
> This file is mentioned in Documentation/gpu/amdgpu/driver-core.rst
>
Ah, thanks for pointing that out. Looks like I missed that reference.
Going to fix it ASAP.
Thanks,
Christian.
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2022-11-18 6:47 Stephen Rothwell
2022-11-18 8:29 ` Christian König
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2022-11-18 6:47 UTC (permalink / raw)
To: Alex Deucher
Cc: Christian König, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
Error: Cannot open file /home/sfr/next/next/drivers/gpu/drm/amd/amdgpu/amdgpu_mn
.c
Introduced by commit
d9483ecd327b ("drm/amdgpu: rename the files for HMM handling")
This file is mentioned in Documentation/gpu/amdgpu/driver-core.rst
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2022-11-10 7:23 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2022-11-10 7:23 UTC (permalink / raw)
To: Alex Deucher
Cc: Dillon Varone, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/display/dc/dc.h:869: warning: Function parameter or member 'min_prefetch_in_strobe_ns' not described in 'dc_debug_options'
Introduced by commit
01c0c124b9ec ("drm/amd/display: Enforce minimum prefetch time for low memclk on DCN32")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2022-10-28 3:33 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2022-10-28 3:33 UTC (permalink / raw)
To: Alex Deucher
Cc: Rodrigo Siqueira, Aurabindo Pillai, Mark Broadworth,
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/display/dc/dc.h:502: warning: cannot understand function prototype: 'struct dc_clocks '
Introduced by commit
1682bd1a6b5f ("drm/amd/display: Expand kernel doc for DC")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2022-10-26 1:14 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2022-10-26 1:14 UTC (permalink / raw)
To: Alex Deucher
Cc: Aurabindo Pillai, Rodrigo Siqueira, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/display/dc/dc.h:1289: warning: Function parameter or member 'plane_states' not described in 'dc_validation_set'
Introduced by commit
f6ae69f49fcf ("drm/amd/display: Include surface of unaffected streams")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2022-10-24 4:14 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2022-10-24 4:14 UTC (permalink / raw)
To: Alex Deucher
Cc: Aurabindo Pillai, Rodrigo Siqueira, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 408 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/display/dc/dc.h:1275: warning: cannot understand function prototype: 'struct dc_validation_set '
Introduced by commit
f4a59996c408 ("drm/amd/display: Include surface of unaffected streams")
The word "struct" was left out of the comment.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2022-08-31 5:37 Stephen Rothwell
@ 2022-10-09 22:58 ` Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2022-10-09 22:58 UTC (permalink / raw)
To: Alex Deucher
Cc: Michael Strauss, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
Hi all,
On Wed, 31 Aug 2022 15:37:42 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the amdgpu tree, today's linux-next build (htmldocs)
> produced this warning:
>
> drivers/gpu/drm/amd/display/dc/dc.h:848: warning: Function parameter or member 'lttpr_mode_override' not described in 'dc_debug_options'
>
> Introduced by commit
>
> 280f1884892f ("drm/amd/display: Add DC debug option to force LTTPR mode")
I am still seeing this warning.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2022-08-30 23:04 ` Stephen Rothwell
@ 2022-10-05 0:36 ` Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2022-10-05 0:36 UTC (permalink / raw)
To: Dave Airlie
Cc: Alex Deucher, Rodrigo Siqueira, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 17893 bytes --]
Hi all,
On Wed, 31 Aug 2022 09:04:26 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Fri, 12 Aug 2022 08:13:47 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the amdgpu tree, today's linux-next build (htmldocs)
> > produced this warning:
> >
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'always_scale' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'always_use_regamma' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'aux_wake_wa' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'avoid_vbios_exec_table' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'az_endpoint_mute_only' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'bandwidth_calcs_trace' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'bw_val_profile' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'clock_trace' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'cm_in_bypass' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'crb_alloc_policy' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'crb_alloc_policy_min_disp_count' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_48mhz_pwrdwn' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_clock_gate' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dcc' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dfs_bypass' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dmcu' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dpp_power_gate' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dram_clock_change_vactive_support' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dsc' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dsc_edp' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dsc_power_gate' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dtb_ref_clk_switch' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_fams' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_fec' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_fixed_vs_aux_timeout_wa' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_hubp_power_gate' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_idle_power_optimizations' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_mem_low_power' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_min_fclk' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_pplib_clock_request' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_pplib_wm_range' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_psr' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_stereo_support' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_stutter' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_timing_sync' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_uhbr' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_z10' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_z9_mpc' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dmcub_emulation' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dml_disallow_alternate_prefetch_modes' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dml_hostvm_override' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dmub_command_table' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dmub_offload_enabled' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dpia_debug' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dram_clock_change_latency_ns' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dsc_bpp_increment_div' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dsc_min_slice_height_override' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dwb_fi_phase' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'edid_read_retry_times' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_dmcub_surface_flip' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_dmub_aux_for_legacy_ddc' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_dp_dig_pixel_rate_div_policy' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_dram_clock_change_one_display_vactive' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_driver_sequence_debug' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_mem_low_power' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_single_display_2to1_odm_policy' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_sw_cntl_psr' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_tri_buf' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_z9_disable_interface' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'exit_idle_opt_for_cursor_updates' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'extended_blank_optimization' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'fec_enable_delay_in100us' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'fixed_vs_aux_delay_config_wa' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_abm_enable' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_clock_mode' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_disable_subvp' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_dp2_lt_fallback_method' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_dsc_edp_policy' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_fclk_khz' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_min_dcfclk_mhz' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_odm_combine' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_odm_combine_4to1' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_single_disp_pipe_split' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_subvp_mclk_switch' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_usr_allow' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_vblank_alignment' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'hdmi20_disable' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'hpo_optimization' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'ignore_cable_id' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'legacy_dp2_lt' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'mall_additional_timer_percent' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'mall_error_as_fatal' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'mall_size_override' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'max_disp_clk' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'max_downscale_src_width' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'min_disp_clk_khz' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'min_dpp_clk_khz' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'min_dram_clk_khz' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'mst_start_top_delay' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'native422_support' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'optimize_edp_link_rate' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'optimized_watermark' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'percent_of_ideal_drambw' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'performance_trace' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'pplib_wm_report_mode' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'psr_power_use_phy_fsm' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'pstate_enabled' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'recovery_enabled' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'root_clock_optimization' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'sanity_checks' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'scl_reset_length10' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'seamless_boot_odm_combine' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'set_mst_en_for_sst' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'skip_detection_link_training' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'sr_enter_plus_exit_time_dpm0_ns' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'sr_enter_plus_exit_time_ns' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'sr_exit_time_dpm0_ns' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'sr_exit_time_ns' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'surface_trace' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'timing_trace' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'underflow_assert_delay_us' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'urgent_latency_ns' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'usbc_combo_phy_reset_wa' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'use_legacy_soc_bb_mechanism' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'use_max_lb' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'validate_dml_output' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'validation_trace' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'visual_confirm' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'visual_confirm_rect_height' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'voltage_align_fclk' not described in 'dc_debug_options'
> > drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'vsr_support' not described in 'dc_debug_options'
> >
> > Introduced by commit
> >
> > a2b3b9d57bdb ("drm/amd/display: Document pipe split policy")
>
> I am still seeing these warnings.
That is now commit
ea76895ffab1 ("drm/amd/display: Document pipe split policy")
in the drm tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2022-08-31 5:37 Stephen Rothwell
2022-10-09 22:58 ` Stephen Rothwell
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2022-08-31 5:37 UTC (permalink / raw)
To: Alex Deucher
Cc: Michael Strauss, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/display/dc/dc.h:848: warning: Function parameter or member 'lttpr_mode_override' not described in 'dc_debug_options'
Introduced by commit
280f1884892f ("drm/amd/display: Add DC debug option to force LTTPR mode")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2022-08-11 22:13 Stephen Rothwell
@ 2022-08-30 23:04 ` Stephen Rothwell
2022-10-05 0:36 ` Stephen Rothwell
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2022-08-30 23:04 UTC (permalink / raw)
To: Alex Deucher
Cc: Rodrigo Siqueira, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 17432 bytes --]
Hi all,
On Fri, 12 Aug 2022 08:13:47 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the amdgpu tree, today's linux-next build (htmldocs)
> produced this warning:
>
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'always_scale' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'always_use_regamma' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'aux_wake_wa' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'avoid_vbios_exec_table' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'az_endpoint_mute_only' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'bandwidth_calcs_trace' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'bw_val_profile' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'clock_trace' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'cm_in_bypass' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'crb_alloc_policy' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'crb_alloc_policy_min_disp_count' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_48mhz_pwrdwn' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_clock_gate' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dcc' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dfs_bypass' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dmcu' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dpp_power_gate' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dram_clock_change_vactive_support' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dsc' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dsc_edp' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dsc_power_gate' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dtb_ref_clk_switch' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_fams' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_fec' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_fixed_vs_aux_timeout_wa' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_hubp_power_gate' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_idle_power_optimizations' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_mem_low_power' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_min_fclk' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_pplib_clock_request' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_pplib_wm_range' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_psr' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_stereo_support' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_stutter' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_timing_sync' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_uhbr' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_z10' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_z9_mpc' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dmcub_emulation' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dml_disallow_alternate_prefetch_modes' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dml_hostvm_override' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dmub_command_table' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dmub_offload_enabled' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dpia_debug' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dram_clock_change_latency_ns' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dsc_bpp_increment_div' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dsc_min_slice_height_override' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dwb_fi_phase' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'edid_read_retry_times' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_dmcub_surface_flip' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_dmub_aux_for_legacy_ddc' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_dp_dig_pixel_rate_div_policy' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_dram_clock_change_one_display_vactive' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_driver_sequence_debug' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_mem_low_power' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_single_display_2to1_odm_policy' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_sw_cntl_psr' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_tri_buf' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_z9_disable_interface' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'exit_idle_opt_for_cursor_updates' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'extended_blank_optimization' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'fec_enable_delay_in100us' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'fixed_vs_aux_delay_config_wa' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_abm_enable' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_clock_mode' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_disable_subvp' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_dp2_lt_fallback_method' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_dsc_edp_policy' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_fclk_khz' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_min_dcfclk_mhz' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_odm_combine' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_odm_combine_4to1' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_single_disp_pipe_split' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_subvp_mclk_switch' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_usr_allow' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_vblank_alignment' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'hdmi20_disable' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'hpo_optimization' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'ignore_cable_id' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'legacy_dp2_lt' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'mall_additional_timer_percent' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'mall_error_as_fatal' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'mall_size_override' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'max_disp_clk' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'max_downscale_src_width' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'min_disp_clk_khz' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'min_dpp_clk_khz' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'min_dram_clk_khz' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'mst_start_top_delay' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'native422_support' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'optimize_edp_link_rate' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'optimized_watermark' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'percent_of_ideal_drambw' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'performance_trace' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'pplib_wm_report_mode' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'psr_power_use_phy_fsm' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'pstate_enabled' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'recovery_enabled' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'root_clock_optimization' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'sanity_checks' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'scl_reset_length10' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'seamless_boot_odm_combine' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'set_mst_en_for_sst' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'skip_detection_link_training' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'sr_enter_plus_exit_time_dpm0_ns' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'sr_enter_plus_exit_time_ns' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'sr_exit_time_dpm0_ns' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'sr_exit_time_ns' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'surface_trace' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'timing_trace' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'underflow_assert_delay_us' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'urgent_latency_ns' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'usbc_combo_phy_reset_wa' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'use_legacy_soc_bb_mechanism' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'use_max_lb' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'validate_dml_output' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'validation_trace' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'visual_confirm' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'visual_confirm_rect_height' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'voltage_align_fclk' not described in 'dc_debug_options'
> drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'vsr_support' not described in 'dc_debug_options'
>
> Introduced by commit
>
> a2b3b9d57bdb ("drm/amd/display: Document pipe split policy")
I am still seeing these warnings.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2022-08-11 2:05 Stephen Rothwell
@ 2022-08-30 1:48 ` Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2022-08-30 1:48 UTC (permalink / raw)
To: Alex Deucher
Cc: Rodrigo Siqueira, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 531 bytes --]
Hi all,
On Thu, 11 Aug 2022 12:05:01 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the amdgpu tree, today's linux-next build (htmldoc)
> produced this warning:
>
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:9951: warning: Excess function parameter 'aconnector' description in 'amdgpu_dm_update_freesync_caps'
>
> Introduced by commit
>
> 8889a13f99e5 ("drm/amd/display: Add some extra kernel doc to amdgpu_dm")
I am still seeing this warning.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2022-08-11 22:13 Stephen Rothwell
2022-08-30 23:04 ` Stephen Rothwell
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2022-08-11 22:13 UTC (permalink / raw)
To: Alex Deucher
Cc: Rodrigo Siqueira, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 17053 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'always_scale' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'always_use_regamma' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'aux_wake_wa' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'avoid_vbios_exec_table' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'az_endpoint_mute_only' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'bandwidth_calcs_trace' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'bw_val_profile' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'clock_trace' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'cm_in_bypass' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'crb_alloc_policy' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'crb_alloc_policy_min_disp_count' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_48mhz_pwrdwn' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_clock_gate' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dcc' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dfs_bypass' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dmcu' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dpp_power_gate' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dram_clock_change_vactive_support' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dsc' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dsc_edp' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dsc_power_gate' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_dtb_ref_clk_switch' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_fams' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_fec' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_fixed_vs_aux_timeout_wa' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_hubp_power_gate' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_idle_power_optimizations' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_mem_low_power' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_min_fclk' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_pplib_clock_request' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_pplib_wm_range' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_psr' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_stereo_support' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_stutter' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_timing_sync' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_uhbr' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_z10' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'disable_z9_mpc' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dmcub_emulation' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dml_disallow_alternate_prefetch_modes' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dml_hostvm_override' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dmub_command_table' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dmub_offload_enabled' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dpia_debug' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dram_clock_change_latency_ns' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dsc_bpp_increment_div' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dsc_min_slice_height_override' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'dwb_fi_phase' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'edid_read_retry_times' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_dmcub_surface_flip' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_dmub_aux_for_legacy_ddc' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_dp_dig_pixel_rate_div_policy' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_dram_clock_change_one_display_vactive' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_driver_sequence_debug' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_mem_low_power' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_single_display_2to1_odm_policy' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_sw_cntl_psr' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_tri_buf' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'enable_z9_disable_interface' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'exit_idle_opt_for_cursor_updates' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'extended_blank_optimization' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'fec_enable_delay_in100us' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'fixed_vs_aux_delay_config_wa' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_abm_enable' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_clock_mode' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_disable_subvp' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_dp2_lt_fallback_method' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_dsc_edp_policy' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_fclk_khz' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_min_dcfclk_mhz' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_odm_combine' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_odm_combine_4to1' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_single_disp_pipe_split' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_subvp_mclk_switch' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_usr_allow' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'force_vblank_alignment' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'hdmi20_disable' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'hpo_optimization' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'ignore_cable_id' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'legacy_dp2_lt' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'mall_additional_timer_percent' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'mall_error_as_fatal' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'mall_size_override' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'max_disp_clk' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'max_downscale_src_width' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'min_disp_clk_khz' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'min_dpp_clk_khz' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'min_dram_clk_khz' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'mst_start_top_delay' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'native422_support' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'optimize_edp_link_rate' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'optimized_watermark' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'percent_of_ideal_drambw' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'performance_trace' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'pplib_wm_report_mode' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'psr_power_use_phy_fsm' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'pstate_enabled' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'recovery_enabled' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'root_clock_optimization' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'sanity_checks' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'scl_reset_length10' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'seamless_boot_odm_combine' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'set_mst_en_for_sst' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'skip_detection_link_training' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'sr_enter_plus_exit_time_dpm0_ns' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'sr_enter_plus_exit_time_ns' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'sr_exit_time_dpm0_ns' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'sr_exit_time_ns' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'surface_trace' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'timing_trace' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'underflow_assert_delay_us' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'urgent_latency_ns' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'usbc_combo_phy_reset_wa' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'use_legacy_soc_bb_mechanism' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'use_max_lb' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'validate_dml_output' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'validation_trace' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'visual_confirm' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'visual_confirm_rect_height' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'voltage_align_fclk' not described in 'dc_debug_options'
drivers/gpu/drm/amd/display/dc/dc.h:847: warning: Function parameter or member 'vsr_support' not described in 'dc_debug_options'
Introduced by commit
a2b3b9d57bdb ("drm/amd/display: Document pipe split policy")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2022-08-11 2:05 Stephen Rothwell
2022-08-30 1:48 ` Stephen Rothwell
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2022-08-11 2:05 UTC (permalink / raw)
To: Alex Deucher
Cc: Rodrigo Siqueira, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldoc)
produced this warning:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:9951: warning: Excess function parameter 'aconnector' description in 'amdgpu_dm_update_freesync_caps'
Introduced by commit
8889a13f99e5 ("drm/amd/display: Add some extra kernel doc to amdgpu_dm")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2022-06-23 7:47 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2022-06-23 7:47 UTC (permalink / raw)
To: Alex Deucher
Cc: Andrey Grodzovsky, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 438 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:5094: warning: expecting prototype for amdgpu_device_gpu_recover_imp(). Prototype was for amdgpu_device_gpu_recover() instead
Introduced by commit
cf727044144d ("drm/amdgpu: Rename amdgpu_device_gpu_recover_imp back to amdgpu_device_gpu_recover")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2022-03-25 8:07 Stephen Rothwell
@ 2022-03-25 8:11 ` Christian König
0 siblings, 0 replies; 68+ messages in thread
From: Christian König @ 2022-03-25 8:11 UTC (permalink / raw)
To: Stephen Rothwell, Alex Deucher
Cc: Linux Kernel Mailing List, Linux Next Mailing List
Thanks for the notice, going to take a look.
Christian.
Am 25.03.22 um 09:07 schrieb Stephen Rothwell:
> Hi all,
>
> After merging the amdgpu tree, today's linux-next build (htmldocs)
> produced this warning:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:94: warning: cannot understand function prototype: 'struct amdgpu_vm_tlb_seq_cb '
>
> Introduced by commit
>
> 0de6faf15895 ("drm/amdgpu: rework TLB flushing")
>
> Presumably caused by the kerneldoc like comment above the struct
> definition.
>
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2022-03-25 8:07 Stephen Rothwell
2022-03-25 8:11 ` Christian König
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2022-03-25 8:07 UTC (permalink / raw)
To: Alex Deucher
Cc: Christian König, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 420 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:94: warning: cannot understand function prototype: 'struct amdgpu_vm_tlb_seq_cb '
Introduced by commit
0de6faf15895 ("drm/amdgpu: rework TLB flushing")
Presumably caused by the kerneldoc like comment above the struct
definition.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2021-08-25 2:51 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2021-08-25 2:51 UTC (permalink / raw)
To: Alex Deucher
Cc: Fangzhi Zuo, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c: In function 'apply_single_controller_ctx_to_hw':
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1495:20: warning: unused variable 'params' [-Wunused-variable]
1495 | struct drr_params params = {0};
| ^~~~~~
Introduced by commit
5de27e1d6755 ("drm/amd/display: Add DP 2.0 SST DC Support")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2021-06-05 2:26 Stephen Rothwell
@ 2021-06-05 14:39 ` Eric Huang
0 siblings, 0 replies; 68+ messages in thread
From: Eric Huang @ 2021-06-05 14:39 UTC (permalink / raw)
To: Stephen Rothwell, Alex Deucher
Cc: Linux Kernel Mailing List, Linux Next Mailing List
Thanks. I will fix it.
Regards,
Eric
On 2021-06-04 10:26 p.m., Stephen Rothwell wrote:
> Hi all,
>
> After merging the amdgpu tree, yesterday's linux-next build (htmldocs)
> produced this warning:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1838: warning: Function parameter or member 'table_freed' not described in 'amdgpu_vm_bo_update'
>
> Introduced by commit
>
> 891069653f51 ("drm/amdgpu: Add table_freed parameter to amdgpu_vm_bo_update")
>
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2021-06-05 2:26 Stephen Rothwell
2021-06-05 14:39 ` Eric Huang
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2021-06-05 2:26 UTC (permalink / raw)
To: Alex Deucher
Cc: Eric Huang, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
Hi all,
After merging the amdgpu tree, yesterday's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1838: warning: Function parameter or member 'table_freed' not described in 'amdgpu_vm_bo_update'
Introduced by commit
891069653f51 ("drm/amdgpu: Add table_freed parameter to amdgpu_vm_bo_update")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2021-06-03 9:22 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2021-06-03 9:22 UTC (permalink / raw)
To: Alex Deucher; +Cc: Yu Kuai, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
include/drm/drm_atomic.h:908: warning: Function parameter or member '__state' not described in 'for_each_new_plane_in_state_reverse'
include/drm/drm_atomic.h:908: warning: Function parameter or member 'plane' not described in 'for_each_new_plane_in_state_reverse'
include/drm/drm_atomic.h:908: warning: Function parameter or member 'new_plane_state' not described in 'for_each_new_plane_in_state_reverse'
include/drm/drm_atomic.h:908: warning: Function parameter or member '__i' not described in 'for_each_new_plane_in_state_reverse'
Introduced by commit
a6c3c37b661d ("drm/amd/display: fix gcc set but not used warning of variable 'old_plane_state'")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2021-05-28 1:50 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2021-05-28 1:50 UTC (permalink / raw)
To: Alex Deucher
Cc: Fangzhi Zuo, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'apply_dsc_policy_for_stream':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5576:24: warning: unused variable 'drm_connector' [-Wunused-variable]
5576 | struct drm_connector *drm_connector = &aconnector->base;
| ^~~~~~~~~~~~~
At top level:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5572:13: warning: 'apply_dsc_policy_for_stream' defined but not used [-Wunused-function]
5572 | static void apply_dsc_policy_for_stream(struct amdgpu_dm_connector *aconnector,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5556:13: warning: 'update_dsc_caps' defined but not used [-Wunused-function]
5556 | static void update_dsc_caps(struct amdgpu_dm_connector *aconnector,
| ^~~~~~~~~~~~~~~
Introduced by commit
998b7ad2efd4 ("drm/amd/display: Refactor SST DSC Determination Policy")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
[not found] ` <DM4PR12MB5133E6A99840D1E8542C0D23F7599@DM4PR12MB5133.namprd12.prod.outlook.com>
@ 2021-05-05 2:55 ` Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2021-05-05 2:55 UTC (permalink / raw)
To: Shih, Jude
Cc: Stephen Rothwell, Alex Deucher, Ma, Hanghong, Kazlauskas,
Nicholas, Wheeler, Daniel, Dave Airlie,
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
Hi Jude,
On Wed, 5 May 2021 01:08:48 +0000 "Shih, Jude" <Jude.Shih@amd.com> wrote:
>
> This function is used as below. This commit also passed the auto
> test. Is there anything different between our evnrionment?
The function is defined unconditionally, but only used if
CONFIG_DRM_AMD_DC_DCN is defined.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2021-05-04 23:39 Stephen Rothwell
[not found] ` <DM4PR12MB5133E6A99840D1E8542C0D23F7599@DM4PR12MB5133.namprd12.prod.outlook.com>
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2021-05-04 23:39 UTC (permalink / raw)
To: Alex Deucher
Cc: Jude Shih, Hanghong Ma, Nicholas Kazlauskas, Daniel Wheeler,
Dave Airlie, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 508 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
At top level:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:633:13: warning: 'dm_dmub_outbox1_low_irq' defined but not used [-Wunused-function]
633 | static void dm_dmub_outbox1_low_irq(void *interrupt_params)
| ^~~~~~~~~~~~~~~~~~~~~~~
Introduced by commit
77a49c458931 ("drm/amd/display: Support for DMUB AUX")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2021-04-26 12:40 Stephen Rothwell
@ 2021-04-26 14:40 ` Nirmoy
0 siblings, 0 replies; 68+ messages in thread
From: Nirmoy @ 2021-04-26 14:40 UTC (permalink / raw)
To: Stephen Rothwell, Alex Deucher
Cc: Nirmoy Das, Dave Airlie, Linux Kernel Mailing List,
Linux Next Mailing List
Sorry about that and thanks Stephen, I will send a patch to fix the doc
warning.
Regards,
Nirmoy
On 4/26/21 2:40 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the amdgpu tree, today's linux-next build (htmldocs)
> produced this warning:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:2808: warning: Excess function parameter 'vm_context' description in 'amdgpu_vm_init'
>
> Introduced by commit
>
> a35455d065c5 ("drm/amdgpu: cleanup amdgpu_vm_init()")
>
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2021-04-26 12:40 Stephen Rothwell
2021-04-26 14:40 ` Nirmoy
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2021-04-26 12:40 UTC (permalink / raw)
To: Alex Deucher
Cc: Nirmoy Das, Dave Airlie, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:2808: warning: Excess function parameter 'vm_context' description in 'amdgpu_vm_init'
Introduced by commit
a35455d065c5 ("drm/amdgpu: cleanup amdgpu_vm_init()")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2021-04-23 20:36 ` Alex Deucher
@ 2021-04-23 22:39 ` Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2021-04-23 22:39 UTC (permalink / raw)
To: Alex Deucher
Cc: Stephen Rothwell, Prike Liang, Shyam Sundar S K,
Linux Kernel Mailing List, Linux Next Mailing List, Dave Airlie,
DRI
Hi Alex,
On Fri, 23 Apr 2021 16:36:50 -0400 Alex Deucher <alexdeucher@gmail.com> wrote:
>
> On Wed, Apr 21, 2021 at 2:40 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Fri, 16 Apr 2021 12:40:44 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the amdgpu tree, today's linux-next build (powerpc
> > > ppc64_defconfig) produced this warning:
> > >
> > > drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> > > drivers/pci/quirks.c:312:18: warning: unused variable 'rdev' [-Wunused-variable]
> > > 312 | struct pci_dev *rdev;
> > > | ^~~~
> > >
> > > Introduced by commit
> > >
> > > 9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")
> >
> > I am still seeing this warning.
>
> I no longer have that patch in my tree. Was this an old build?
I guess my email crossed with the patch removal as I not longer get the
warning. Thanks.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2021-04-21 6:40 ` Stephen Rothwell
@ 2021-04-23 20:36 ` Alex Deucher
2021-04-23 22:39 ` Stephen Rothwell
0 siblings, 1 reply; 68+ messages in thread
From: Alex Deucher @ 2021-04-23 20:36 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Prike Liang, Shyam Sundar S K, Linux Kernel Mailing List,
Linux Next Mailing List, Dave Airlie, DRI
On Wed, Apr 21, 2021 at 2:40 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> On Fri, 16 Apr 2021 12:40:44 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the amdgpu tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> > drivers/pci/quirks.c:312:18: warning: unused variable 'rdev' [-Wunused-variable]
> > 312 | struct pci_dev *rdev;
> > | ^~~~
> >
> > Introduced by commit
> >
> > 9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")
>
> I am still seeing this warning.
I no longer have that patch in my tree. Was this an old build?
Alex
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2021-04-16 2:40 Stephen Rothwell
2021-04-16 3:12 ` Liang, Prike
@ 2021-04-21 6:40 ` Stephen Rothwell
2021-04-23 20:36 ` Alex Deucher
1 sibling, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2021-04-21 6:40 UTC (permalink / raw)
To: Alex Deucher
Cc: Prike Liang, Shyam Sundar S K, Linux Kernel Mailing List,
Linux Next Mailing List, Dave Airlie, DRI
[-- Attachment #1: Type: text/plain, Size: 624 bytes --]
Hi all,
On Fri, 16 Apr 2021 12:40:44 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the amdgpu tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> drivers/pci/quirks.c:312:18: warning: unused variable 'rdev' [-Wunused-variable]
> 312 | struct pci_dev *rdev;
> | ^~~~
>
> Introduced by commit
>
> 9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")
I am still seeing this warning.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2021-03-22 6:00 Stephen Rothwell
@ 2021-04-21 6:15 ` Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2021-04-21 6:15 UTC (permalink / raw)
To: Dave Airlie, DRI
Cc: Alex Deucher, Leo (Hanghong) Ma, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
Hi all,
On Mon, 22 Mar 2021 17:00:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the amdgpu tree, today's linux-next build (htmldocs)
> produced this warning:
>
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:405: warning: Function parameter or member 'dmcub_trace_event_en' not described in 'amdgpu_display_manager'
>
> Introduced by commit
>
> 4057828a1283 ("drm/amd/display: Add debugfs to control DMUB trace buffer events")
I am still seeing this warning (as of next-20210420). That is now
commit
46a83eba276c ("drm/amd/display: Add debugfs to control DMUB trace buffer events")
in the drm tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2021-03-11 11:00 Stephen Rothwell
@ 2021-04-21 6:10 ` Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2021-04-21 6:10 UTC (permalink / raw)
To: Dave Airlie, DRI
Cc: Alex Deucher, Harry Wentland, Zhan Liu,
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
Hi all,
On Thu, 11 Mar 2021 22:00:33 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the amdgpu tree, today's linux-next build (htmldocs)
> produced this warning:
>
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:143: warning: Function parameter or member 'list' not described in 'dal_allocation'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:143: warning: Function parameter or member 'bo' not described in 'dal_allocation'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:143: warning: Function parameter or member 'cpu_ptr' not described in 'dal_allocation'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:143: warning: Function parameter or member 'gpu_addr' not described in 'dal_allocation'
>
> Introduced by commit
>
> 1ace37b873c2 ("drm/amdgpu/display: Implement functions to let DC allocate GPU memory")
I am still seeing these warnings (as of next-20210420). That is now
commit
0dd795323405 ("drm/amdgpu/display: Implement functions to let DC allocate GPU memory")
in the drm tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2021-04-16 5:47 ` Liang, Prike
@ 2021-04-16 5:51 ` Alex Deucher
0 siblings, 0 replies; 68+ messages in thread
From: Alex Deucher @ 2021-04-16 5:51 UTC (permalink / raw)
To: Liang, Prike
Cc: Stephen Rothwell, S-k, Shyam-sundar, Linux Kernel Mailing List,
Linux Next Mailing List
On Fri, Apr 16, 2021 at 1:47 AM Liang, Prike <Prike.Liang@amd.com> wrote:
>
> [AMD Public Use]
>
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Sent: Friday, April 16, 2021 12:09 PM
> > To: Liang, Prike <Prike.Liang@amd.com>
> > Cc: Alex Deucher <alexdeucher@gmail.com>; S-k, Shyam-sundar <Shyam-
> > sundar.S-k@amd.com>; Linux Kernel Mailing List <linux-
> > kernel@vger.kernel.org>; Linux Next Mailing List <linux-next@vger.kernel.org>
> > Subject: Re: linux-next: build warning after merge of the amdgpu tree
> >
> > Hi,
> >
> > On Fri, 16 Apr 2021 03:12:12 +0000 "Liang, Prike" <Prike.Liang@amd.com>
> > wrote:
> > >
> > > Hi, Rothwell
> >
> > (Stephen, actually :-))
> >
> > > This fix solution hasn't locked down and still being discussed and roll-
> > updated in the NVMe mail group.
> > > Will update the patch once it refined done.
> >
> > In which case, this patch should not be in linux-next (or any branch that is
> > included by linux-next).
> >
> How about revert the patch temporally ? Once lock down the solution and will land in the final latest patch.
I'll drop it for now. I just have it in there temporarily while it
makes its way upstream because a lot of people use this branch and it
fixes an important bug.
Alex
^ permalink raw reply [flat|nested] 68+ messages in thread
* RE: linux-next: build warning after merge of the amdgpu tree
2021-04-16 4:08 ` Stephen Rothwell
@ 2021-04-16 5:47 ` Liang, Prike
2021-04-16 5:51 ` Alex Deucher
0 siblings, 1 reply; 68+ messages in thread
From: Liang, Prike @ 2021-04-16 5:47 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Alex Deucher, S-k, Shyam-sundar, Linux Kernel Mailing List,
Linux Next Mailing List
[AMD Public Use]
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Friday, April 16, 2021 12:09 PM
> To: Liang, Prike <Prike.Liang@amd.com>
> Cc: Alex Deucher <alexdeucher@gmail.com>; S-k, Shyam-sundar <Shyam-
> sundar.S-k@amd.com>; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>; Linux Next Mailing List <linux-next@vger.kernel.org>
> Subject: Re: linux-next: build warning after merge of the amdgpu tree
>
> Hi,
>
> On Fri, 16 Apr 2021 03:12:12 +0000 "Liang, Prike" <Prike.Liang@amd.com>
> wrote:
> >
> > Hi, Rothwell
>
> (Stephen, actually :-))
>
> > This fix solution hasn't locked down and still being discussed and roll-
> updated in the NVMe mail group.
> > Will update the patch once it refined done.
>
> In which case, this patch should not be in linux-next (or any branch that is
> included by linux-next).
>
How about revert the patch temporally ? Once lock down the solution and will land in the final latest patch.
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2021-04-16 3:12 ` Liang, Prike
@ 2021-04-16 4:08 ` Stephen Rothwell
2021-04-16 5:47 ` Liang, Prike
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2021-04-16 4:08 UTC (permalink / raw)
To: Liang, Prike
Cc: Alex Deucher, S-k, Shyam-sundar, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
Hi,
On Fri, 16 Apr 2021 03:12:12 +0000 "Liang, Prike" <Prike.Liang@amd.com> wrote:
>
> Hi, Rothwell
(Stephen, actually :-))
> This fix solution hasn't locked down and still being discussed and roll-updated in the NVMe mail group.
> Will update the patch once it refined done.
In which case, this patch should not be in linux-next (or any branch
that is included by linux-next).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* RE: linux-next: build warning after merge of the amdgpu tree
2021-04-16 2:40 Stephen Rothwell
@ 2021-04-16 3:12 ` Liang, Prike
2021-04-16 4:08 ` Stephen Rothwell
2021-04-21 6:40 ` Stephen Rothwell
1 sibling, 1 reply; 68+ messages in thread
From: Liang, Prike @ 2021-04-16 3:12 UTC (permalink / raw)
To: Stephen Rothwell, Alex Deucher
Cc: S-k, Shyam-sundar, Linux Kernel Mailing List, Linux Next Mailing List
[AMD Public Use]
Hi, Rothwell
This fix solution hasn't locked down and still being discussed and roll-updated in the NVMe mail group.
Will update the patch once it refined done.
Thanks,
Prike
> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Friday, April 16, 2021 10:41 AM
> To: Alex Deucher <alexdeucher@gmail.com>
> Cc: Liang, Prike <Prike.Liang@amd.com>; S-k, Shyam-sundar <Shyam-
> sundar.S-k@amd.com>; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>; Linux Next Mailing List <linux-next@vger.kernel.org>
> Subject: linux-next: build warning after merge of the amdgpu tree
>
> Hi all,
>
> After merging the amdgpu tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> drivers/pci/quirks.c:312:18: warning: unused variable 'rdev' [-Wunused-
> variable]
> 312 | struct pci_dev *rdev;
> | ^~~~
>
> Introduced by commit
>
> 9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to
> simple suspend/resume path")
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2021-04-16 2:40 Stephen Rothwell
2021-04-16 3:12 ` Liang, Prike
2021-04-21 6:40 ` Stephen Rothwell
0 siblings, 2 replies; 68+ messages in thread
From: Stephen Rothwell @ 2021-04-16 2:40 UTC (permalink / raw)
To: Alex Deucher
Cc: Prike Liang, Shyam Sundar S K, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 481 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
drivers/pci/quirks.c:312:18: warning: unused variable 'rdev' [-Wunused-variable]
312 | struct pci_dev *rdev;
| ^~~~
Introduced by commit
9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2021-03-24 6:48 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2021-03-24 6:48 UTC (permalink / raw)
To: Alex Deucher
Cc: Wayne Lin, Daniel Wheeler, Rodrigo Siqueira, Solomon Chiu,
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:398: warning: Incorrect use of kernel-doc format: * @crc_rd_wrk
Introduced by commit
bbf514b0c626 ("drm/amd/display: Add kernel doc to crc_rd_wrk field")
It is missing a ':' after 'crc_rd_wrk'.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2021-03-24 2:33 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2021-03-24 2:33 UTC (permalink / raw)
To: Alex Deucher
Cc: Leo (Hanghong) Ma, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:926:13: warning: 'dm_dmub_trace_high_irq' defined but not used [-Wunused-function]
926 | static void dm_dmub_trace_high_irq(void *interrupt_params)
| ^~~~~~~~~~~~~~~~~~~~~~
Introduced by commit
44a76bac327c ("drm/amd/display: Log DMCUB trace buffer events")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2021-03-22 6:00 Stephen Rothwell
2021-04-21 6:15 ` Stephen Rothwell
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2021-03-22 6:00 UTC (permalink / raw)
To: Alex Deucher
Cc: Leo (Hanghong) Ma, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:405: warning: Function parameter or member 'dmcub_trace_event_en' not described in 'amdgpu_display_manager'
Introduced by commit
4057828a1283 ("drm/amd/display: Add debugfs to control DMUB trace buffer events")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2021-03-11 11:00 Stephen Rothwell
2021-04-21 6:10 ` Stephen Rothwell
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2021-03-11 11:00 UTC (permalink / raw)
To: Alex Deucher
Cc: Harry Wentland, Zhan Liu, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:143: warning: Function parameter or member 'list' not described in 'dal_allocation'
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:143: warning: Function parameter or member 'bo' not described in 'dal_allocation'
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:143: warning: Function parameter or member 'cpu_ptr' not described in 'dal_allocation'
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:143: warning: Function parameter or member 'gpu_addr' not described in 'dal_allocation'
Introduced by commit
1ace37b873c2 ("drm/amdgpu/display: Implement functions to let DC allocate GPU memory")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2021-03-09 2:55 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2021-03-09 2:55 UTC (permalink / raw)
To: Alex Deucher
Cc: Wayne Lin, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 378 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:380: warning: Function parameter or member 'crc_rd_wrk' not described in 'amdgpu_display_manager'
Introduced by commit
9a65df193108 ("drm/amd/display: Use PSP TA to read out crc")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2021-03-03 6:00 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2021-03-03 6:00 UTC (permalink / raw)
To: Alex Deucher
Cc: Xiaogang Chen, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 403 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c:86: warning: Function parameter or member 'work' not described in 'amdgpu_dm_irq_handler_data'
Introduced by commit
b6f91fc183f7 ("drm/amdgpu/display: buffer INTERRUPT_LOW_IRQ_CONTEXT interrupt work")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2021-02-23 23:48 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2021-02-23 23:48 UTC (permalink / raw)
To: Alex Deucher
Cc: Qingqing Zhuo, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_set_vblank':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5439:33: warning: unused variable 'dm' [-Wunused-variable]
5439 | struct amdgpu_display_manager *dm = &adev->dm;
| ^~
Introduced by commit
3cfd14b67b2c ("drm/amd/display: Fix system hang after multiple hotplugs (v2)")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2021-01-21 3:07 ` Alex Deucher
@ 2021-01-21 8:32 ` Daniel Vetter
0 siblings, 0 replies; 68+ messages in thread
From: Daniel Vetter @ 2021-01-21 8:32 UTC (permalink / raw)
To: Alex Deucher
Cc: Stephen Rothwell, Dave Airlie, Linux Next Mailing List,
Bhawanpreet Lakha, Linux Kernel Mailing List, DRI
On Thu, Jan 21, 2021 at 4:07 AM Alex Deucher <alexdeucher@gmail.com> wrote:
>
> On Wed, Jan 20, 2021 at 7:53 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >
> > > > After merging the amdgpu tree, today's linux-next build (x86_64
> > > > allmodconfig) failed like this:
> > > >
> > > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_set_vblank':
> > > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: warning: unused variable 'dm' [-Wunused-variable]
> > > > 5380 | struct amdgpu_display_manager *dm = &adev->dm;
> > > > | ^~
> > > >
> > > > Caused by commit
> > > >
> > > > 98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")
> > >
> > > I am still getting this warning.
> >
> > I now get this warning from the drm tree merge.
Drat, I missed that when merging.
> Bhawan sent out the fix today:
> https://patchwork.freedesktop.org/patch/415092/
Applied directly to drm-next, thanks.
-Daniel
>
> Alex
>
> >
> > --
> > Cheers,
> > Stephen Rothwell
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2021-01-21 0:53 ` Stephen Rothwell
@ 2021-01-21 3:07 ` Alex Deucher
2021-01-21 8:32 ` Daniel Vetter
0 siblings, 1 reply; 68+ messages in thread
From: Alex Deucher @ 2021-01-21 3:07 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Dave Airlie, DRI, Bhawanpreet Lakha, Linux Kernel Mailing List,
Linux Next Mailing List
On Wed, Jan 20, 2021 at 7:53 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the amdgpu tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_set_vblank':
> > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: warning: unused variable 'dm' [-Wunused-variable]
> > > 5380 | struct amdgpu_display_manager *dm = &adev->dm;
> > > | ^~
> > >
> > > Caused by commit
> > >
> > > 98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")
> >
> > I am still getting this warning.
>
> I now get this warning from the drm tree merge.
Bhawan sent out the fix today:
https://patchwork.freedesktop.org/patch/415092/
Alex
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2021-01-20 6:15 ` Stephen Rothwell
@ 2021-01-21 0:53 ` Stephen Rothwell
2021-01-21 3:07 ` Alex Deucher
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2021-01-21 0:53 UTC (permalink / raw)
To: Dave Airlie, DRI
Cc: Alex Deucher, Bhawanpreet Lakha, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
Hi all,
On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the amdgpu tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_set_vblank':
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: warning: unused variable 'dm' [-Wunused-variable]
> > 5380 | struct amdgpu_display_manager *dm = &adev->dm;
> > | ^~
> >
> > Caused by commit
> >
> > 98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")
>
> I am still getting this warning.
I now get this warning from the drm tree merge.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2021-01-15 1:00 Stephen Rothwell
@ 2021-01-20 6:15 ` Stephen Rothwell
2021-01-21 0:53 ` Stephen Rothwell
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2021-01-20 6:15 UTC (permalink / raw)
To: Alex Deucher
Cc: Bhawanpreet Lakha, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 694 bytes --]
Hi all,
On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the amdgpu tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_set_vblank':
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: warning: unused variable 'dm' [-Wunused-variable]
> 5380 | struct amdgpu_display_manager *dm = &adev->dm;
> | ^~
>
> Caused by commit
>
> 98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")
I am still getting this warning.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2021-01-18 6:52 ` Stephen Rothwell
@ 2021-01-18 12:35 ` Huang Rui
0 siblings, 0 replies; 68+ messages in thread
From: Huang Rui @ 2021-01-18 12:35 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Alex Deucher, Linux Kernel Mailing List, Linux Next Mailing List
On Mon, Jan 18, 2021 at 02:52:18PM +0800, Stephen Rothwell wrote:
> Hi Ray,
>
> On Mon, 18 Jan 2021 05:56:20 +0000 "Huang, Ray" <Ray.Huang@amd.com> wrote:
> >
> > [AMD Public Use]
> >
> > Thanks Setphen. Please check attached V2 patch.
> > (If you can share the config file to me, I can do the test in my side)
>
> It looks good, but I did not try to build it. I have attached the
> config (it is just a powerpc allyesconfig).
> --
> Cheers,
> Stephen Rothwell
Thanks Stephen.
Ray
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2021-01-18 5:56 ` Huang, Ray
@ 2021-01-18 6:52 ` Stephen Rothwell
2021-01-18 12:35 ` Huang Rui
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2021-01-18 6:52 UTC (permalink / raw)
To: Huang, Ray
Cc: Alex Deucher, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1.1: Type: text/plain, Size: 386 bytes --]
Hi Ray,
On Mon, 18 Jan 2021 05:56:20 +0000 "Huang, Ray" <Ray.Huang@amd.com> wrote:
>
> [AMD Public Use]
>
> Thanks Setphen. Please check attached V2 patch.
> (If you can share the config file to me, I can do the test in my side)
It looks good, but I did not try to build it. I have attached the
config (it is just a powerpc allyesconfig).
--
Cheers,
Stephen Rothwell
[-- Attachment #1.2: powerpc_allyesconfig.gz --]
[-- Type: application/gzip, Size: 71732 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* RE: linux-next: build warning after merge of the amdgpu tree
2021-01-18 5:29 Stephen Rothwell
@ 2021-01-18 5:56 ` Huang, Ray
2021-01-18 6:52 ` Stephen Rothwell
0 siblings, 1 reply; 68+ messages in thread
From: Huang, Ray @ 2021-01-18 5:56 UTC (permalink / raw)
To: Stephen Rothwell, Alex Deucher
Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
[AMD Public Use]
Thanks Setphen. Please check attached V2 patch.
(If you can share the config file to me, I can do the test in my side)
Best Regards,
Ray
-----Original Message-----
From: Stephen Rothwell <sfr@canb.auug.org.au>
Sent: Monday, January 18, 2021 1:29 PM
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Huang, Ray <Ray.Huang@amd.com>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: build warning after merge of the amdgpu tree
Hi all,
After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) gave this warning:
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: In function 'vangogh_init_smc_tables':
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:338:5: warning: "CONFIG_X86" is not defined, evaluates to 0 [-Wundef]
338 | #if CONFIG_X86
| ^~~~~~~~~~
Caused by commit
9dd19d5232a6 ("drm/amdgpu: fix build error without x86 kconfig")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: 0001-drm-amdgpu-fix-build-error-without-x86-kconfig-v2.patch --]
[-- Type: application/octet-stream, Size: 5386 bytes --]
From 29632df8458b549b32eb655d6e75c47d66ced85d Mon Sep 17 00:00:00 2001
From: Huang Rui <ray.huang@amd.com>
Date: Fri, 15 Jan 2021 15:59:08 +0800
Subject: [PATCH v2] drm/amdgpu: fix build error without x86 kconfig (v2)
This patch is to fix below build error while we are using the kconfig
without x86.
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: In function
'vangogh_get_smu_metrics_data':
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:300:10:
error: 'boot_cpu_data' undeclared (first use in this function); did you
mean 'boot_cpuid'?
300 | boot_cpu_data.x86_max_cores * sizeof(uint16_t));
| ^~~~~~~~~~~~~
| boot_cpuid
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: In function
'vangogh_read_sensor':
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:1320:11:
error: 'boot_cpu_data' undeclared (first use in this function); did you
mean 'boot_cpuid'?
1320 | *size = boot_cpu_data.x86_max_cores * sizeof(uint16_t);
| ^~~~~~~~~~~~~
| boot_cpuid
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: In function
'vangogh_od_edit_dpm_table':
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:1460:19:
error: 'boot_cpu_data' undeclared (first use in this function); did you
mean 'boot_cpuid'?
1460 | if (input[0] >= boot_cpu_data.x86_max_cores) {
| ^~~~~~~~~~~~~
| boot_cpuid
v2: fix #ifdef and add comment for APU only
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Huang Rui <ray.huang@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 ++--
drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h | 2 ++
.../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 17 ++++++++++++-----
3 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index 80d6298912aa..e9b569b76716 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -3633,12 +3633,12 @@ static void amdgpu_debugfs_prints_cpu_info(struct seq_file *m,
int i;
if (is_support_cclk_dpm(adev)) {
- p_val = kcalloc(boot_cpu_data.x86_max_cores, sizeof(uint16_t),
+ p_val = kcalloc(adev->smu.cpu_core_num, sizeof(uint16_t),
GFP_KERNEL);
if (!amdgpu_dpm_read_sensor(adev, AMDGPU_PP_SENSOR_CPU_CLK,
(void *)p_val, &size)) {
- for (i = 0; i < boot_cpu_data.x86_max_cores; i++)
+ for (i = 0; i < adev->smu.cpu_core_num; i++)
seq_printf(m, "\t%u MHz (CPU%d)\n",
*(p_val + i), i);
}
diff --git a/drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h b/drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h
index 25ee9f51813b..a087e00382e6 100644
--- a/drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h
+++ b/drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h
@@ -466,11 +466,13 @@ struct smu_context
uint32_t gfx_actual_hard_min_freq;
uint32_t gfx_actual_soft_max_freq;
+ /* APU only */
uint32_t cpu_default_soft_min_freq;
uint32_t cpu_default_soft_max_freq;
uint32_t cpu_actual_soft_min_freq;
uint32_t cpu_actual_soft_max_freq;
uint32_t cpu_core_id_select;
+ uint16_t cpu_core_num;
};
struct i2c_adapter;
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
index 2f0cb0ea243b..dc41abe7b1d3 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
@@ -297,7 +297,7 @@ static int vangogh_get_smu_metrics_data(struct smu_context *smu,
break;
case METRICS_AVERAGE_CPUCLK:
memcpy(value, &metrics->CoreFrequency[0],
- boot_cpu_data.x86_max_cores * sizeof(uint16_t));
+ smu->cpu_core_num * sizeof(uint16_t));
break;
default:
*value = UINT_MAX;
@@ -335,6 +335,13 @@ static int vangogh_init_smc_tables(struct smu_context *smu)
if (ret)
return ret;
+#ifdef CONFIG_X86
+ /* AMD x86 APU only */
+ smu->cpu_core_num = boot_cpu_data.x86_max_cores;
+#else
+ smu->cpu_core_num = 4;
+#endif
+
return smu_v11_0_init_smc_tables(smu);
}
@@ -1317,7 +1324,7 @@ static int vangogh_read_sensor(struct smu_context *smu,
ret = vangogh_get_smu_metrics_data(smu,
METRICS_AVERAGE_CPUCLK,
(uint32_t *)data);
- *size = boot_cpu_data.x86_max_cores * sizeof(uint16_t);
+ *size = smu->cpu_core_num * sizeof(uint16_t);
break;
default:
ret = -EOPNOTSUPP;
@@ -1457,9 +1464,9 @@ static int vangogh_od_edit_dpm_table(struct smu_context *smu, enum PP_OD_DPM_TAB
dev_err(smu->adev->dev, "Input parameter number not correct (should be 4 for processor)\n");
return -EINVAL;
}
- if (input[0] >= boot_cpu_data.x86_max_cores) {
+ if (input[0] >= smu->cpu_core_num) {
dev_err(smu->adev->dev, "core index is overflow, should be less than %d\n",
- boot_cpu_data.x86_max_cores);
+ smu->cpu_core_num);
}
smu->cpu_core_id_select = input[0];
if (input[1] == 0) {
@@ -1535,7 +1542,7 @@ static int vangogh_od_edit_dpm_table(struct smu_context *smu, enum PP_OD_DPM_TAB
break;
}
- for (i = 0; i < boot_cpu_data.x86_max_cores; i++) {
+ for (i = 0; i < smu->cpu_core_num; i++) {
ret = smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_SetSoftMinCclk,
(i << 20) | smu->cpu_actual_soft_min_freq,
NULL);
--
2.25.1
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2021-01-18 5:29 Stephen Rothwell
2021-01-18 5:56 ` Huang, Ray
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2021-01-18 5:29 UTC (permalink / raw)
To: Alex Deucher
Cc: Huang Rui, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) gave this warning:
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: In function 'vangogh_init_smc_tables':
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:338:5: warning: "CONFIG_X86" is not defined, evaluates to 0 [-Wundef]
338 | #if CONFIG_X86
| ^~~~~~~~~~
Caused by commit
9dd19d5232a6 ("drm/amdgpu: fix build error without x86 kconfig")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2021-01-15 1:00 Stephen Rothwell
2021-01-20 6:15 ` Stephen Rothwell
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2021-01-15 1:00 UTC (permalink / raw)
To: Alex Deucher
Cc: Bhawanpreet Lakha, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 549 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_set_vblank':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: warning: unused variable 'dm' [-Wunused-variable]
5380 | struct amdgpu_display_manager *dm = &adev->dm;
| ^~
Caused by commit
98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2020-12-14 19:56 ` Stephen Rothwell
@ 2020-12-15 2:49 ` Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2020-12-15 2:49 UTC (permalink / raw)
To: Dave Airlie, DRI
Cc: Alex Deucher, Alex Deucher, Wayne Lin, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]
Hi all,
On Tue, 15 Dec 2020 06:56:08 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Tue, 17 Nov 2020 15:45:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the amdgpu tree, today's linux-next build (htmldocs)
> > produced this warning:
> >
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_x_start_property' not described in 'amdgpu_display_manager'
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_y_start_property' not described in 'amdgpu_display_manager'
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_x_end_property' not described in 'amdgpu_display_manager'
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_y_end_property' not described in 'amdgpu_display_manager'
> >
> > Introduced by commit
> >
> > c920888c604d ("drm/amd/display: Expose new CRC window property")
>
> I am still getting those warnings. That commit is now in the drm tree.
These warnings are now from Linus' tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2020-11-17 4:45 Stephen Rothwell
@ 2020-12-14 19:56 ` Stephen Rothwell
2020-12-15 2:49 ` Stephen Rothwell
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2020-12-14 19:56 UTC (permalink / raw)
To: Dave Airlie, DRI
Cc: Alex Deucher, Alex Deucher, Wayne Lin, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
Hi all,
On Tue, 17 Nov 2020 15:45:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the amdgpu tree, today's linux-next build (htmldocs)
> produced this warning:
>
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_x_start_property' not described in 'amdgpu_display_manager'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_y_start_property' not described in 'amdgpu_display_manager'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_x_end_property' not described in 'amdgpu_display_manager'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_y_end_property' not described in 'amdgpu_display_manager'
>
> Introduced by commit
>
> c920888c604d ("drm/amd/display: Expose new CRC window property")
I am still getting those warnings. That commit is now in the drm tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2020-11-17 4:45 Stephen Rothwell
2020-12-14 19:56 ` Stephen Rothwell
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2020-11-17 4:45 UTC (permalink / raw)
To: Alex Deucher
Cc: Alex Deucher, Wayne Lin, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_x_start_property' not described in 'amdgpu_display_manager'
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_y_start_property' not described in 'amdgpu_display_manager'
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_x_end_property' not described in 'amdgpu_display_manager'
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_y_end_property' not described in 'amdgpu_display_manager'
Introduced by commit
c920888c604d ("drm/amd/display: Expose new CRC window property")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2020-04-23 2:24 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2020-04-23 2:24 UTC (permalink / raw)
To: Alex Deucher
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Yintian Tao,
Christian König
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function 'gfx_v8_0_ring_emit_rreg':
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:6396:21: warning: unused variable 'kiq' [-Wunused-variable]
6396 | struct amdgpu_kiq *kiq = &adev->gfx.kiq;
| ^~~
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c: In function 'gfx_v10_0_ring_emit_rreg':
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:7608:21: warning: unused variable 'kiq' [-Wunused-variable]
7608 | struct amdgpu_kiq *kiq = &adev->gfx.kiq;
| ^~~
Introduced by commit
5e25f26086f6 ("drm/amdgpu: request reg_val_offs each kiq read reg")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2020-02-04 22:44 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2020-02-04 22:44 UTC (permalink / raw)
To: Alex Deucher
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Hawking Zhang, Frank Min
[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c: In function 'amdgpu_xgmi_remove_device':
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:466:3: warning: 'return' with no value, in function returning non-void [-Wreturn-type]
466 | return;
| ^~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:461:5: note: declared here
461 | int amdgpu_xgmi_remove_device(struct amdgpu_device *adev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:470:3: warning: 'return' with no value, in function returning non-void [-Wreturn-type]
470 | return;
| ^~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:461:5: note: declared here
461 | int amdgpu_xgmi_remove_device(struct amdgpu_device *adev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
Introduced by commit
2fe4750e8506 ("drm/amdgpu: move xgmi init/fini to xgmi_add/remove_device call")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2019-12-18 23:18 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2019-12-18 23:18 UTC (permalink / raw)
To: Alex Deucher
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jane Jian,
Dave Airlie, DRI
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c: In function 'vcn_v2_5_hw_init':
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:288:5: warning: 'r' may be used uninitialized in this function [-Wmaybe-uninitialized]
288 | if (!r)
| ^
Introduced by commit
99bcbf833e6a ("drm/amdgpu: enable VCN0 and VCN1 sriov instances support for Arcturus")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2019-11-08 0:21 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2019-11-08 0:21 UTC (permalink / raw)
To: Alex Deucher
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Leo Li,
Nicholas Kazlauskas
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:503:13: warning: 'dm_dcn_crtc_high_irq' defined but not used [-Wunused-function]
503 | static void dm_dcn_crtc_high_irq(void *interrupt_params)
| ^~~~~~~~~~~~~~~~~~~~
Introduced by commit
75856c84993d ("drm/amd/display: Send vblank and user events at vsartup for DCN")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2019-07-02 3:53 Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-02 3:53 UTC (permalink / raw)
To: Alex Deucher
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jack Xiao,
Hawking Zhang, Felix Kuehling
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (x86_64
allmodcnofig) produced this warning:
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c: In function 'kgd2kfd_probe':
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c:490:6: warning: unused variable 'ret' [-Wunused-variable]
int ret;
^~~
Introduced by commit
aabf3a951c4e ("drm/amdkfd: remove duplicated PCIE atomics request")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: linux-next: build warning after merge of the amdgpu tree
2019-05-10 0:59 Stephen Rothwell
@ 2019-05-31 1:27 ` Stephen Rothwell
0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2019-05-31 1:27 UTC (permalink / raw)
To: Dave Airlie
Cc: Alex Deucher, Linux Next Mailing List, Linux Kernel Mailing List,
Jonathan Kim
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
Hi all,
On Fri, 10 May 2019 10:59:13 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the amdgpu tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> In file included from drivers/gpu/drm/amd/amdgpu/df_v3_6.c:23:
> drivers/gpu/drm/amd/amdgpu/df_v3_6.c: In function 'df_v3_6_pmc_start':
> drivers/gpu/drm/amd/amdgpu/amdgpu.h:1010:29: warning: 'lo_val' may be used uninitialized in this function [-Wmaybe-uninitialized]
> #define WREG32_PCIE(reg, v) adev->pcie_wreg(adev, (reg), (v))
> ^~~~
> drivers/gpu/drm/amd/amdgpu/df_v3_6.c:334:39: note: 'lo_val' was declared here
> uint32_t lo_base_addr, hi_base_addr, lo_val, hi_val;
> ^~~~~~
>
> Introduced by commit
>
> a6ac0b44bab9 ("drm/amdgpu: add df perfmon regs and funcs for xgmi")
I now get this warning after merging the drm tree ...
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
* linux-next: build warning after merge of the amdgpu tree
@ 2019-05-10 0:59 Stephen Rothwell
2019-05-31 1:27 ` Stephen Rothwell
0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2019-05-10 0:59 UTC (permalink / raw)
To: Alex Deucher
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jonathan Kim
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
Hi all,
After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
In file included from drivers/gpu/drm/amd/amdgpu/df_v3_6.c:23:
drivers/gpu/drm/amd/amdgpu/df_v3_6.c: In function 'df_v3_6_pmc_start':
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1010:29: warning: 'lo_val' may be used uninitialized in this function [-Wmaybe-uninitialized]
#define WREG32_PCIE(reg, v) adev->pcie_wreg(adev, (reg), (v))
^~~~
drivers/gpu/drm/amd/amdgpu/df_v3_6.c:334:39: note: 'lo_val' was declared here
uint32_t lo_base_addr, hi_base_addr, lo_val, hi_val;
^~~~~~
Introduced by commit
a6ac0b44bab9 ("drm/amdgpu: add df perfmon regs and funcs for xgmi")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 68+ messages in thread
end of thread, other threads:[~2023-03-01 0:34 UTC | newest]
Thread overview: 68+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-13 9:57 linux-next: build warning after merge of the amdgpu tree Stephen Rothwell
2020-03-13 12:57 ` [PATCH] drm/amd/powerplay: Move fallthrough; into containing #ifdef/#endif Joe Perches
2020-03-13 14:22 ` Alex Deucher
-- strict thread matches above, loose matches on Subject: below --
2023-03-01 0:34 linux-next: build warning after merge of the amdgpu tree Stephen Rothwell
2023-02-15 4:13 Stephen Rothwell
2023-01-18 3:13 Stephen Rothwell
2022-12-15 0:35 Stephen Rothwell
2022-11-18 6:47 Stephen Rothwell
2022-11-18 8:29 ` Christian König
2022-11-10 7:23 Stephen Rothwell
2022-10-28 3:33 Stephen Rothwell
2022-10-26 1:14 Stephen Rothwell
2022-10-24 4:14 Stephen Rothwell
2022-08-31 5:37 Stephen Rothwell
2022-10-09 22:58 ` Stephen Rothwell
2022-08-11 22:13 Stephen Rothwell
2022-08-30 23:04 ` Stephen Rothwell
2022-10-05 0:36 ` Stephen Rothwell
2022-08-11 2:05 Stephen Rothwell
2022-08-30 1:48 ` Stephen Rothwell
2022-06-23 7:47 Stephen Rothwell
2022-03-25 8:07 Stephen Rothwell
2022-03-25 8:11 ` Christian König
2021-08-25 2:51 Stephen Rothwell
2021-06-05 2:26 Stephen Rothwell
2021-06-05 14:39 ` Eric Huang
2021-06-03 9:22 Stephen Rothwell
2021-05-28 1:50 Stephen Rothwell
2021-05-04 23:39 Stephen Rothwell
[not found] ` <DM4PR12MB5133E6A99840D1E8542C0D23F7599@DM4PR12MB5133.namprd12.prod.outlook.com>
2021-05-05 2:55 ` Stephen Rothwell
2021-04-26 12:40 Stephen Rothwell
2021-04-26 14:40 ` Nirmoy
2021-04-16 2:40 Stephen Rothwell
2021-04-16 3:12 ` Liang, Prike
2021-04-16 4:08 ` Stephen Rothwell
2021-04-16 5:47 ` Liang, Prike
2021-04-16 5:51 ` Alex Deucher
2021-04-21 6:40 ` Stephen Rothwell
2021-04-23 20:36 ` Alex Deucher
2021-04-23 22:39 ` Stephen Rothwell
2021-03-24 6:48 Stephen Rothwell
2021-03-24 2:33 Stephen Rothwell
2021-03-22 6:00 Stephen Rothwell
2021-04-21 6:15 ` Stephen Rothwell
2021-03-11 11:00 Stephen Rothwell
2021-04-21 6:10 ` Stephen Rothwell
2021-03-09 2:55 Stephen Rothwell
2021-03-03 6:00 Stephen Rothwell
2021-02-23 23:48 Stephen Rothwell
2021-01-18 5:29 Stephen Rothwell
2021-01-18 5:56 ` Huang, Ray
2021-01-18 6:52 ` Stephen Rothwell
2021-01-18 12:35 ` Huang Rui
2021-01-15 1:00 Stephen Rothwell
2021-01-20 6:15 ` Stephen Rothwell
2021-01-21 0:53 ` Stephen Rothwell
2021-01-21 3:07 ` Alex Deucher
2021-01-21 8:32 ` Daniel Vetter
2020-11-17 4:45 Stephen Rothwell
2020-12-14 19:56 ` Stephen Rothwell
2020-12-15 2:49 ` Stephen Rothwell
2020-04-23 2:24 Stephen Rothwell
2020-02-04 22:44 Stephen Rothwell
2019-12-18 23:18 Stephen Rothwell
2019-11-08 0:21 Stephen Rothwell
2019-07-02 3:53 Stephen Rothwell
2019-05-10 0:59 Stephen Rothwell
2019-05-31 1:27 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).