From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32B42C1975A for ; Sun, 15 Mar 2020 01:36:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1104320637 for ; Sun, 15 Mar 2020 01:36:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727024AbgCOBgA (ORCPT ); Sat, 14 Mar 2020 21:36:00 -0400 Received: from isilmar-4.linta.de ([136.243.71.142]:44544 "EHLO isilmar-4.linta.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726988AbgCOBf6 (ORCPT ); Sat, 14 Mar 2020 21:35:58 -0400 X-isilmar-external: YES X-isilmar-external: YES Received: from light.dominikbrodowski.net (brodo.linta [10.1.0.102]) by isilmar-4.linta.de (Postfix) with ESMTPSA id ABFFB200B3C; Sat, 14 Mar 2020 13:46:02 +0000 (UTC) Received: by light.dominikbrodowski.net (Postfix, from userid 1000) id B294320821; Sat, 14 Mar 2020 14:36:32 +0100 (CET) Date: Sat, 14 Mar 2020 14:36:32 +0100 From: Dominik Brodowski To: Takashi Iwai Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] pcmcia: Use scnprintf() for avoiding potential buffer overflow Message-ID: <20200314133632.GB453554@light.dominikbrodowski.net> References: <20200311090426.20161-1-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311090426.20161-1-tiwai@suse.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2020 at 10:04:26AM +0100, Takashi Iwai wrote: > Since snprintf() returns the would-be-output size instead of the > actual output size, the succeeding calls may go beyond the given > buffer limit. Fix it by replacing with scnprintf(). > > Signed-off-by: Takashi Iwai Applied to pcmcia-next. Thanks, Dominik